Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,164 Commits 2 Branches 0 Tags 183 MiB
Commit Graph

320 Commits

Author SHA1 Message Date
Remy Oukaour 79873a1bfc Move pic animation documentation to docs/ 
Move growth rates to a data/ table
Name more SECTIONs
 2017-12-11 23:44:29 -05:00
Remy Oukaour f1f84743f7 Keep table labels in the same files as their contents. 2017-12-11 22:44:25 -05:00
Remy Oukaour 720cdc72b2 Comments distinguish "move effects" and "effect commands" 
Effect command enums are used like constants, not macros
 2017-12-11 17:41:18 -05:00
Remy Oukaour 4afc2f01ef Add member constants for the base data struct, same as most other structs 2017-12-11 17:35:35 -05:00
Remy Oukaour 2e41368ac4 Factor out one more data table 2017-12-11 17:11:30 -05:00
Remy Oukaour 41acb0667a Document macros/map.asm 
Rename MORN/DAY/NITE to MORN_F/DAY_F/NITE_F; use MORN/DAY/NITE for shifted values (cleaner for person_events)
Prefix FLOOR to the `elevfloor` constants
 2017-12-11 01:02:28 -05:00
Remy Oukaour b4261d27d8 Use new palette constants 2017-12-10 20:50:08 -05:00
Remy Oukaour a0bef01a1d Define more palette constants 2017-12-10 20:10:39 -05:00
Remy Oukaour ab7025a144 Consistent code formatting: no redundant `a`s and spaces after commas 2017-12-10 00:06:20 -05:00
Remy Oukaour 7ccb11c903 Add constants for battle object colors 2017-12-09 22:07:52 -05:00
Remy Oukaour cd2a748128 More WRAM cleanup 2017-12-09 22:00:36 -05:00
Remy Oukaour e3c686f6df Further WRAM organization 2017-12-09 15:14:51 -05:00
Remy Oukaour 5a5df2ab87 More WRAM organization 2017-12-09 14:47:32 -05:00
Remy Oukaour 6a41d4f63e Define more charmap characters and use them in place of hard-coded numbers 2017-12-09 12:57:23 -05:00
Remy Oukaour 512863989f Document constants with comments, actual names, and more thorough usage 2017-12-09 02:15:46 -05:00
mid-kid a1fc73603e Label all of PARTYMENUACTION_* 
It's pretty clear what it's used for.
PartyMenuActionText is used for two things:
1) Storing what kind of action we're going to do (<$10)
2) Storing the text for some kind of healing stuff I'm not entirely sure (>=$f0)

In the former case, if GetPartyMenuTilemapPointers is ran, it will be
used to pick a sequence of actions that should be done, specified in the
table, and it'll print the corresponding string using the
PartyMenuStrings table. The items in the sequence of actions that should
be done are in WritePartyMenuTilemap.

Strangely enough, one possible value is left completely unused:
PARTYMENUACTION_GIVE_MON_FEMALE. It works in the exact same way as it's
male counterpart, and as such I don't believe it was used in the
japanese version either, since it doesn't matter which gender your 'mon
is when you put 'em in the daycare.
 2017-11-30 20:35:58 +01:00
mid-kid 35a8e9da5d DetermineMobileBattleResult -> DisplayLinkBattleResult 
Changed this function's name, because it confusingly only calls
DetermineLinkBattleResult when linked through mobile.
It does absolutely nothing with determining the battle result in a
regular link battle, and is only responsible for displaying the battle
result and counting stats.
 2017-11-19 11:54:34 +01:00
mid-kid 1bf12455e4 SelfDestruct -> Selfdestruct 
Just keeping things consistent. Nobody's going to write SELF_DESTRUCT.
Kind of subjective, and we could do it the other way around, if anybody
really cares.
 2017-11-18 17:28:12 +01:00
mid-kid fd14253796 Clean up labels in battle/moves/move_effects.asm 
There were a lot of unused labels in there, and a few confusing
misnomers around move_effects_pointers.asm. They now match up exactly
with the names in battle_constants.asm.
Also renamed a few effects, to make their purpose clearer, and to match
up with their respective event script commands:
EFFECT_EXPLOSION    -> EFFECT_SELFDESCTRUCT
EFFECT_HAZE         -> EFFECT_RESET_STATS
EFFECT_WHIRLWIND    -> EFFECT_FORCE_SWITCH
EFFECT_BIND         -> EFFECT_TRAP_TARGET
EFFECT_TWINEEDLE    -> EFFECT_POISON_MULTI_HIT
EFFECT_STEEL_WING   -> EFFECT_DEFENSE_UP_HIT
EFFECT_METAL_CLAW   -> EFFECT_ATTACK_UP_HIT
EFFECT_ANCIENTPOWER -> EFFECT_ALL_UP_HIT
 2017-11-15 16:36:13 +01:00
yenatch d0d61cb3ab Merge pull request #354 from FredrIQ/comments 
Fix a reversed label mistake and reference a major bug
 2017-06-24 17:43:48 -04:00
Ben10do e6ea1889fb
Replace ‘jp [hl]’ with ‘jp hl’ 
The former is arguably misleading (as you don’t access the memory location in hl to retrieve the jump location), and is consequently deprecated in newer versions of rgbds.

This fix silences these deprecation warnings.
 2017-06-09 22:01:10 +01:00
hatschky f0209d6ed6 Labels for Trainer Rankings stat tracking functions 2017-01-16 21:11:34 +00:00
Fredrik Ljungdahl 0e76127da8 Fix an overlooked replace 
The build should match now...
 2017-01-08 01:54:43 +01:00
Fredrik Ljungdahl 9b8f57a730 Explain a major AI-related bug with type matchup checks 2017-01-08 01:33:38 +01:00
Fredrik Ljungdahl f8455e9b4f Reverse the LastEnemyCounterMove and LastPlayerCounterMove labels 
They were swapped
 2017-01-08 01:26:48 +01:00
Fredrik Ljungdahl 146d12d6e5 Point out a bug with enemy usage of Teleport 
Also point out a redundancy in ThunderAccuracy
 2016-10-29 02:09:56 +02:00
Fredrik Ljungdahl 64e4300f4d Fix inverted labels for HandleStatBoostingHeldItems 2016-10-29 02:03:10 +02:00
PikalaxALT 050a0162b8 Rename the variable at D264 2016-08-07 18:14:20 -04:00
pikalaxalt 4e2487c056 hLCDCPointer and InitList 2016-06-13 22:53:33 -04:00
pikalaxalt b0e7d04ccf Some mystery gift functions 2016-06-07 08:08:51 -04:00
pikalaxalt d7a01e92e9 Remaining layout constants 2016-06-06 18:23:00 -04:00
pikalaxalt 12396874cf HP bar animation addresses and AI switch 2016-05-16 09:36:24 -04:00
pikalaxalt 87b733994b SPRITE_ANIM_FRAME_IDX constants 2016-05-15 22:00:17 -04:00
pikalaxalt af0119ca7e Name all printer functions 2016-05-11 17:16:03 -04:00
pikalaxalt ae36ef2c7f Labeled every function in ROM0 that's referenced in the source 2016-05-10 12:31:49 -04:00
pikalaxalt e95d42e0af All functions in main.asm have non-generic names 2016-05-08 14:11:24 -04:00
pikalaxalt bb58230ca7 Credit to chaos_lord2 for decoding that load in computing enemy stats 2016-05-05 15:12:59 -04:00
pikalaxalt 8c26547645 Mobile and more battle anims 2016-05-05 15:07:37 -04:00
pikalaxalt a613ed915c HDMA transfer functions 2016-05-04 22:34:09 -04:00
pikalaxalt 3713b71d9e More splitting of main.asm; remove unneeded rept 2 2016-05-04 11:46:23 -04:00
pikalaxalt 82f1534925 Copycat labels; macro for the Crystal-only Unown chamber unlock words 2016-04-30 21:20:12 -04:00
pikalaxalt 0bcd725e6a Finish renaming battle anim gfx pointers and files 2016-04-10 17:16:08 -04:00
pikalaxalt 6be4cd4da9 Local labels starting with lowercase letters are no longer decorated with a trailing colon 2016-04-10 15:01:49 -04:00
pikalaxalt bf73772a56 Local labels starting with capital letters are now decorated with a trailing colon; remove trailing whitespace; globally correct line endings to UNIX style 2016-04-10 14:42:14 -04:00
pikalaxalt 93e12d2003 Split up banks 1-3 of main.asm 2016-03-27 12:47:28 -04:00
pikalaxalt f2fa5349d5 More annotations of HP bar animations, including an oversight by GameFreak resulting in super-slow HP bars for Pokemon with over 48 HP 2016-03-08 19:54:06 -05:00
PikalaxALT 599e6e8d16 Battle animation annotations 2016-03-01 22:31:21 -05:00
PikalaxALT b272c0c375 Fix marts using hard-coded bank number 2016-01-27 12:25:12 -05:00
PikalaxALT 8bf255b9f8 Prepare to merge 2016-01-18 00:39:01 -05:00
PikalaxALT 7cc2571529 Finish function labels in battle core 2016-01-13 00:39:41 -05:00