Commit Graph

72 Commits

Author SHA1 Message Date
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
vulcandth 3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
mid-kid 1d97d41ea2 Tile constant makes more sense as negative 2022-04-05 21:22:46 +02:00
vulcandth af7d328d66 Cleanup Magic Numbers 2022-04-05 19:14:39 +00:00
Rangi 20dc31115e Use `VRAM_End` in place of `sScratch` 2022-01-20 20:16:22 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi 4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Rangi 99e66c2557 Rename some labels
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
2020-12-23 16:29:30 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi 9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
mid-kid 3b43f79dc6 Use hex for tile IDs in engine/movie/splash.asm 2020-08-27 18:03:54 +02:00
mid-kid 15c08ad8a3 Small changes to better match pokegold 2020-08-27 14:52:27 +02:00
mid-kid 13c4a93cea Fix some constants surrounding sprite animations
Also commented the use of the field surrounding the struct
initialization functions.

SPRITEANIMSTRUCT_0C -> SPRITEANIMSTRUCT_VAR1
SPRITEANIMSTRUCT_0D -> SPRITEANIMSTRUCT_VAR2
SPRITEANIMSTRUCT_0E -> SPRITEANIMSTRUCT_VAR3
SPRITEANIMSTRUCT_0F -> SPRITEANIMSTRUCT_VAR4

BATTLEANIMSTRUCT_01 -> BATTLEANIMSTRUCT_OAMFLAGS
BATTLEANIMSTRUCT_ANON_JT_INDEX -> BATTLEANIMSTRUCT_JUMPTABLE_INDEX
BATTLEANIMSTRUCT_0F -> BATTLEANIMSTRUCT_VAR1
BATTLEANIMSTRUCT_10 -> BATTLEANIMSTRUCT_VAR2
2020-08-27 13:59:33 +02:00
mid-kid 733664b18f Document splash screen animation 2020-08-27 13:59:33 +02:00
mid-kid 2b2c1ac649 Split engine/movie/intro.asm into itself and splash.asm 2020-08-27 13:59:31 +02:00
mid-kid 926e231849 Move all splash screen files to gfx/splash 2020-08-27 13:58:54 +02:00
mid-kid b6055b1944 Use TRUE for hCGBPalUpdate 2020-08-05 16:02:48 +02:00
mid-kid ac48d65498 Document wTitleScreenSelectedOption variable 2020-08-05 16:02:44 +02:00
mid-kid 58b45443e8 Minor title screen fixes 2020-08-03 23:35:18 +02:00
Rangi de073374a6 Port pokered's more local system for trade animation scripts
Also factor out trade tilemaps
2020-07-17 16:53:22 -04:00
Rangi 6ca82e5c86 Eliminate enum: use const instead, with case-by-case parallel const implementations 2020-07-08 15:30:23 -04:00
Rangi fce6243b43 Identify more labels, and use the jumptable macro when possible 2020-07-01 13:13:49 -04:00
Rangi 022f9e6af1 Reformat gfx/trade/game_boy.png and fix tools/gfx --preserve 2020-06-28 19:56:06 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi cc460a17b0 Harmonize engine/{movie, pokemon} with pokegold (renames GetSRAMBank to OpenSRAM)
To do: engine/{menus, overworld}
2020-06-17 17:03:38 -04:00
Rangi 7b2515d1e4 [in progress] Harmonize more constant and data files with pokegold 2020-06-16 14:32:57 -04:00
Rangi 2354c41a96 crystal_intro.asm -> intro.asm 2020-06-16 11:44:03 -04:00
Rangi fe42ef8a88 Some uses of SCREEN_WIDTH and SCREEN_HEIGHT 2020-05-25 21:05:52 -04:00
Rangi 22615cecc5 More miscellaneous fixes (see #709) 2020-04-17 10:52:59 -04:00
Rangi 0ef004a4db `dsprite y, ypx, x, xpx, off, attr` -> `dbsprite x, y, xpx, ypx, off, attr` 2020-04-04 16:00:30 -04:00
Rangi 6a6ba10315 rgbds supports 'X - 1' instead of 'X + -1' 2020-03-21 14:01:05 -04:00
Rangi f09b68d945 Change how some PNG graphics are formatted 2020-03-01 17:00:57 -05:00
mid-kid 26b8bf003e Standardize on lowercase Tilemap and Attrmap
We used to have a mixture of TileMap and and Tilemap, as well as the
similar AttrMap. Standardize on one.
2020-02-13 18:31:10 +01:00
mid-kid 0d81f1c470 InitSpriteAnimStruct <-> _InitSpriteAnimStruct
These were the wrong way around, as the function in home should not be
prefixed
2020-02-13 18:31:10 +01:00
Rangi 3e7c7d5fff Identify intro tilemaps and attrmaps 2019-11-03 13:38:40 -05:00
mid-kid e3e0bcd653 #641 fixes and additions. (#646)
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
Rangi 1ada06f576
Merge pull request #622 from mid-kid/master
TextBox -> Textbox
2019-04-13 11:50:16 -04:00
mid-kid 3e78e5b2b6 TextBox -> Textbox
Homogenizing names.
2019-04-09 16:09:18 +02:00
Fontbane a3119736fa common_1 text documentation
Should be almost everything besides some of the mobile stuff and some debug text.

Removed VS stuff

oops
2019-03-16 13:00:44 -04:00
Rangi df337fc417 Update to rgbds 0.3.8 2019-02-16 12:17:55 -05:00
mid-kid a21507f22a Document wSuicuneFrame
Also fixed inmediate in PlaceMapNameFrame.FillTopBottom to calculate the
amount of loops required. (It fills two tiles in the first iteration,
and four in the remaining, hence the `-2` and `+1` part).
2019-01-15 13:08:40 +01:00