Commit Graph

1379 Commits

Author SHA1 Message Date
vulcandth 39ba36cb92 Use RS Group offset constants for `slot_reel`
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 10:17:40 +00:00
Idain 01dffba788
Document fish bug properly (#995) 2022-08-31 18:13:10 -05:00
Rangi 4883950318 Use `for` loops to generate box pointer tables
Fixes #996
2022-08-31 18:03:49 -04:00
vulcandth 9801b93906 Add Bug comment for fishing/surfing on NPCs
Also this re-orders `FishFunction:` and `SurfFunction:` in the bug doc, since `SurfFunction:` is encountered in the file first.
2022-08-31 00:43:12 -05:00
Fredrik Ljungdahl 40c899162b Replace numbers with constants in PlayHitSound 2022-08-24 12:17:31 +02:00
Idain bc4fec0694
Fix AI_Smart_Rage comment (#988) 2022-08-21 22:39:08 -05:00
Rangi 7ef31d9889 Move non-Pokémon graphics out of gfx/icons
Fixes #987
2022-08-17 17:45:26 -04:00
The Void 38cd2155df
Bug Doc: Options menu fails to clear joypad state on initialization (#984) 2022-08-11 23:28:35 -05:00
Rangi 0d5cf5c8b9
Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth c3331eb7b1
Rename scene and callback labels (#981)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi 07e8efee7e Fix some whitespace 2022-08-07 00:38:08 -04:00
Rangi 7cac5b787b Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:24:40 -04:00
Rangi 8826d97ee4
Define scene constants alongside scene_scripts (#979)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
Rangi 51bfd31ea8 Use '$' for hex, not '0x' 2022-07-21 19:59:10 -04:00
Rangi 974bb7bf33 Only use "; BUG:" comments for documented bugs 2022-07-17 14:08:56 -04:00
Colton G. Rushton 145d8dd5c2
wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
vulcandth ef9b9bb437
Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
Rangi a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth 1853f70add VC ExchangeBytes Aliases
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:15 +02:00
Rangi a1498e63e2 Rename search.asm and search2.asm 2022-06-17 23:27:53 -04:00
vulcandth 66d84ff021
`MobileCheckOwnMonAnywhere` & `CheckOwnMonAnywhere` Label, comments, formatting (#927)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 23:21:08 -04:00
Colton G. Rushton 84a3b335aa
Document that `farcall` returns `c` in `a` for some code (#937) 2022-06-17 22:30:53 -04:00
vulcandth 5f0597e944
Rename `SLP` to `SLP_MASK` (#918)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:56 -04:00
vulcandth 73c020074e
Remove redundant comments referencing labels (#921) 2022-06-06 17:34:54 -04:00
vulcandth 3648afda16
RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth a4d346cc8c
Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
Konrad Borowski 6e3f2a47bd Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:07 +00:00
Idain dc121712fe
Fix misspelled label (#904) 2022-04-17 11:36:30 -04:00
vulcandth f9077c6db6
Additional vc_asserts (#906) 2022-04-16 20:42:06 -04:00
Idain b06cfe78fd Use NUM_BATTLE_STATS instead of raw numbers 2022-04-06 10:28:18 +00:00
mid-kid 1d97d41ea2 Tile constant makes more sense as negative 2022-04-05 21:22:46 +02:00
vulcandth af7d328d66 Cleanup Magic Numbers 2022-04-05 19:14:39 +00:00
Idain 9b4ebe9400
Replace magic numbers with constants (#894) 2022-03-20 19:58:18 -04:00
Rangi f33a041930 Allow alternate labels for patch names 2022-03-12 22:38:29 -05:00
vulcandth 31c3c94d64
Build the Virtual Console patch with `make crystal11_vc` (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi 3a562f9896 Identify some wMenuJoypad-related button constants 2022-03-09 19:42:26 -05:00
Rangi 2910b9a6c2 Rename `GetPokedexEntryBank` to `HeavyBall_GetDexEntryBank` 2022-02-22 17:11:33 -05:00
Idain d0c8f63f25
Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
mid-kid 418b73bc6d Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:30:57 +01:00
Rangi e56a9f7962 Clear however many bytes are needed for wFruitTreeFlags 2022-02-14 17:28:08 -05:00
Idain e949477089
Document Return/Frustration bug and its fix (#872)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-24 20:48:21 -05:00
Rangi 20dc31115e Use `VRAM_End` in place of `sScratch` 2022-01-20 20:16:22 -05:00
Rangi 0ffdb65210 Better comments for enemy health percentage code 2022-01-10 21:25:43 -05:00
Idain 5ac4a51751
Use time constants more often (#867) 2022-01-10 20:57:40 -05:00
Idain 67207fab94
Identify why five of six enemy mon base stats are copied (#866)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-01-08 13:42:40 -05:00
Rangi 69185e1657 Identify some overworld movement data 2021-12-22 21:38:26 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi 39111486ab Fix #845: Liz gossips about a beautiful trainer, not Pokémon 2021-11-03 17:24:16 -04:00
Rangi 187b120007 Add assertions to some more tables 2021-10-24 18:28:54 -04:00