Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Include bugfix in comments

This commit is contained in:
Remy Oukaour 2017-12-21 12:11:35 -05:00
parent d6dccb7df5
commit ff4d25eee3
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
docs/bugs_and_glitches.md
View File

@ -878,6 +878,8 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](
; making bumps silent. ; making bumps silent.
ld a, [WalkingDirection] ld a, [WalkingDirection]
; cp STANDING
; jr z, .not_warp
ld e, a ld e, a
ld d, 0 ld d, 0
ld hl, .EdgeWarps ld hl, .EdgeWarps
@ -889,6 +891,7 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](
ld a, 1 ld a, 1
ld [wd041], a ld [wd041], a
ld a, [WalkingDirection] ld a, [WalkingDirection]
; This is in the wrong place.
cp STANDING cp STANDING
jr z, .not_warp jr z, .not_warp
``` ```
@ -1221,8 +1224,8 @@ In [engine/overworld.asm](/engine/overworld.asm):
```asm ```asm
LoadSpriteGFX: ; 14306 LoadSpriteGFX: ; 14306
; Bug: b is not preserved, so ; Bug: b is not preserved, so it's useless as a next count.
; it's useless as a next count. ; Uncomment the lines below to fix.
ld hl, UsedSprites ld hl, UsedSprites
ld b, SPRITE_GFX_LIST_CAPACITY ld b, SPRITE_GFX_LIST_CAPACITY
@ -1241,13 +1244,15 @@ LoadSpriteGFX: ; 14306
ret ret
.LoadSprite: .LoadSprite:
; push bc
call GetSprite call GetSprite
; pop bc
ld a, l ld a, l
ret ret
; 1431e ; 1431e
``` ```
**Fix:** Surround `call GetSprite` with `push bc`/`pop bc`. **Fix:** Uncomment `push bc` and `pop bc`.
## `ChooseWildEncounter` doesn't really validate the wild Pokémon species ## `ChooseWildEncounter` doesn't really validate the wild Pokémon species

6
engine/overworld.asm
View File

@ -389,8 +389,8 @@ AddSpriteGFX: ; 142e5
LoadSpriteGFX: ; 14306 LoadSpriteGFX: ; 14306
; Bug: b is not preserved, so ; Bug: b is not preserved, so it's useless as a next count.
; it's useless as a next count. ; Uncomment the lines below to fix.
ld hl, UsedSprites ld hl, UsedSprites
ld b, SPRITE_GFX_LIST_CAPACITY ld b, SPRITE_GFX_LIST_CAPACITY
@ -409,7 +409,9 @@ LoadSpriteGFX: ; 14306
ret ret
.LoadSprite: .LoadSprite:
; push bc
call GetSprite call GetSprite
; pop bc
ld a, l ld a, l
ret ret
; 1431e ; 1431e

3
engine/player_movement.asm
View File

@ -409,6 +409,8 @@ DoPlayerMovement:: ; 80000
; making bumps silent. ; making bumps silent.
ld a, [WalkingDirection] ld a, [WalkingDirection]
; cp STANDING
; jr z, .not_warp
ld e, a ld e, a
ld d, 0 ld d, 0
ld hl, .EdgeWarps ld hl, .EdgeWarps
@ -420,6 +422,7 @@ DoPlayerMovement:: ; 80000
ld a, 1 ld a, 1
ld [wd041], a ld [wd041], a
ld a, [WalkingDirection] ld a, [WalkingDirection]
; This is in the wrong place.
cp STANDING cp STANDING
jr z, .not_warp jr z, .not_warp