mirror of https://github.com/pret/pokecrystal.git
Include bugfix in comments
This commit is contained in:
parent
d6dccb7df5
commit
ff4d25eee3
|
@ -878,6 +878,8 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](
|
|||
; making bumps silent.
|
||||
|
||||
ld a, [WalkingDirection]
|
||||
; cp STANDING
|
||||
; jr z, .not_warp
|
||||
ld e, a
|
||||
ld d, 0
|
||||
ld hl, .EdgeWarps
|
||||
|
@ -889,6 +891,7 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](
|
|||
ld a, 1
|
||||
ld [wd041], a
|
||||
ld a, [WalkingDirection]
|
||||
; This is in the wrong place.
|
||||
cp STANDING
|
||||
jr z, .not_warp
|
||||
```
|
||||
|
@ -1221,8 +1224,8 @@ In [engine/overworld.asm](/engine/overworld.asm):
|
|||
|
||||
```asm
|
||||
LoadSpriteGFX: ; 14306
|
||||
; Bug: b is not preserved, so
|
||||
; it's useless as a next count.
|
||||
; Bug: b is not preserved, so it's useless as a next count.
|
||||
; Uncomment the lines below to fix.
|
||||
|
||||
ld hl, UsedSprites
|
||||
ld b, SPRITE_GFX_LIST_CAPACITY
|
||||
|
@ -1241,13 +1244,15 @@ LoadSpriteGFX: ; 14306
|
|||
ret
|
||||
|
||||
.LoadSprite:
|
||||
; push bc
|
||||
call GetSprite
|
||||
; pop bc
|
||||
ld a, l
|
||||
ret
|
||||
; 1431e
|
||||
```
|
||||
|
||||
**Fix:** Surround `call GetSprite` with `push bc`/`pop bc`.
|
||||
**Fix:** Uncomment `push bc` and `pop bc`.
|
||||
|
||||
|
||||
## `ChooseWildEncounter` doesn't really validate the wild Pokémon species
|
||||
|
|
|
@ -389,8 +389,8 @@ AddSpriteGFX: ; 142e5
|
|||
|
||||
|
||||
LoadSpriteGFX: ; 14306
|
||||
; Bug: b is not preserved, so
|
||||
; it's useless as a next count.
|
||||
; Bug: b is not preserved, so it's useless as a next count.
|
||||
; Uncomment the lines below to fix.
|
||||
|
||||
ld hl, UsedSprites
|
||||
ld b, SPRITE_GFX_LIST_CAPACITY
|
||||
|
@ -409,7 +409,9 @@ LoadSpriteGFX: ; 14306
|
|||
ret
|
||||
|
||||
.LoadSprite:
|
||||
; push bc
|
||||
call GetSprite
|
||||
; pop bc
|
||||
ld a, l
|
||||
ret
|
||||
; 1431e
|
||||
|
|
|
@ -409,6 +409,8 @@ DoPlayerMovement:: ; 80000
|
|||
; making bumps silent.
|
||||
|
||||
ld a, [WalkingDirection]
|
||||
; cp STANDING
|
||||
; jr z, .not_warp
|
||||
ld e, a
|
||||
ld d, 0
|
||||
ld hl, .EdgeWarps
|
||||
|
@ -420,6 +422,7 @@ DoPlayerMovement:: ; 80000
|
|||
ld a, 1
|
||||
ld [wd041], a
|
||||
ld a, [WalkingDirection]
|
||||
; This is in the wrong place.
|
||||
cp STANDING
|
||||
jr z, .not_warp
|
||||
|
||||
|
|
Loading…
Reference in New Issue