From d2880d1981876b06bc867ae17376e31f2d4df60d Mon Sep 17 00:00:00 2001 From: Rangi Date: Wed, 23 May 2018 11:08:23 -0400 Subject: [PATCH] =?UTF-8?q?Factor=20out=20GetHPPals=20and=20SetHPPals=20fr?= =?UTF-8?q?om=20home.asm=20The=20remaining=20code=20in=20home.asm=20is=20a?= =?UTF-8?q?lmost=20all=20"generic",=20unrelated=20to=20Pok=C3=A9mon-specif?= =?UTF-8?q?ic=20game=20logic,=20so=20leaving=20it=20as-is=20might=20be=20n?= =?UTF-8?q?eater=20than=20little=20home/*.asm=20files=20for=20each=20routi?= =?UTF-8?q?ne.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- home.asm | 21 +-------------------- home/hp_pals.asm | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 20 deletions(-) create mode 100644 home/hp_pals.asm diff --git a/home.asm b/home.asm index 1963e2f6a..9aaa50098 100644 --- a/home.asm +++ b/home.asm @@ -227,26 +227,7 @@ CompareLong:: ; 31e4 ; 31f3 INCLUDE "home/tilemap.asm" - -SetHPPal:: ; 334e -; Set palette for hp bar pixel length e at hl. - call GetHPPal - ld [hl], d - ret -; 3353 - -GetHPPal:: ; 3353 -; Get palette for hp bar pixel length e in d. - ld d, HP_GREEN - ld a, e - cp (50 * 48 / 100) - ret nc - inc d ; HP_YELLOW - cp (21 * 48 / 100) - ret nc - inc d ; HP_RED - ret -; 335f +INCLUDE "home/hp_pals.asm" CountSetBits:: ; 0x335f ; Count the number of set bits in b bytes starting from hl. diff --git a/home/hp_pals.asm b/home/hp_pals.asm new file mode 100644 index 000000000..527ec860e --- /dev/null +++ b/home/hp_pals.asm @@ -0,0 +1,19 @@ +SetHPPal:: ; 334e +; Set palette for hp bar pixel length e at hl. + call GetHPPal + ld [hl], d + ret +; 3353 + +GetHPPal:: ; 3353 +; Get palette for hp bar pixel length e in d. + ld d, HP_GREEN + ld a, e + cp (50 * 48 / 100) + ret nc + inc d ; HP_YELLOW + cp (21 * 48 / 100) + ret nc + inc d ; HP_RED + ret +; 335f