Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reword bug docs now that they use diffs

This commit is contained in:
Rangi 2018-07-27 13:11:30 -04:00
parent 54d507cf61
commit b58f82e12f
1 changed files with 492 additions and 607 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

285
docs/bugs_and_glitches.md
View File

@ -71,10 +71,7 @@ Fixes are written in the `diff` format. If you're familiar with git, this should
([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=450)) ([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=450))
This is a bug with `SpeciesItemBoost` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm): **Fix:** Edit `SpeciesItemBoost` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm)
**Fix:**
```diff ```diff
; Double the stat ; Double the stat
@ -101,10 +98,7 @@ This is a bug with `SpeciesItemBoost` in [engine/battle/effect_commands.asm](/en
([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=450)) ([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=450))
This is a bug with `DittoMetalPowder` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm): **Fix:** Edit `DittoMetalPowder` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm):
**Fix:**
```diff ```diff
ld a, c ld a, c
@ -142,10 +136,7 @@ This is a bug with `DittoMetalPowder` in [engine/battle/effect_commands.asm](/en
([Video](https://www.youtube.com/watch?v=zuCLMikWo4Y)) ([Video](https://www.youtube.com/watch?v=zuCLMikWo4Y))
This is a bug with `BattleCommand_BellyDrum` in [engine/battle/move_effects/belly_drum.asm](/engine/battle/move_effects/belly_drum.asm): **Fix:** Edit `BattleCommand_BellyDrum` in [engine/battle/move_effects/belly_drum.asm](/engine/battle/move_effects/belly_drum.asm):
**Fix:**
```diff ```diff
BattleCommand_BellyDrum: BattleCommand_BellyDrum:
@ -153,18 +144,19 @@ BattleCommand_BellyDrum:
-; This command is buggy because it raises the user's attack -; This command is buggy because it raises the user's attack
-; before checking that it has enough HP to use the move. -; before checking that it has enough HP to use the move.
-; Swap the order of these two blocks to fix. -; Swap the order of these two blocks to fix.
+ callfar GetHalfMaxHP - call BattleCommand_AttackUp2
+ callfar CheckUserHasEnoughHP - ld a, [wAttackMissed]
+ jr nc, .failed - and a
+ - jr nz, .failed
call BattleCommand_AttackUp2
ld a, [wAttackMissed]
and a
jr nz, .failed
- -
- callfar GetHalfMaxHP callfar GetHalfMaxHP
- callfar CheckUserHasEnoughHP callfar CheckUserHasEnoughHP
- jr nc, .failed jr nc, .failed
+
+ call BattleCommand_AttackUp2
+ ld a, [wAttackMissed]
+ and a
+ jr nz, .failed
``` ```
@ -185,12 +177,9 @@ BattleCommand_BellyDrum:
This bug affects Acid, Iron Tail, and Rock Smash. This bug affects Acid, Iron Tail, and Rock Smash.
This is a bug with `DefenseDownHit` in [data/moves/effects.asm](/data/moves/effects.asm): **Fix:** Edit `DefenseDownHit` in [data/moves/effects.asm](/data/moves/effects.asm):
```diff
**Fix:**
```asm
DefenseDownHit: DefenseDownHit:
checkobedience checkobedience
usedmovetext usedmovetext
@ -222,10 +211,7 @@ DefenseDownHit:
([Video](https://www.youtube.com/watch?v=uRYyzKRatFk)) ([Video](https://www.youtube.com/watch?v=uRYyzKRatFk))
This is a bug with `BattleCommand_Counter` in [engine/battle/move_effects/counter.asm](/engine/battle/move_effects/counter.asm) and `BattleCommand_MirrorCoat` in [engine/battle/move_effects/mirror_coat.asm](/engine/battle/move_effects/mirror_coat.asm): **Fix:** Edit `BattleCommand_Counter` in [engine/battle/move_effects/counter.asm](/engine/battle/move_effects/counter.asm) and `BattleCommand_MirrorCoat` in [engine/battle/move_effects/mirror_coat.asm](/engine/battle/move_effects/mirror_coat.asm):
**Fix:**
```diff ```diff
- ; BUG: Move should fail with all non-damaging battle actions - ; BUG: Move should fail with all non-damaging battle actions
@ -253,10 +239,7 @@ Add this to the end of each file:
([Video](https://www.youtube.com/watch?v=1v9x4SgMggs)) ([Video](https://www.youtube.com/watch?v=1v9x4SgMggs))
This is a bug with `CheckPlayerHasUsableMoves` in [engine/battle/core.asm](/engine/battle/core.asm): **Fix:** Edit `CheckPlayerHasUsableMoves` in [engine/battle/core.asm](/engine/battle/core.asm):
**Fix:**
```diff ```diff
.done .done
@ -290,10 +273,7 @@ This is a bug with `CheckPlayerHasUsableMoves` in [engine/battle/core.asm](/engi
This bug affects Attract, Curse, Foresight, Mean Look, Mimic, Nightmare, Spider Web, Transform, and stat-lowering effects of moves like String Shot or Bubble during the semi-invulnerable turn of Fly or Dig. This bug affects Attract, Curse, Foresight, Mean Look, Mimic, Nightmare, Spider Web, Transform, and stat-lowering effects of moves like String Shot or Bubble during the semi-invulnerable turn of Fly or Dig.
This is a bug with `CheckHiddenOpponent` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm): **Fix:** Edit `CheckHiddenOpponent` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm):
**Fix:**
```diff ```diff
CheckHiddenOpponent: CheckHiddenOpponent:
@ -304,7 +284,25 @@ CheckHiddenOpponent:
ret ret
``` ```
The code in `CheckHiddenOpponent` is completely redundant as `BattleCommand_CheckHit` already does what this code is doing. Another option is to remove `CheckHiddenOpponent` completely, the calls to `CheckHiddenOpponent`, and the jump afterwards. **Alternate fix:**
To be more efficient, completely remove `CheckHiddenOpponent`:
```diff
-CheckHiddenOpponent:
-; BUG: This routine is completely redundant and introduces a bug, since BattleCommand_CheckHit does these checks properly.
- ld a, BATTLE_VARS_SUBSTATUS3_OPP
- call GetBattleVar
- and 1 << SUBSTATUS_FLYING | 1 << SUBSTATUS_UNDERGROUND
- ret
```
And remove all eight calls to it in various files:
```diff
- call CheckHiddenOpponent
- jr nz, .fail
```
## Beat Up can desynchronize link battles ## Beat Up can desynchronize link battles
@ -313,10 +311,7 @@ The code in `CheckHiddenOpponent` is completely redundant as `BattleCommand_Chec
([Video](https://www.youtube.com/watch?v=202-iAsrIa8)) ([Video](https://www.youtube.com/watch?v=202-iAsrIa8))
This is a bug with `BattleCommand_BeatUp` in [engine/battle/move_effects/beat_up.asm](/engine/battle/move_effects/beat_up.asm): **Fix:** Edit `BattleCommand_BeatUp` in [engine/battle/move_effects/beat_up.asm](/engine/battle/move_effects/beat_up.asm):
**Fix:**
```diff ```diff
.got_mon .got_mon
@ -349,14 +344,10 @@ This is a bug with `BattleCommand_BeatUp` in [engine/battle/move_effects/beat_up
## Beat Up may fail to raise substitute ## Beat Up may fail to raise substitute
*Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.* *Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.*
(Only the fixes denoted with "breaking" will actually break compatibility, the others just affect what's shown on the screen with the patched game)
This is a bug in `BattleCommand_EndLoop` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm) that prevents the rest of the move's effect from being executed if the player or enemy only has one mon in their party while using Beat Up. This bug prevents the rest of the move's effect from being executed if the player or enemy only has one Pokémon in their party while using Beat Up. It prevents Substitute from being raised and King's Rock from working.
It prevents the substitute from being raised and the King's Rock from working. **Fix:** Edit `BattleCommand_EndLoop` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm):
**Fix (breaking):**
```diff ```diff
.only_one_beatup .only_one_beatup
@ -368,7 +359,7 @@ It prevents the substitute from being raised and the King's Rock from working.
+ ret + ret
``` ```
**Fix (cosmetics):** **Cosmetic fix:** This fix does not break compatibility, but it only affects what's shown on the screen for the patched game.
```diff ```diff
.only_one_beatup .only_one_beatup
@ -380,13 +371,9 @@ It prevents the substitute from being raised and the King's Rock from working.
jp EndMoveEffect jp EndMoveEffect
``` ```
For the cosmetic fix, also edit `BattleCommand_FailureText` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm).
There's a similar oversight in `BattleCommand_FailureText` in [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm) that will prevent the substitute from being raised if Beat Up is protected against. ```diff
**Fix (cosmetics):**
```asm
cp EFFECT_MULTI_HIT cp EFFECT_MULTI_HIT
jr z, .multihit jr z, .multihit
cp EFFECT_DOUBLE_HIT cp EFFECT_DOUBLE_HIT
@ -407,12 +394,9 @@ There's a similar oversight in `BattleCommand_FailureText` in [engine/battle/eff
*Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.* *Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.*
This is a bug in how `wAttackMissed` is never set by BeatUp, even when none of the 'mon have been able to attack (due to being fainted or having a status effect), the King's Rock may activate. This bug is caused because Beat Up never sets `wAttackMissed`, even when no Pokémon was able to attack (due to being fainted or having a status condition).
This bug can be fixed in a plethora of ways, but the most straight-forward would be in `BattleCommand_BeatUpFailText` in [engine/battle/move_effects/beat_up.asm](/engine/battle/move_effects/beat_up.asm), as that's always ran before the king's rock effect. **Fix:** Edit `BattleCommand_BeatUpFailText` in [engine/battle/move_effects/beat_up.asm](/engine/battle/move_effects/beat_up.asm):
**Fix:**
```diff ```diff
BattleCommand_BeatUpFailText: BattleCommand_BeatUpFailText:
@ -437,10 +421,7 @@ BattleCommand_BeatUpFailText:
This bug existed for all battles in Gold and Silver, and was only fixed for single-player battles in Crystal to preserve link compatibility. This bug existed for all battles in Gold and Silver, and was only fixed for single-player battles in Crystal to preserve link compatibility.
This is a bug with `BattleCommand_Present` in [engine/battle/move_effects/present.asm](/engine/battle/move_effects/present.asm): **Fix:** Edit `BattleCommand_Present` in [engine/battle/move_effects/present.asm](/engine/battle/move_effects/present.asm):
**Fix:**
```diff ```diff
BattleCommand_Present: BattleCommand_Present:
@ -468,10 +449,7 @@ BattleCommand_Present:
([Video](https://www.youtube.com/watch?v=cygMO-zHTls)) ([Video](https://www.youtube.com/watch?v=cygMO-zHTls))
This is a bug with `AI_Smart_MeanLook` in [engine/battle/ai/scoring.asm](/engine/battle/ai/scoring.asm): **Fix:** Edit `AI_Smart_MeanLook` in [engine/battle/ai/scoring.asm](/engine/battle/ai/scoring.asm):
**Fix:**
```diff ```diff
-; 80% chance to greatly encourage this move if the enemy is badly poisoned (buggy). -; 80% chance to greatly encourage this move if the enemy is badly poisoned (buggy).
@ -486,7 +464,7 @@ This is a bug with `AI_Smart_MeanLook` in [engine/battle/ai/scoring.asm](/engine
## AI makes a false assumption about `CheckTypeMatchup` ## AI makes a false assumption about `CheckTypeMatchup`
In [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm): In [engine/battle/effect_commands.asm](/engine/battle/effect_commands.asm).
```asm ```asm
BattleCheckTypeMatchup: BattleCheckTypeMatchup:
@ -517,10 +495,7 @@ CheckTypeMatchup:
([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=322)) ([Video](https://www.youtube.com/watch?v=rGqu3d3pdok&t=322))
This is a bug with `AI_HealStatus` in [engine/battle/ai/items.asm](/engine/battle/ai/items.asm): **Fix:** Edit `AI_HealStatus` in [engine/battle/ai/items.asm](/engine/battle/ai/items.asm):
**Fix:**
```diff ```diff
AI_HealStatus: AI_HealStatus:
@ -547,10 +522,7 @@ AI_HealStatus:
([Video](https://www.youtube.com/watch?v=SE-BfsFgZVM)) ([Video](https://www.youtube.com/watch?v=SE-BfsFgZVM))
This is a bug with `LongAnim_UpdateVariables` in [engine/battle/anim_hp_bar.asm](/engine/battle/anim_hp_bar.asm): **Fix:** Edit `LongAnim_UpdateVariables` in [engine/battle/anim_hp_bar.asm](/engine/battle/anim_hp_bar.asm):
**Fix:**
```diff ```diff
- ; This routine is buggy. The result from ComputeHPBarPixels is stored - ; This routine is buggy. The result from ComputeHPBarPixels is stored
@ -577,10 +549,7 @@ This is a bug with `LongAnim_UpdateVariables` in [engine/battle/anim_hp_bar.asm]
([Video](https://www.youtube.com/watch?v=9KyNVIZxJvI)) ([Video](https://www.youtube.com/watch?v=9KyNVIZxJvI))
This is a bug with `ShortHPBar_CalcPixelFrame` in [engine/battle/anim_hp_bar.asm](/engine/battle/anim_hp_bar.asm): **Fix:** Edit `ShortHPBar_CalcPixelFrame` in [engine/battle/anim_hp_bar.asm](/engine/battle/anim_hp_bar.asm):
**Fix:**
```diff ```diff
ld b, 0 ld b, 0
@ -608,10 +577,7 @@ This is a bug with `ShortHPBar_CalcPixelFrame` in [engine/battle/anim_hp_bar.asm
This can bring Pokémon straight from level 1 to 100 by gaining just a few experience points. This can bring Pokémon straight from level 1 to 100 by gaining just a few experience points.
This is a bug with `CalcExpAtLevel` in [engine/pokemon/experience.asm](/engine/pokemon/experience.asm): **Fix:** Edit `CalcExpAtLevel` in [engine/pokemon/experience.asm](/engine/pokemon/experience.asm):
**Fix:**
```diff ```diff
CalcExpAtLevel: CalcExpAtLevel:
@ -643,10 +609,7 @@ CalcExpAtLevel:
([Video](https://www.youtube.com/watch?v=o54VjpAEoO8)) ([Video](https://www.youtube.com/watch?v=o54VjpAEoO8))
This is a bug with `Text_ABoostedStringBuffer2ExpPoints` and `Text_StringBuffer2ExpPoints` in [data/text/common_2.asm](/data/text/common_2.asm): **Fix:** Edit `Text_ABoostedStringBuffer2ExpPoints` and `Text_StringBuffer2ExpPoints` in [data/text/common_2.asm](/data/text/common_2.asm):
**Fix:**
```diff ```diff
Text_ABoostedStringBuffer2ExpPoints:: Text_ABoostedStringBuffer2ExpPoints::
@ -670,10 +633,7 @@ Text_StringBuffer2ExpPoints::
## BRN/PSN/PAR do not affect catch rate ## BRN/PSN/PAR do not affect catch rate
This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): **Fix:** Edit `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm):
**Fix:**
```diff ```diff
-; This routine is buggy. It was intended that SLP and FRZ provide a higher -; This routine is buggy. It was intended that SLP and FRZ provide a higher
@ -703,10 +663,7 @@ This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/i
## Moon Ball does not boost catch rate ## Moon Ball does not boost catch rate
This is a bug with `MoonBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm): **Fix:** Edit `MoonBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm):
**Fix:**
```diff ```diff
-; Moon Stone's constant from Pokémon Red is used. -; Moon Stone's constant from Pokémon Red is used.
@ -724,10 +681,7 @@ This is a bug with `MoonBallMultiplier` in [items/item_effects.asm](/items/item_
## Love Ball boosts catch rate for the wrong gender ## Love Ball boosts catch rate for the wrong gender
This is a bug with `LoveBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm): **Fix:** Edit `LoveBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm):
**Fix:**
```diff ```diff
.wildmale .wildmale
@ -743,10 +697,7 @@ This is a bug with `LoveBallMultiplier` in [items/item_effects.asm](/items/item_
## Fast Ball only boosts catch rate for three Pokémon ## Fast Ball only boosts catch rate for three Pokémon
This is a bug with `FastBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm): **Fix:** Edit `FastBallMultiplier` in [items/item_effects.asm](/items/item_effects.asm):
**Fix:**
```diff ```diff
.loop .loop
@ -768,20 +719,13 @@ This is a bug with `FastBallMultiplier` in [items/item_effects.asm](/items/item_
*Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.* *Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.*
This is a bug with `ItemAttributes` in [data/items/attributes.asm](/data/items/attributes.asm): **Fix:** Edit `ItemAttributes` in [data/items/attributes.asm](/data/items/attributes.asm):
**Fix:**
```diff ```diff
; DRAGON_FANG ; DRAGON_FANG
- item_attribute 100, HELD_NONE, 0, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE - item_attribute 100, HELD_NONE, 0, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE
+ item_attribute 100, HELD_DRAGON_BOOST, 0, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE + item_attribute 100, HELD_DRAGON_BOOST, 0, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE
``` ...
And:
```diff
; DRAGON_SCALE ; DRAGON_SCALE
- item_attribute 2100, HELD_DRAGON_BOOST, 10, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE - item_attribute 2100, HELD_DRAGON_BOOST, 10, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE
+ item_attribute 2100, HELD_NONE, 10, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE + item_attribute 2100, HELD_NONE, 10, CANT_SELECT, ITEM, ITEMMENU_NOUSE, ITEMMENU_NOUSE
@ -827,10 +771,7 @@ CopyPokemonName_Buffer1_Buffer3:
jp CopyBytes jp CopyBytes
``` ```
In [data/events/happiness_probabilities.asm](/data/events/happiness_probabilities.asm): **Fix:** Edit [data/events/happiness_probabilities.asm](/data/events/happiness_probabilities.asm):
**Fix:**
```diff ```diff
HappinessData_DaisysGrooming: HappinessData_DaisysGrooming:
@ -842,10 +783,7 @@ HappinessData_DaisysGrooming:
## Magikarp in Lake of Rage are shorter, not longer ## Magikarp in Lake of Rage are shorter, not longer
This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](/engine/battle/core.asm): **Fix:** Edit `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](/engine/battle/core.asm):
**Fix:**
```diff ```diff
.CheckMagikarpArea: .CheckMagikarpArea:
@ -875,10 +813,7 @@ This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](
## Magikarp length limits have a unit conversion error ## Magikarp length limits have a unit conversion error
This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](/engine/battle/core.asm): **Fix:** Edit `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](/engine/battle/core.asm):
**Fix:**
```diff ```diff
; Get Magikarp's length ; Get Magikarp's length
@ -916,10 +851,7 @@ This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [engine/battle/core.asm](
## Magikarp lengths can be miscalculated ## Magikarp lengths can be miscalculated
This is a bug with `CalcMagikarpLength.BCLessThanDE` in [engine/events/magikarp.asm](/engine/events/magikarp.asm): **Fix:** Edit `CalcMagikarpLength.BCLessThanDE` in [engine/events/magikarp.asm](/engine/events/magikarp.asm):
**Fix:**
```diff ```diff
.BCLessThanDE: .BCLessThanDE:
@ -985,10 +917,7 @@ StartTrainerBattle_DetermineWhichAnimation:
([Video](https://www.youtube.com/watch?v=iHkWubvxmSg)) ([Video](https://www.youtube.com/watch?v=iHkWubvxmSg))
This is a bug with `_HallOfFamePC.DisplayMonAndStrings` in [engine/events/halloffame.asm](/engine/events/halloffame.asm): **Fix:** Edit `_HallOfFamePC.DisplayMonAndStrings` in [engine/events/halloffame.asm](/engine/events/halloffame.asm):
**Fix:**
```diff ```diff
ld a, [wHallOfFameTempWinCount] ld a, [wHallOfFameTempWinCount]
@ -1007,10 +936,7 @@ This is a bug with `_HallOfFamePC.DisplayMonAndStrings` in [engine/events/hallof
([Video](https://www.youtube.com/watch?v=ojq3xqfRF6I)) ([Video](https://www.youtube.com/watch?v=ojq3xqfRF6I))
This is a bug with `Slots_PayoutAnim` in [engine/games/slot_machine.asm](/engine/games/slot_machine.asm): **Fix:** Edit `Slots_PayoutAnim` in [engine/games/slot_machine.asm](/engine/games/slot_machine.asm):
**Fix:**
```diff ```diff
.okay .okay
@ -1029,10 +955,7 @@ This is a bug with `Slots_PayoutAnim` in [engine/games/slot_machine.asm](/engine
## Team Rocket battle music is not used for Executives or Scientists ## Team Rocket battle music is not used for Executives or Scientists
This is a bug with `PlayBattleMusic` in [engine/battle/start_battle.asm](/engine/battle/start_battle.asm): **Fix:** Edit `PlayBattleMusic` in [engine/battle/start_battle.asm](/engine/battle/start_battle.asm):
**Fix:**
```diff ```diff
ld de, MUSIC_ROCKET_BATTLE ld de, MUSIC_ROCKET_BATTLE
@ -1051,10 +974,7 @@ This is a bug with `PlayBattleMusic` in [engine/battle/start_battle.asm](/engine
## No bump noise if standing on tile `$3E` ## No bump noise if standing on tile `$3E`
This is a bug with `DoPlayerMovement.CheckWarp` in [engine/overworld/player_movement.asm](/engine/overworld/player_movement.asm): **Fix:** Edit `DoPlayerMovement.CheckWarp` in [engine/overworld/player_movement.asm](/engine/overworld/player_movement.asm):
**Fix:**
```diff ```diff
.CheckWarp: .CheckWarp:
@ -1089,10 +1009,9 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/overworld/player_move
([Video](https://www.youtube.com/watch?v=z305e4sIO24)) ([Video](https://www.youtube.com/watch?v=z305e4sIO24))
The exact cause is unknown, but a workaround exists for `DexEntryScreen_MenuActionJumptable.Cry` in [engine/pokedex/pokedex.asm](/engine/pokedex/pokedex.asm): The exact cause of this bug is unknown.
**Workaround:** Edit `DexEntryScreen_MenuActionJumptable.Cry` in [engine/pokedex/pokedex.asm](/engine/pokedex/pokedex.asm):
**Workaround:**
```diff ```diff
.Cry: .Cry:
@ -1134,10 +1053,7 @@ This is a mistake with the left-hand warp carpet corner tiles in [gfx/tilesets/p
This bug prevents you from using blocksets with more than 128 blocks. This bug prevents you from using blocksets with more than 128 blocks.
In [home/map.asm](/home/map.asm): **Fix:** Edit `LoadMetatiles` in [home/map.asm](/home/map.asm):
**Fix:**
```diff ```diff
; Set hl to the address of the current metatile data ([wTilesetBlocksAddress] + (a) tiles). ; Set hl to the address of the current metatile data ([wTilesetBlocksAddress] + (a) tiles).
@ -1171,10 +1087,7 @@ In [home/map.asm](/home/map.asm):
This bug is why the Lapras in [maps/UnionCaveB2F.asm](/maps/UnionCaveB2F.asm), which uses `SPRITEMOVEDATA_SWIM_WANDER`, is not restricted by its `1, 1` movement radius. This bug is why the Lapras in [maps/UnionCaveB2F.asm](/maps/UnionCaveB2F.asm), which uses `SPRITEMOVEDATA_SWIM_WANDER`, is not restricted by its `1, 1` movement radius.
This is a bug with `CanObjectMoveInDirection` in [engine/overworld/npc_movement.asm](/engine/overworld/npc_movement.asm): **Fix:** Edit `CanObjectMoveInDirection` in [engine/overworld/npc_movement.asm](/engine/overworld/npc_movement.asm):
**Fix:**
```diff ```diff
ld hl, OBJECT_FLAGS1 ld hl, OBJECT_FLAGS1
@ -1191,10 +1104,7 @@ This is a bug with `CanObjectMoveInDirection` in [engine/overworld/npc_movement.
This bug can allow you to talk to Eusine in Celadon City and encounter Ho-Oh with only traded legendary beasts. This bug can allow you to talk to Eusine in Celadon City and encounter Ho-Oh with only traded legendary beasts.
In [engine/pokemon/search.asm](/engine/pokemon/search.asm): **Fix:** Edit `CheckOwnMon` in [engine/pokemon/search.asm](/engine/pokemon/search.asm):
**Fix:**
```diff ```diff
; check OT ; check OT
@ -1224,10 +1134,7 @@ endr
This bug can affect Mew or Pokémon other than Ditto that used Transform via Mirror Move or Sketch. This bug can affect Mew or Pokémon other than Ditto that used Transform via Mirror Move or Sketch.
This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): **Fix:** Edit `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm):
**Fix:**
```diff ```diff
ld hl, wEnemySubStatus5 ld hl, wEnemySubStatus5
@ -1272,10 +1179,7 @@ This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/i
([Video](https://www.youtube.com/watch?v=v1ErZdLCIyU)) ([Video](https://www.youtube.com/watch?v=v1ErZdLCIyU))
This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): **Fix:** Edit `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm):
**Fix:**
```diff ```diff
.room_in_party .room_in_party
@ -1291,10 +1195,7 @@ This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/i
## `HELD_CATCH_CHANCE` has no effect ## `HELD_CATCH_CHANCE` has no effect
This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): **Fix:** Edit `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm):
**Fix:**
```diff ```diff
- ; BUG: farcall overwrites a, and GetItemHeldEffect takes b anyway. - ; BUG: farcall overwrites a, and GetItemHeldEffect takes b anyway.
@ -1320,10 +1221,7 @@ This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/i
## Only the first three evolution entries can have Stone compatibility reported correctly ## Only the first three evolution entries can have Stone compatibility reported correctly
This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm): **Workaround:** Edit `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm):
**Workaround (supports up to six entries):**
```diff ```diff
.DetermineCompatibility: .DetermineCompatibility:
@ -1342,13 +1240,12 @@ This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` i
call FarCopyBytes call FarCopyBytes
``` ```
This supports up to six entries.
## `EVOLVE_STAT` can break Stone compatibility reporting ## `EVOLVE_STAT` can break Stone compatibility reporting
This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm): **Fix:** Edit `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm):
**Fix:**
```asm ```asm
.loop2 .loop2
@ -1408,10 +1305,7 @@ ScriptCall:
## `LoadSpriteGFX` does not limit the capacity of `UsedSprites` ## `LoadSpriteGFX` does not limit the capacity of `UsedSprites`
In [engine/overworld/overworld.asm](/engine/overworld/overworld.asm): **Fix:** Edit `LoadSpriteGFX` in [engine/overworld/overworld.asm](/engine/overworld/overworld.asm):
**Fix:**
```diff ```diff
LoadSpriteGFX: LoadSpriteGFX:
@ -1447,10 +1341,7 @@ LoadSpriteGFX:
## `ChooseWildEncounter` doesn't really validate the wild Pokémon species ## `ChooseWildEncounter` doesn't really validate the wild Pokémon species
In [engine/overworld/wildmons.asm](/engine/overworld/wildmons.asm): **Fix:** Edit `ChooseWildEncounter` in [engine/overworld/wildmons.asm](/engine/overworld/wildmons.asm):
**Fix:**
```diff ```diff
.ok .ok
@ -1469,10 +1360,7 @@ In [engine/overworld/wildmons.asm](/engine/overworld/wildmons.asm):
## `TryObjectEvent` arbitrary code execution ## `TryObjectEvent` arbitrary code execution
In [engine/overworld/events.asm](/engine/overworld/events.asm): **Fix:** Edit `TryObjectEvent` in [engine/overworld/events.asm](/engine/overworld/events.asm):
**Fix:**
```diff ```diff
-; Bug: If IsInArray returns nc, data at bc will be executed as code. -; Bug: If IsInArray returns nc, data at bc will be executed as code.
@ -1499,10 +1387,7 @@ In [engine/overworld/events.asm](/engine/overworld/events.asm):
## `ClearWRAM` only clears WRAM bank 1 ## `ClearWRAM` only clears WRAM bank 1
In [home/init.asm](/home/init.asm): **Fix:** Edit `ClearWRAM` in [home/init.asm](/home/init.asm):
**Fix:**
```diff ```diff
ClearWRAM:: ClearWRAM::