Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid more redundant code and diffs

This commit is contained in:
Rangi 2019-02-17 13:38:30 -05:00
parent fcca48f2a6
commit 47495e7d66
1 changed files with 27 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
docs/design_flaws.md
View File

@ -630,40 +630,36 @@ ENDM
## `GetForestTreeFrame` works, but it's still bad ## `GetForestTreeFrame` works, but it's still bad
In [engine/tilesets/tileset_anims.asm](/engine/tilesets/tileset_anims.asm): The routine `GetForestTreeFrame` in [engine/tilesets/tileset_anims.asm](/engine/tilesets/tileset_anims.asm) is hilariously inefficient.
```asm
GetForestTreeFrame:
; Return 0 if a is even, or 2 if odd.
and a
jr z, .even
cp 1
jr z, .odd
cp 2
jr z, .even
cp 3
jr z, .odd
cp 4
jr z, .even
cp 5
jr z, .odd
cp 6
jr z, .even
.odd
ld a, 2
scf
ret
.even
xor a
ret
```
**Fix:** **Fix:**
Edit `GetForestTreeFrame`:
```asm ```asm
GetForestTreeFrame: GetForestTreeFrame:
; Return 0 if a is even, or 2 if odd. ; Return 0 if a is even, or 2 if odd.
and 1 - and a
add a - jr z, .even
- cp 1
- jr z, .odd
- cp 2
- jr z, .even
- cp 3
- jr z, .odd
- cp 4
- jr z, .even
- cp 5
- jr z, .odd
- cp 6
- jr z, .even
-.odd
- ld a, 2
- scf
- ret
-.even
- xor a
+ and 1
+ add a
ret ret
``` ```