Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document one more bug.

This commit is contained in:
Remy Oukaour 2017-12-12 23:05:30 -05:00
parent 10eb426e40
commit 138abd097d
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
docs/bugs.md → docs/bugs_and_glitches.md
View File

@ -598,7 +598,7 @@ This is a bug with `LoadEnemyMon.CheckMagikarpArea` in [battle/core.asm](battle/
This is a bug with `StartTrainerBattle_DetermineWhichAnimation` in [engine/battle_start.asm](engine/battle_start.asm): This is a bug with `StartTrainerBattle_DetermineWhichAnimation` in [engine/battle_start.asm](engine/battle_start.asm):
``` ```asm
StartTrainerBattle_DetermineWhichAnimation: ; 8c365 (23:4365) StartTrainerBattle_DetermineWhichAnimation: ; 8c365 (23:4365)
; The screen flashes a different number of times depending on the level of ; The screen flashes a different number of times depending on the level of
; your lead Pokemon relative to the opponent's. ; your lead Pokemon relative to the opponent's.
@ -683,6 +683,32 @@ This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](
``` ```
## `LoadMetatiles` wrap around past 128 blocks
[home/map.asm](home/map.asm):
```asm
; Set hl to the address of the current metatile data ([TilesetBlocksAddress] + (a) tiles).
; This is buggy; it wraps around past 128 blocks.
; To fix, uncomment the line below.
add a ; Comment or delete this line to fix the above bug.
ld l, a
ld h, 0
; add hl, hl
add hl, hl
add hl, hl
add hl, hl
ld a, [TilesetBlocksAddress]
add l
ld l, a
ld a, [TilesetBlocksAddress + 1]
adc h
ld h, a
```
**Fix:** Delete `add a` and uncomment `add hl, hl`.
## Surfing directly across a map connection does not load the new map ## Surfing directly across a map connection does not load the new map
([Video](https://www.youtube.com/watch?v=XFOWvMNG-zw)) ([Video](https://www.youtube.com/watch?v=XFOWvMNG-zw))

5
home/map.asm
View File

@ -152,9 +152,12 @@ LoadMetatiles:: ; 2198
ld e, l ld e, l
ld d, h ld d, h
; Set hl to the address of the current metatile data ([TilesetBlocksAddress] + (a) tiles). ; Set hl to the address of the current metatile data ([TilesetBlocksAddress] + (a) tiles).
add a ; This is buggy; it wraps around past 128 blocks.
; To fix, uncomment the line below.
add a ; Comment or delete this line to fix the above bug.
ld l, a ld l, a
ld h, 0 ld h, 0
; add hl, hl
add hl, hl add hl, hl
add hl, hl add hl, hl
add hl, hl add hl, hl