Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Correct Moon Ball bug documentation (#1133)

This commit is contained in:
SnorlaxMonster 2024-10-18 07:30:59 +10:30 committed by GitHub
parent 1febb75bf9
commit 0ebea8cfe1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/bugs_and_glitches.md
View File

@ -1100,10 +1100,16 @@ This can occur if your party and current PC box are both full when you start the
### Moon Ball does not boost catch rate
The Moon Ball checks the wrong memory address for the wrong item ID, so no Pokémon can receive the boost.
**Fix:** Edit `MoonBallMultiplier` in [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/master/engine/items/item_effects.asm):
```diff
-; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
- inc hl
- inc hl
push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte
@ -1113,6 +1119,8 @@ This can occur if your party and current PC box are both full when you start the
ret nz
```
Note that this fix only accounts for Pokémon that evolve via Moon Stone as their first evolution method. However, that is sufficient to cover all Pokémon in the game that can evolve by Moon Stone.
### Love Ball boosts catch rate for the wrong gender

2
engine/items/item_effects.asm
View File

@ -913,11 +913,11 @@ MoonBallMultiplier:
pop bc
ret nz
; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
inc hl
inc hl
inc hl
; BUG: Moon Ball does not boost catch rate (see docs/bugs_and_glitches.md)
push bc
ld a, BANK("Evolutions and Attacks")
call GetFarByte