pokecrystal/engine/overworld/npc_movement.asm

CanObjectMoveInDirection:
	ld hl, OBJECT_PALETTE
	add hl, bc
	bit SWIMMING_F, [hl]
	jr z, .not_swimming

	ld hl, OBJECT_FLAGS1
	add hl, bc
	bit NOCLIP_TILES_F, [hl] ; lost, uncomment next line to fix
	; jr nz, .noclip_tiles
	push hl
	push bc
	call WillObjectBumpIntoLand
	pop bc
	pop hl
	ret c
	jr .continue

.not_swimming
	ld hl, OBJECT_FLAGS1
	add hl, bc
	bit NOCLIP_TILES_F, [hl]
	jr nz, .noclip_tiles
	push hl
	push bc
	call WillObjectBumpIntoWater
	pop bc
	pop hl
	ret c

.noclip_tiles
.continue
	bit NOCLIP_OBJS_F, [hl]
	jr nz, .noclip_objs

	push hl
	push bc
	call WillObjectBumpIntoSomeoneElse
	pop bc
	pop hl
	ret c

.noclip_objs
	bit MOVE_ANYWHERE_F, [hl]
	jr nz, .move_anywhere
	push hl
	call HasObjectReachedMovementLimit
	pop hl
	ret c

	push hl
	call IsObjectMovingOffEdgeOfScreen
	pop hl
	ret c

.move_anywhere
	and a
	ret

WillObjectBumpIntoWater:
	call Function6f5f
	ret c
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld d, [hl]
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld e, [hl]
	ld hl, OBJECT_PALETTE
	add hl, bc
	bit OAM_PRIORITY, [hl]
	jp nz, Function6fa1
	ld hl, OBJECT_NEXT_TILE
	add hl, bc
	ld a, [hl]
	ld d, a
	call GetTileCollision
	and a ; LAND_TILE
	jr z, WillObjectBumpIntoTile
	scf
	ret

WillObjectBumpIntoLand:
	call Function6f5f
	ret c
	ld hl, OBJECT_NEXT_TILE
	add hl, bc
	ld a, [hl]
	call GetTileCollision
	cp WATER_TILE
	jr z, WillObjectBumpIntoTile
	scf
	ret

WillObjectBumpIntoTile:
	ld hl, OBJECT_NEXT_TILE
	add hl, bc
	ld a, [hl]
	call Function6f7f
	ret nc
	push af
	ld hl, OBJECT_DIRECTION_WALKING
	add hl, bc
	ld a, [hl]
	maskbits NUM_DIRECTIONS
	ld e, a
	ld d, 0
	ld hl, .data_6f5b
	add hl, de
	pop af
	and [hl]
	ret z
	scf
	ret

.data_6f5b
	db DOWN_MASK  ; DOWN
	db UP_MASK    ; UP
	db RIGHT_MASK ; LEFT
	db LEFT_MASK  ; RIGHT

Function6f5f:
	ld hl, OBJECT_STANDING_TILE
	add hl, bc
	ld a, [hl]
	call Function6f7f
	ret nc
	push af
	ld hl, OBJECT_DIRECTION_WALKING
	add hl, bc
	maskbits NUM_DIRECTIONS
	ld e, a
	ld d, 0
	ld hl, .data_6f7b
	add hl, de
	pop af
	and [hl]
	ret z
	scf
	ret

.data_6f7b
	db UP_MASK    ; DOWN
	db DOWN_MASK  ; UP
	db LEFT_MASK  ; LEFT
	db RIGHT_MASK ; RIGHT

Function6f7f:
	ld d, a
	and $f0
	cp HI_NYBBLE_SIDE_WALLS
	jr z, .continue
	cp HI_NYBBLE_SIDE_BUOYS
	jr z, .continue
	xor a
	ret

.continue
	ld a, d
	and 7
	ld e, a
	ld d, 0
	ld hl, .data_6f99
	add hl, de
	ld a, [hl]
	scf
	ret

.data_6f99
	db RIGHT_MASK             ; COLL_RIGHT_WALL/BUOY
	db LEFT_MASK              ; COLL_LEFT_WALL/BUOY
	db DOWN_MASK              ; COLL_UP_WALL/BUOY
	db UP_MASK                ; COLL_DOWN_WALL/BUOY
	db UP_MASK | RIGHT_MASK   ; COLL_DOWN_RIGHT_WALL/BUOY
	db UP_MASK | LEFT_MASK    ; COLL_DOWN_LEFT_WALL/BUOY
	db DOWN_MASK | RIGHT_MASK ; COLL_UP_RIGHT_WALL/BUOY
	db DOWN_MASK | LEFT_MASK  ; COLL_UP_LEFT_WALL/BUOY

Function6fa1:
	ld hl, OBJECT_DIRECTION_WALKING
	add hl, bc
	ld a, [hl]
	maskbits NUM_DIRECTIONS
	jr z, .down
	dec a
	jr z, .up
	dec a
	jr z, .left
	jr .right

.down
	inc e
	push de
	inc d
	jr .continue

.up
	push de
	inc d
	jr .continue

.left
	push de
	inc e
	jr .continue

.right
	inc d
	push de
	inc e

.continue
	call GetCoordTile
	call GetTileCollision
	pop de
	and a ; LAND_TILE
	jr nz, .not_land
	call GetCoordTile
	call GetTileCollision
	and a ; LAND_TILE
	jr nz, .not_land
	xor a
	ret

.not_land
	scf
	ret

CheckFacingObject::
	call GetFacingTileCoord

; Double the distance for counter tiles.
	call CheckCounterTile
	jr nz, .asm_6ff1

	ld a, [wPlayerStandingMapX]
	sub d
	cpl
	inc a
	add d
	ld d, a

	ld a, [wPlayerStandingMapY]
	sub e
	cpl
	inc a
	add e
	ld e, a

.asm_6ff1
	ld bc, wObjectStructs ; redundant
	ld a, 0
	ldh [hMapObjectIndexBuffer], a
	call IsNPCAtCoord
	ret nc
	ld hl, OBJECT_DIRECTION_WALKING
	add hl, bc
	ld a, [hl]
	cp STANDING
	jr z, .standing
	xor a
	ret

.standing
	scf
	ret

WillObjectBumpIntoSomeoneElse:
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld d, [hl]
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld e, [hl]
	jr IsNPCAtCoord

Unreferenced_Function7015:
	ldh a, [hMapObjectIndexBuffer]
	call GetObjectStruct
	call .CheckWillBeFacingNPC
	call IsNPCAtCoord
	ret

.CheckWillBeFacingNPC:
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld d, [hl]
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld e, [hl]
	call GetSpriteDirection
	and a
	jr z, .down
	cp OW_UP
	jr z, .up
	cp OW_LEFT
	jr z, .left
	inc d
	ret

.down
	inc e
	ret

.up
	dec e
	ret

.left
	dec d
	ret

IsNPCAtCoord:
	ld bc, wObjectStructs
	xor a
.loop
	ldh [hObjectStructIndexBuffer], a
	call DoesObjectHaveASprite
	jr z, .next

	ld hl, OBJECT_FLAGS1
	add hl, bc
	bit 7, [hl]
	jr nz, .next

	ld hl, OBJECT_PALETTE
	add hl, bc
	bit BIG_OBJECT_F, [hl]
	jr z, .got

	call Function7171
	jr nc, .ok
	jr .ok2

.got
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld a, [hl]
	cp d
	jr nz, .ok
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld a, [hl]
	cp e
	jr nz, .ok

.ok2
	ldh a, [hMapObjectIndexBuffer]
	ld l, a
	ldh a, [hObjectStructIndexBuffer]
	cp l
	jr nz, .setcarry

.ok
	ld hl, OBJECT_MAP_X
	add hl, bc
	ld a, [hl]
	cp d
	jr nz, .next
	ld hl, OBJECT_MAP_Y
	add hl, bc
	ld a, [hl]
	cp e
	jr nz, .next
	ldh a, [hMapObjectIndexBuffer]
	ld l, a
	ldh a, [hObjectStructIndexBuffer]
	cp l
	jr nz, .setcarry

.next
	ld hl, OBJECT_LENGTH
	add hl, bc
	ld b, h
	ld c, l
	ldh a, [hObjectStructIndexBuffer]
	inc a
	cp NUM_OBJECT_STRUCTS
	jr nz, .loop
	and a
	ret

.setcarry
	scf
	ret

HasObjectReachedMovementLimit:
	ld hl, OBJECT_RADIUS
	add hl, bc
	ld a, [hl]
	and a
	jr z, .nope
	and $f
	jr z, .check_y
	ld e, a
	ld d, a
	ld hl, OBJECT_INIT_X
	add hl, bc
	ld a, [hl]
	sub d
	ld d, a
	ld a, [hl]
	add e
	ld e, a
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld a, [hl]
	cp d
	jr z, .yes
	cp e
	jr z, .yes

.check_y
	ld hl, OBJECT_RADIUS
	add hl, bc
	ld a, [hl]
	swap a
	and $f
	jr z, .nope
	ld e, a
	ld d, a
	ld hl, OBJECT_INIT_Y
	add hl, bc
	ld a, [hl]
	sub d
	ld d, a
	ld a, [hl]
	add e
	ld e, a
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld a, [hl]
	cp d
	jr z, .yes
	cp e
	jr z, .yes

.nope
	xor a
	ret

.yes
	scf
	ret

IsObjectMovingOffEdgeOfScreen:
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld a, [wXCoord]
	cp [hl]
	jr z, .check_y
	jr nc, .yes
	add $9
	cp [hl]
	jr c, .yes

.check_y
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld a, [wYCoord]
	cp [hl]
	jr z, .nope
	jr nc, .yes
	add $8
	cp [hl]
	jr c, .yes

.nope
	and a
	ret

.yes
	scf
	ret

Unreferenced_Function7113:
	ld a, [wPlayerStandingMapX]
	ld d, a
	ld a, [wPlayerStandingMapY]
	ld e, a
	ld bc, wObjectStructs
	xor a
.loop
	ldh [hObjectStructIndexBuffer], a
	call DoesObjectHaveASprite
	jr z, .next
	ld hl, OBJECT_MOVEMENTTYPE
	add hl, bc
	ld a, [hl]
	cp SPRITEMOVEDATA_BIGDOLLSYM
	jr nz, .not_snorlax
	call Function7171
	jr c, .yes
	jr .next

.not_snorlax
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld a, [hl]
	cp e
	jr nz, .check_current_coords
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld a, [hl]
	cp d
	jr nz, .check_current_coords
	ldh a, [hObjectStructIndexBuffer]
	cp PLAYER_OBJECT
	jr z, .next
	jr .yes

.check_current_coords
	ld hl, OBJECT_MAP_Y
	add hl, bc
	ld a, [hl]
	cp e
	jr nz, .next
	ld hl, OBJECT_MAP_X
	add hl, bc
	ld a, [hl]
	cp d
	jr nz, .next
	jr .yes

.next
	ld hl, OBJECT_LENGTH
	add hl, bc
	ld b, h
	ld c, l
	ldh a, [hObjectStructIndexBuffer]
	inc a
	cp NUM_OBJECT_STRUCTS
	jr nz, .loop
	xor a
	ret

.yes
	scf
	ret

Function7171:
	ld hl, OBJECT_NEXT_MAP_X
	add hl, bc
	ld a, d
	sub [hl]
	jr c, .nope
	cp $2
	jr nc, .nope
	ld hl, OBJECT_NEXT_MAP_Y
	add hl, bc
	ld a, e
	sub [hl]
	jr c, .nope
	cp $2
	jr nc, .nope
	scf
	ret

.nope
	and a
	ret
Remove all address comments 2018-06-24 14:09:41 +00:00			`CanObjectMoveInDirection:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_PALETTE`
			`add hl, bc`
WALKS_ON_WATER → SWIMMING 2018-05-23 23:10:15 +00:00			`bit SWIMMING_F, [hl]`
			`jr z, .not_swimming`
opentext and breeding 2015-12-09 23:25:44 +00:00
			`ld hl, OBJECT_FLAGS1`
			`add hl, bc`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`bit NOCLIP_TILES_F, [hl] ; lost, uncomment next line to fix`
			`; jr nz, .noclip_tiles`
opentext and breeding 2015-12-09 23:25:44 +00:00			`push hl`
			`push bc`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`call WillObjectBumpIntoLand`
opentext and breeding 2015-12-09 23:25:44 +00:00			`pop bc`
			`pop hl`
			`ret c`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`jr .continue`
opentext and breeding 2015-12-09 23:25:44 +00:00
WALKS_ON_WATER → SWIMMING 2018-05-23 23:10:15 +00:00			`.not_swimming`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_FLAGS1`
			`add hl, bc`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`bit NOCLIP_TILES_F, [hl]`
			`jr nz, .noclip_tiles`
opentext and breeding 2015-12-09 23:25:44 +00:00			`push hl`
			`push bc`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`call WillObjectBumpIntoWater`
opentext and breeding 2015-12-09 23:25:44 +00:00			`pop bc`
			`pop hl`
			`ret c`

Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`.noclip_tiles`
			`.continue`
			`bit NOCLIP_OBJS_F, [hl]`
			`jr nz, .noclip_objs`
opentext and breeding 2015-12-09 23:25:44 +00:00
			`push hl`
			`push bc`
Renaming: (fix #412) - MapTriggers / maptrigger → SceneScripts / scene_script - XYTriggers / xy_trigger → CoordEvents / coord_event - Signposts / signpost → BGEvents / bg_event - PersonEvents / person_event → ObjectEvents / object_event 2017-12-24 18:46:34 +00:00			`call WillObjectBumpIntoSomeoneElse`
opentext and breeding 2015-12-09 23:25:44 +00:00			`pop bc`
			`pop hl`
			`ret c`

Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`.noclip_objs`
			`bit MOVE_ANYWHERE_F, [hl]`
			`jr nz, .move_anywhere`
opentext and breeding 2015-12-09 23:25:44 +00:00			`push hl`
Renaming: (fix #412) - MapTriggers / maptrigger → SceneScripts / scene_script - XYTriggers / xy_trigger → CoordEvents / coord_event - Signposts / signpost → BGEvents / bg_event - PersonEvents / person_event → ObjectEvents / object_event 2017-12-24 18:46:34 +00:00			`call HasObjectReachedMovementLimit`
opentext and breeding 2015-12-09 23:25:44 +00:00			`pop hl`
			`ret c`

			`push hl`
Renaming: (fix #412) - MapTriggers / maptrigger → SceneScripts / scene_script - XYTriggers / xy_trigger → CoordEvents / coord_event - Signposts / signpost → BGEvents / bg_event - PersonEvents / person_event → ObjectEvents / object_event 2017-12-24 18:46:34 +00:00			`call IsObjectMovingOffEdgeOfScreen`
opentext and breeding 2015-12-09 23:25:44 +00:00			`pop hl`
			`ret c`

Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`.move_anywhere`
opentext and breeding 2015-12-09 23:25:44 +00:00			`and a`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`WillObjectBumpIntoWater:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call Function6f5f`
			`ret c`
			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld d, [hl]`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld e, [hl]`
			`ld hl, OBJECT_PALETTE`
			`add hl, bc`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`bit OAM_PRIORITY, [hl]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jp nz, Function6fa1`
			`ld hl, OBJECT_NEXT_TILE`
			`add hl, bc`
			`ld a, [hl]`
			`ld d, a`
			`call GetTileCollision`
Define TileCollisionTable as a standard 'db' series 2020-02-14 00:01:47 +00:00			`and a ; LAND_TILE`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`jr z, WillObjectBumpIntoTile`
opentext and breeding 2015-12-09 23:25:44 +00:00			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`WillObjectBumpIntoLand:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call Function6f5f`
			`ret c`
			`ld hl, OBJECT_NEXT_TILE`
			`add hl, bc`
			`ld a, [hl]`
			`call GetTileCollision`
Define TileCollisionTable as a standard 'db' series 2020-02-14 00:01:47 +00:00			`cp WATER_TILE`
Identify more sprite move data flag bits 2018-05-24 02:01:21 +00:00			`jr z, WillObjectBumpIntoTile`
opentext and breeding 2015-12-09 23:25:44 +00:00			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`WillObjectBumpIntoTile:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_NEXT_TILE`
			`add hl, bc`
			`ld a, [hl]`
			`call Function6f7f`
			`ret nc`
			`push af`
			`ld hl, OBJECT_DIRECTION_WALKING`
			`add hl, bc`
			`ld a, [hl]`
Avoid "+- 1" at every maskbits 2018-01-16 22:27:50 +00:00			`maskbits NUM_DIRECTIONS`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld e, a`
			`ld d, 0`
			`ld hl, .data_6f5b`
			`add hl, de`
			`pop af`
			`and [hl]`
			`ret z`
			`scf`
			`ret`

			`.data_6f5b`
Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`db DOWN_MASK ; DOWN`
			`db UP_MASK ; UP`
			`db RIGHT_MASK ; LEFT`
			`db LEFT_MASK ; RIGHT`
opentext and breeding 2015-12-09 23:25:44 +00:00
Remove all address comments 2018-06-24 14:09:41 +00:00			`Function6f5f:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_STANDING_TILE`
			`add hl, bc`
			`ld a, [hl]`
			`call Function6f7f`
			`ret nc`
			`push af`
			`ld hl, OBJECT_DIRECTION_WALKING`
			`add hl, bc`
Avoid "+- 1" at every maskbits 2018-01-16 22:27:50 +00:00			`maskbits NUM_DIRECTIONS`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld e, a`
			`ld d, 0`
			`ld hl, .data_6f7b`
			`add hl, de`
			`pop af`
			`and [hl]`
			`ret z`
			`scf`
			`ret`

			`.data_6f7b`
Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`db UP_MASK ; DOWN`
			`db DOWN_MASK ; UP`
			`db LEFT_MASK ; LEFT`
			`db RIGHT_MASK ; RIGHT`
opentext and breeding 2015-12-09 23:25:44 +00:00
Remove all address comments 2018-06-24 14:09:41 +00:00			`Function6f7f:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld d, a`
			`and $f0`
Add more collision nybble constants 2018-06-29 02:35:29 +00:00			`cp HI_NYBBLE_SIDE_WALLS`
Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`jr z, .continue`
			`cp HI_NYBBLE_SIDE_BUOYS`
			`jr z, .continue`
opentext and breeding 2015-12-09 23:25:44 +00:00			`xor a`
			`ret`

Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`.continue`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld a, d`
			`and 7`
			`ld e, a`
			`ld d, 0`
			`ld hl, .data_6f99`
			`add hl, de`
			`ld a, [hl]`
			`scf`
			`ret`

			`.data_6f99`
Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`db RIGHT_MASK ; COLL_RIGHT_WALL/BUOY`
			`db LEFT_MASK ; COLL_LEFT_WALL/BUOY`
			`db DOWN_MASK ; COLL_UP_WALL/BUOY`
			`db UP_MASK ; COLL_DOWN_WALL/BUOY`
			`db UP_MASK \| RIGHT_MASK ; COLL_DOWN_RIGHT_WALL/BUOY`
			`db UP_MASK \| LEFT_MASK ; COLL_DOWN_LEFT_WALL/BUOY`
			`db DOWN_MASK \| RIGHT_MASK ; COLL_UP_RIGHT_WALL/BUOY`
			`db DOWN_MASK \| LEFT_MASK ; COLL_UP_LEFT_WALL/BUOY`
opentext and breeding 2015-12-09 23:25:44 +00:00
Remove all address comments 2018-06-24 14:09:41 +00:00			`Function6fa1:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_DIRECTION_WALKING`
			`add hl, bc`
			`ld a, [hl]`
Avoid "+- 1" at every maskbits 2018-01-16 22:27:50 +00:00			`maskbits NUM_DIRECTIONS`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr z, .down`
opentext and breeding 2015-12-09 23:25:44 +00:00			`dec a`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr z, .up`
opentext and breeding 2015-12-09 23:25:44 +00:00			`dec a`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr z, .left`
			`jr .right`
opentext and breeding 2015-12-09 23:25:44 +00:00
Use maskbits some more 2018-01-11 17:00:01 +00:00			`.down`
opentext and breeding 2015-12-09 23:25:44 +00:00			`inc e`
			`push de`
			`inc d`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr .continue`
opentext and breeding 2015-12-09 23:25:44 +00:00
Use maskbits some more 2018-01-11 17:00:01 +00:00			`.up`
opentext and breeding 2015-12-09 23:25:44 +00:00			`push de`
			`inc d`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr .continue`
opentext and breeding 2015-12-09 23:25:44 +00:00
Use maskbits some more 2018-01-11 17:00:01 +00:00			`.left`
opentext and breeding 2015-12-09 23:25:44 +00:00			`push de`
			`inc e`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr .continue`
opentext and breeding 2015-12-09 23:25:44 +00:00
Use maskbits some more 2018-01-11 17:00:01 +00:00			`.right`
opentext and breeding 2015-12-09 23:25:44 +00:00			`inc d`
			`push de`
			`inc e`

Use maskbits some more 2018-01-11 17:00:01 +00:00			`.continue`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call GetCoordTile`
			`call GetTileCollision`
			`pop de`
Define TileCollisionTable as a standard 'db' series 2020-02-14 00:01:47 +00:00			`and a ; LAND_TILE`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr nz, .not_land`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call GetCoordTile`
			`call GetTileCollision`
Define TileCollisionTable as a standard 'db' series 2020-02-14 00:01:47 +00:00			`and a ; LAND_TILE`
Use maskbits some more 2018-01-11 17:00:01 +00:00			`jr nz, .not_land`
opentext and breeding 2015-12-09 23:25:44 +00:00			`xor a`
			`ret`

Use maskbits some more 2018-01-11 17:00:01 +00:00			`.not_land`
opentext and breeding 2015-12-09 23:25:44 +00:00			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`CheckFacingObject::`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call GetFacingTileCoord`

			`; Double the distance for counter tiles.`
			`call CheckCounterTile`
			`jr nz, .asm_6ff1`

Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wPlayerStandingMapX]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`sub d`
			`cpl`
			`inc a`
			`add d`
			`ld d, a`

Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wPlayerStandingMapY]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`sub e`
			`cpl`
			`inc a`
			`add e`
			`ld e, a`

			`.asm_6ff1`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld bc, wObjectStructs ; redundant`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld a, 0`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh [hMapObjectIndexBuffer], a`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call IsNPCAtCoord`
			`ret nc`
			`ld hl, OBJECT_DIRECTION_WALKING`
			`add hl, bc`
			`ld a, [hl]`
			`cp STANDING`
			`jr z, .standing`
			`xor a`
			`ret`

			`.standing`
			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`WillObjectBumpIntoSomeoneElse:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld d, [hl]`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld e, [hl]`
			`jr IsNPCAtCoord`

More unreferenced labels cleanup 2018-01-02 15:04:21 +00:00			`Unreferenced_Function7015:`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hMapObjectIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`call GetObjectStruct`
			`call .CheckWillBeFacingNPC`
			`call IsNPCAtCoord`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`.CheckWillBeFacingNPC:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld d, [hl]`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld e, [hl]`
			`call GetSpriteDirection`
			`and a`
			`jr z, .down`
			`cp OW_UP`
			`jr z, .up`
			`cp OW_LEFT`
			`jr z, .left`
			`inc d`
			`ret`

			`.down`
			`inc e`
			`ret`

			`.up`
			`dec e`
			`ret`

			`.left`
			`dec d`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`IsNPCAtCoord:`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld bc, wObjectStructs`
opentext and breeding 2015-12-09 23:25:44 +00:00			`xor a`
			`.loop`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh [hObjectStructIndexBuffer], a`
HDMA transfer functions 2016-05-05 02:34:09 +00:00			`call DoesObjectHaveASprite`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jr z, .next`

			`ld hl, OBJECT_FLAGS1`
			`add hl, bc`
			`bit 7, [hl]`
			`jr nz, .next`

			`ld hl, OBJECT_PALETTE`
			`add hl, bc`
More sprite movement data flag constants 2018-05-23 23:06:04 +00:00			`bit BIG_OBJECT_F, [hl]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jr z, .got`

			`call Function7171`
			`jr nc, .ok`
			`jr .ok2`

			`.got`
			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr nz, .ok`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld a, [hl]`
			`cp e`
			`jr nz, .ok`

			`.ok2`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hMapObjectIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld l, a`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hObjectStructIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`cp l`
			`jr nz, .setcarry`

			`.ok`
			`ld hl, OBJECT_MAP_X`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr nz, .next`
			`ld hl, OBJECT_MAP_Y`
			`add hl, bc`
			`ld a, [hl]`
			`cp e`
			`jr nz, .next`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hMapObjectIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld l, a`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hObjectStructIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`cp l`
			`jr nz, .setcarry`

			`.next`
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH 2019-11-03 17:25:59 +00:00			`ld hl, OBJECT_LENGTH`
opentext and breeding 2015-12-09 23:25:44 +00:00			`add hl, bc`
			`ld b, h`
			`ld c, l`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hObjectStructIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`inc a`
			`cp NUM_OBJECT_STRUCTS`
			`jr nz, .loop`
			`and a`
			`ret`

			`.setcarry`
			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`HasObjectReachedMovementLimit:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_RADIUS`
			`add hl, bc`
			`ld a, [hl]`
			`and a`
			`jr z, .nope`
			`and $f`
			`jr z, .check_y`
			`ld e, a`
			`ld d, a`
			`ld hl, OBJECT_INIT_X`
			`add hl, bc`
			`ld a, [hl]`
			`sub d`
			`ld d, a`
			`ld a, [hl]`
			`add e`
			`ld e, a`
			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr z, .yes`
			`cp e`
			`jr z, .yes`

			`.check_y`
			`ld hl, OBJECT_RADIUS`
			`add hl, bc`
			`ld a, [hl]`
			`swap a`
			`and $f`
			`jr z, .nope`
			`ld e, a`
			`ld d, a`
			`ld hl, OBJECT_INIT_Y`
			`add hl, bc`
			`ld a, [hl]`
			`sub d`
			`ld d, a`
			`ld a, [hl]`
			`add e`
			`ld e, a`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr z, .yes`
			`cp e`
			`jr z, .yes`

			`.nope`
			`xor a`
			`ret`

			`.yes`
			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`IsObjectMovingOffEdgeOfScreen:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wXCoord]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`cp [hl]`
			`jr z, .check_y`
			`jr nc, .yes`
			`add $9`
			`cp [hl]`
			`jr c, .yes`

			`.check_y`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wYCoord]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`cp [hl]`
			`jr z, .nope`
			`jr nc, .yes`
			`add $8`
			`cp [hl]`
			`jr c, .yes`

			`.nope`
			`and a`
			`ret`

			`.yes`
			`scf`
			`ret`

More unreferenced labels cleanup 2018-01-02 15:04:21 +00:00			`Unreferenced_Function7113:`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wPlayerStandingMapX]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld d, a`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld a, [wPlayerStandingMapY]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld e, a`
Prefix wram labels with w, part 2. 2018-01-23 22:39:09 +00:00			`ld bc, wObjectStructs`
opentext and breeding 2015-12-09 23:25:44 +00:00			`xor a`
			`.loop`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh [hObjectStructIndexBuffer], a`
HDMA transfer functions 2016-05-05 02:34:09 +00:00			`call DoesObjectHaveASprite`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jr z, .next`
			`ld hl, OBJECT_MOVEMENTTYPE`
			`add hl, bc`
			`ld a, [hl]`
Clarify big doll-related constants (Snorlax and Lapras are symmetrical, Onix is not) 2018-01-31 03:34:05 +00:00			`cp SPRITEMOVEDATA_BIGDOLLSYM`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jr nz, .not_snorlax`
			`call Function7171`
			`jr c, .yes`
			`jr .next`

			`.not_snorlax`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld a, [hl]`
			`cp e`
			`jr nz, .check_current_coords`
			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr nz, .check_current_coords`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hObjectStructIndexBuffer]`
Identify more collision-related constants and data 2019-03-03 18:30:27 +00:00			`cp PLAYER_OBJECT`
opentext and breeding 2015-12-09 23:25:44 +00:00			`jr z, .next`
			`jr .yes`

			`.check_current_coords`
			`ld hl, OBJECT_MAP_Y`
			`add hl, bc`
			`ld a, [hl]`
			`cp e`
			`jr nz, .next`
			`ld hl, OBJECT_MAP_X`
			`add hl, bc`
			`ld a, [hl]`
			`cp d`
			`jr nz, .next`
			`jr .yes`

			`.next`
Rename OBJECT_LENGTH to MAPOBJECT_LENGTH and OBJECT_STRUCT_LENGTH to OBJECT_LENGTH 2019-11-03 17:25:59 +00:00			`ld hl, OBJECT_LENGTH`
opentext and breeding 2015-12-09 23:25:44 +00:00			`add hl, bc`
			`ld b, h`
			`ld c, l`
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld 2018-08-25 18:28:22 +00:00			`ldh a, [hObjectStructIndexBuffer]`
opentext and breeding 2015-12-09 23:25:44 +00:00			`inc a`
			`cp NUM_OBJECT_STRUCTS`
			`jr nz, .loop`
			`xor a`
			`ret`

			`.yes`
			`scf`
			`ret`

Remove all address comments 2018-06-24 14:09:41 +00:00			`Function7171:`
opentext and breeding 2015-12-09 23:25:44 +00:00			`ld hl, OBJECT_NEXT_MAP_X`
			`add hl, bc`
			`ld a, d`
			`sub [hl]`
			`jr c, .nope`
			`cp $2`
			`jr nc, .nope`
			`ld hl, OBJECT_NEXT_MAP_Y`
			`add hl, bc`
			`ld a, e`
			`sub [hl]`
			`jr c, .nope`
			`cp $2`
			`jr nc, .nope`
			`scf`
			`ret`

			`.nope`
			`and a`
			`ret`