Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pokecrystal/engine/events/mom_phone.asm

265 lines
4.1 KiB
NASM
Raw Normal View History

Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded) Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9. Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
2017-12-23 05:31:04 +00:00
NUM_MOM_ITEMS_1 EQUS "((MomItems_1End - MomItems_1) / 8)"
NUM_MOM_ITEMS_2 EQUS "((MomItems_2End - MomItems_2) / 8)"
Document constants with comments, actual names, and more thorough usage
2017-12-09 05:50:59 +00:00
const_value = 1
const MOM_ITEM
const MOM_DOLL
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
MomTriesToBuySomething:: ; fcfec
ld a, [wMapReentryScriptQueueFlag]
and a
ret nz
map_header → map_def; map_header_2 → map_data
2018-01-17 03:57:19 +00:00
call GetMapPhoneService
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
and a
ret nz
xor a
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld [wWhichMomItemSet], a
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
call CheckBalance_MomItem2
ret nc
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
call Mom_GiveItemOrDoll
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret nc
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld b, BANK(.Script)
ld de, .Script
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall LoadScriptBDE
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
scf
ret
; fd00f
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
.Script: ; 0xfd00f
callasm .ASMFunction
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
farjump Script_ReceivePhoneCall
; 0xfd017
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
.ASMFunction: ; fd017
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
call MomBuysItem_DeductFunds
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
call Mom_GetScriptPointer
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld a, [wWhichMomItemSet]
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
and a
jr nz, .ok
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld hl, wWhichMomItem
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
inc [hl]
.ok
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld a, PHONE_MOM
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld [wCurrentCaller], a
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld bc, EngineBuffer2
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld hl, 0
add hl, bc
ld [hl], 0
inc hl
ld [hl], 1
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld hl, wPhoneScriptPointer - EngineBuffer2
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
add hl, bc
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld a, BANK(Mom_GetScriptPointer)
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld [hli], a
ld a, e
ld [hli], a
ld a, d
ld [hl], a
ret
; fd044
CheckBalance_MomItem2: ; fd044
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld a, [wWhichMomItem]
Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded) Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9. Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
2017-12-23 05:31:04 +00:00
cp NUM_MOM_ITEMS_2
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr nc, .nope
call GetItemFromMom
ld a, [hli]
ld [hMoneyTemp], a
ld a, [hli]
ld [hMoneyTemp + 1], a
ld a, [hli]
ld [hMoneyTemp + 2], a
ld de, wMomsMoney
ld bc, hMoneyTemp
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall CompareMoney
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr nc, .have_enough_money
.nope
jr .check_have_2300
.have_enough_money
scf
ret
.check_have_2300
ld hl, hMoneyTemp
Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff`
2017-12-25 18:40:10 +00:00
ld [hl], HIGH(MOM_MONEY >> 8)
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
inc hl
Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff`
2017-12-25 18:40:10 +00:00
ld [hl], HIGH(MOM_MONEY) ; mid
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
inc hl
Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff`
2017-12-25 18:40:10 +00:00
ld [hl], LOW(MOM_MONEY)
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
.loop
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld de, MomItemTriggerBalance
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld bc, wMomsMoney
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall CompareMoney
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr z, .exact
jr nc, .less_than
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
call .AddMoney
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr .loop
.less_than
xor a
ret
.exact
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
call .AddMoney
Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded) Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9. Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
2017-12-23 05:31:04 +00:00
ld a, NUM_MOM_ITEMS_1
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
call RandomRange
inc a
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld [wWhichMomItemSet], a
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
scf
ret
Local labels starting with capital letters are now decorated with a trailing colon; remove trailing whitespace; globally correct line endings to UNIX style
2016-04-10 18:42:14 +00:00
.AddMoney:
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld de, MomItemTriggerBalance
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld bc, hMoneyTemp
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall AddMoney
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret
; fd0a6
MomBuysItem_DeductFunds: ; fd0a6 (3f:50a6)
call GetItemFromMom
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld de, 3 ; cost
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
add hl, de
ld a, [hli]
ld [hMoneyTemp], a
ld a, [hli]
ld [hMoneyTemp + 1], a
ld a, [hli]
ld [hMoneyTemp + 2], a
ld de, wMomsMoney
ld bc, hMoneyTemp
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall TakeMoney
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
Mom_GiveItemOrDoll: ; fd0c3
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
call GetItemFromMom
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld de, 6 ; item type
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
add hl, de
ld a, [hli]
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
cp MOM_ITEM
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr z, .not_doll
ld a, [hl]
ld c, a
ld b, 1
callba/callab → farcall/callfar
2017-12-24 17:47:30 +00:00
farcall DecorationFlagAction_c
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
scf
ret
.not_doll
ld a, [hl]
ld [CurItem], a
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld a, 1
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld [wItemQuantityChangeBuffer], a
ld hl, PCItems
call ReceiveItem
ret
; fd0eb
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
Mom_GetScriptPointer: ; fd0eb (3f:50eb)
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
call GetItemFromMom
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld de, 6 ; item type
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
add hl, de
ld a, [hli]
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld de, .ItemScript
cp MOM_ITEM
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret z
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
ld de, .DollScript
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret
; fd0fd (3f:50fd)
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
.ItemScript: ; 0xfd0fd
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
writetext _MomText_HiHowAreYou
writetext _MomText_FoundAnItem
writetext _MomText_BoughtWithYourMoney
writetext _MomText_ItsInPC
end
; 0xfd10a
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
.DollScript: ; 0xfd10a
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
writetext _MomText_HiHowAreYou
writetext _MomText_FoundADoll
writetext _MomText_BoughtWithYourMoney
writetext _MomText_ItsInRoom
end
; 0xfd117
GetItemFromMom: ; fd117
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld a, [wWhichMomItemSet]
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
and a
jr z, .zero
dec a
ld de, MomItems_1
Events and some WRAM cleanup
2015-12-19 01:07:09 +00:00
jr .GetFromList1
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
.zero
Move effects; no more reloadmapmusic, returnafterbattle
2015-12-26 23:11:55 +00:00
ld a, [wWhichMomItem]
Move NUM_BUENA_PRIZES to event/buena.asm (still hard-coded) Buena_PrizeMenu has "rept NUM_BUENA_PRIZES", which needs NUM_BUENA_PRIZES to be already defined. BuenaPrizeItems and BuenaPrizeItemsEnd are needed to define NUM_BUENA_PRIZES; but BuenaPrizeItems is defined after Buena_PrizeMenu. I don't see a way to avoid hard-coding its value of 9. Contrast that with the NUM_MOM_ITEMS constants, which are not used as "rept" arguments and so can be defined within their code file.
2017-12-23 05:31:04 +00:00
cp NUM_MOM_ITEMS_2
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
jr c, .ok
xor a
.ok
ld de, MomItems_2
Local labels starting with capital letters are now decorated with a trailing colon; remove trailing whitespace; globally correct line endings to UNIX style
2016-04-10 18:42:14 +00:00
.GetFromList1:
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ld l, a
ld h, 0
rept 3 ; multiply hl by 8
add hl, hl
endr
add hl, de
ret
; fd136
Copy pokered's organization some more, with further constant and data files
2017-12-15 22:22:52 +00:00
INCLUDE "data/items/mom_phone.asm"
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
Clean up XXX comments for unused content
2018-01-02 12:24:05 +00:00
db 0, 0, 0 ; unused
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
_MomText_HiHowAreYou: ; 0xfd1b1
; Hi, ! How are you?
text_jump UnknownText_0x1bc615
db "@"
; 0xfd1b6
_MomText_FoundAnItem: ; 0xfd1b6
; I found a useful item shopping, so
text_jump UnknownText_0x1bc62a
db "@"
; 0xfd1bb
_MomText_BoughtWithYourMoney: ; 0xfd1bb
; I bought it with your money. Sorry!
text_jump UnknownText_0x1bc64e
db "@"
; 0xfd1c0
_MomText_ItsInPC: ; 0xfd1c0
; It's in your PC. You'll like it!
text_jump UnknownText_0x1bc673
db "@"
; 0xfd1c5
_MomText_FoundADoll: ; 0xfd1c5
; While shopping today, I saw this adorable doll, so
text_jump UnknownText_0x1bc693
db "@"
; 0xfd1ca
_MomText_ItsInRoom: ; 0xfd1ca
; It's in your room. You'll love it!
text_jump UnknownText_0x1bc6c7
db "@"
; 0xfd1cf
Clean up XXX comments for unused content
2018-01-02 12:24:05 +00:00
db 0 ; unused
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
Clean up Predef function names
2018-01-02 14:05:14 +00:00
DummyPredef3A: ; fd1d0
main.asm is now under 30k lines
2015-11-19 23:07:20 +00:00
ret
; fd1d1
Clean up XXX comments for unused content
2018-01-02 12:24:05 +00:00
ret ; unused