Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pokecrystal/data/phone/non_trainer_names.asm

18 lines
436 B
NASM
Raw Normal View History

Remove all address comments
2018-06-24 14:09:41 +00:00
NonTrainerCallerNames:
Verify data table sizes with table_width and assert_table_length macros This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 03:22:41 +00:00
; entries correspond to PHONECONTACT_* constants (see constants/trainer_constants.asm)
table_width 2, NonTrainerCallerNames
Move event data to data/events/
2018-01-26 03:19:24 +00:00
dw .none
dw .mom
dw .bikeshop
dw .bill
dw .elm
dw .buena
Verify data table sizes with table_width and assert_table_length macros This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 03:22:41 +00:00
assert_table_length NUM_NONTRAINER_PHONECONTACTS + 1
Move event data to data/events/
2018-01-26 03:19:24 +00:00
.none: db "----------@"
.mom: db "MOM:@"
.bill: db "BILL:@"
.elm: db "PROF.ELM:@"
.bikeshop: db "BIKE SHOP:@"
Fix misnamed character codes Some character codes were erroneously named after their text command counterparts. This has caused a lot of confusion with naming their functions and with other things. I've also removed the `dict2` macro and expanded the `dict` macro. This really isn't something we should be doing for macros but I can't deny it looks a lot neater than repeated code.
2018-07-17 21:08:04 +00:00
.buena: db "BUENA:<LF> DISC JOCKEY@"