Rooba
/
pokecrystal
mirror of https://github.com/pret/pokecrystal.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pokecrystal/engine/phone/phonering_copytilemapatonce...

81 lines
1.1 KiB
NASM
Raw Normal View History

Remove all address comments
2018-06-24 14:09:41 +00:00
PhoneRing_CopyTilemapAtOnce:
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hCGB]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
and a
jp z, WaitBGMap
ld a, [wSpriteUpdatesEnabled]
cp $0
jp z, WaitBGMap
; What follows is a modified version of CopyTilemapAtOnce.
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hBGMapMode]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
push af
xor a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hBGMapMode], a
ldh a, [hMapAnims]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
push af
xor a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hMapAnims], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
.wait
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [rLY]
LY_BLANK and rLCDC constants
2017-12-29 17:53:21 +00:00
cp LY_VBLANK - 1
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
jr c, .wait
di
Lowercase v for VRAM addresses
2017-12-28 12:32:33 +00:00
ld a, BANK(vBGMap2)
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [rVBK], a
Prefix wram labels with w, part 2.
2018-01-23 22:39:09 +00:00
hlcoord 0, 0, wAttrMap
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
call .CopyTilemapAtOnce
Lowercase v for VRAM addresses
2017-12-28 12:32:33 +00:00
ld a, BANK(vBGMap0)
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [rVBK], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
hlcoord 0, 0
call .CopyTilemapAtOnce
.wait2
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [rLY]
LY_BLANK and rLCDC constants
2017-12-29 17:53:21 +00:00
cp LY_VBLANK - 1
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
jr c, .wait2
ei
pop af
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hMapAnims], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
pop af
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hBGMapMode], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ret
Remove all address comments
2018-06-24 14:09:41 +00:00
.CopyTilemapAtOnce:
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ld [hSPBuffer], sp
ld sp, hl
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hBGMapAddress + 1]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ld h, a
ld l, 0
ld a, SCREEN_HEIGHT
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hTilesPerCycle], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ld b, 1 << 1 ; not in v/hblank
Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff`
2017-12-25 18:40:10 +00:00
ld c, LOW(rSTAT)
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
.loop
rept SCREEN_WIDTH / 2
pop de
.loop\@
ld a, [$ff00+c]
and b
jr nz, .loop\@
ld [hl], e
inc l
ld [hl], d
inc l
endr
ld de, BG_MAP_WIDTH - SCREEN_WIDTH
add hl, de
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hTilesPerCycle]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
dec a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh [hTilesPerCycle], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
jr nz, .loop
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hSPBuffer]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ld l, a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 18:28:22 +00:00
ldh a, [hSPBuffer + 1]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-25 00:35:35 +00:00
ld h, a
ld sp, hl
ret