mirror of https://github.com/perkeep/perkeep.git
e007f66b76
To rev 99ff426eb706cffe92ff3d058e168b278cabf7c7 To support the new default authentication plugin in MySQL 8. Interestingly, the update also revealed an error unseen so far. Each of the pkg/sorted/mysql test uses a docker container. If we did not kill the container at the end of a test, docker would use a new, different, IP address for each mysql container (which would dodge the error I'm about to mention). But since we do clean up and remove the container for each test, then each test gets a container with the same (first in the range) IP address, because docker "thinks" everything about the previous container was properly removed. However, it turns out that since we had forgotten to tell the client code to close the connection to the mysql server, then the server-side IP:port is still seen as occupied (even though the server is gone). And since the second (or nth) test client tries connecting to the same IP:port, the connection fails. TL;DR: we also need to close the connection to the DB on the client side, even though the server in container goes away after each test. Fixes #1114 Change-Id: I76ce4ac2ee7703f92a9431116cd82ab75da541f7 |
||
|---|---|---|
| .. | ||
| asserts | ||
| dockertest | ||
| integration | ||
| testdata | ||
| blob.go | ||
| diff.go | ||
| doc.go | ||
| fetcher.go | ||
| fetcher_test.go | ||
| loader.go | ||
| test.go | ||
| test_test.go | ||
| testdep.go | ||
| wait.go | ||
| world.go | ||