mirror of https://github.com/perkeep/perkeep.git
![]() A word of caution: relatedly to the issue demonstrated by the added tests, an infinite loop can also occur, as it already could in TestReindex_LevelDB. As it is, after all, a consequence of a race, I haven't been able to determine what exactly makes the loop occur. But what I observed is: 1) It seems to be occuring much more easily with LevelDB, which is why I ended up just disabling TestReindex_LevelDB. 2) I've never seen it happen in TestReindex_Kvfile, but who knows. 3) I've seen it rarely happen with TestShowReindexRace_Kvfile, but it seems that adding in TestShowReindexRace_Kvfile the kind of timed kill that I had added TestReindex_LevelDB, actually makes the loop happen much more often. And it ends up eclipsing the original issue that we want to demonstrate, which is why I decided against it. TL;DR: if you use -show_reindex_race=true , be prepared to maybe have to kill(1) the test manually. Change-Id: I47fd3c55363c8d0dda17ad19665115cb96f3d58f |
||
---|---|---|
.. | ||
testdata | ||
tests.go |