Commit Graph

14 Commits

Author SHA1 Message Date
Brad Fitzpatrick 12894d4630 all: Windows fixes (don't listen on file descriptors in test.World, etc)
test/integration: don't listen on file descriptors.
make.go: unrelated, but options to make it much faster.
internal/images: t.Skip on HEIC dependency failures

Fixes #1140
Updates golang/go#25210

Change-Id: I8092155411826d6ed1f8d85230b753d1369044af
2018-05-01 21:38:19 -07:00
Brad Fitzpatrick c698ff5add misc/docker/heiftojpeg: switch to ImageMagick
Still slow, but no more ffmpeg child processes, and I'm confident
ImageMagick will improve over time. There are actually ImageMagick
commits in the past few hours that look promising. We have a demo
tomorrow, so we're not going to bump our git rev & Docker image to the
latest ImageMagick master yet.

Updates #969

Change-Id: I7a8545821cae4214ea521d7cb46aa235ae3f0ed3
2018-04-27 16:26:14 -07:00
Brad Fitzpatrick 6b88e2a73f internal/images: broaden pattern that matches HEIC images
A bunch of mine had a larger initial ftyp box, which broke the second
part of the pattern. But the second part of the pattern doesn't matter
anyway.  This only needs to casually recognize them. A later full
parse will determine what they really are.

This also adds some new debugging when CAMLI_DEBUG is true.

Change-Id: Ib4adc9b5447a64ba4682624e42b55f1d65779ef7
2018-04-27 12:29:00 -07:00
Brad Fitzpatrick a062b701c9 all: more log spam & logging consistency cleanup
Change-Id: Ibc38c2eed86e75afb064ba25ba586494c813f56c
2018-04-22 11:30:02 -07:00
Brad Fitzpatrick 614b3f4cee internal/images: use tmpfs for heiftojpeg's /tmp dir for ffmpeg scratch space
Change-Id: Ia1691e17fb8bd95dfb3333aab67bd180a4d6fe58
2018-04-21 12:06:05 -07:00
mpl 3014bd7413 pkg/index: read EXIF bytes when HEIC file
Updates #969

Change-Id: I11cc1668b853fe5bc2d076addda1a60c08be1dc5
2018-04-18 17:39:38 +02:00
mpl 149212b828 internal/images: reset err to nil on no EXIF found
the changes to DecodeConfig in ce955adf48
moved the call to image.DecodeConfig to before the call to exif.Decode,
because we need to do that for the HEIF case.

After the call to exif.Decode, if err is nil and is not a short read
error, we ignore the error and the code goes on. To mark that intent,
we should have explicitly set the err to nil at this point. However,
that omission did not matter before
ce955adf48 because image.DecodeConfig
was the last setter of the error.

Now that it has moved up, we do have to explicitly reset the err to nil.
While we were at it, we rewrote the whole logic to be easier to read.

This seems to fix all the tests in pkg/index and pkg/search.

Change-Id: Id0b711179ccb1365b851d3e86ecb70d47ac358b4
2018-04-18 03:41:14 +02:00
mpl 4050d088dc internal/images: gate docker pull for thumbnails
Fixes #1091

Change-Id: I31fda636cec4b4ae06c74cc2c04b6986f10222c3
2018-04-17 17:13:50 +02:00
mpl ce955adf48 pkg/index: start support for HEIC images
Just enough to index an image's dimensions, and display its thumbnails
in the web UI.
Works with docker too.

Udates #969

Change-Id: Ie443cced4f785c332ca98f09eb647f00e53a532e
2018-04-17 02:53:55 +02:00
mpl 132f912df8 internal/images: start support for HEIF
Use it in pkg/server for thumbnailing, but it will actually not be
called until we add basic indexation/description of HEIF too.

Updates #969

Change-Id: I3e4e40534feaff70f404d96d4e87c8dd057f880d
2018-04-13 02:46:59 +02:00
Paul Lindner 459c75410e all: more renaming of Camlistore to Perkeep
Change-Id: I118e3cbcf20d80afeffc84f001388c4556f21628
2018-01-30 03:02:56 -08:00
Brad Fitzpatrick 9265c980de all: change github.com/camlistore/camlistore to github.com/perkeep/perkeep
Change-Id: I0d612bf450e9e8d9ce0767c5a0cb0c44c0d8704f
2018-01-05 19:49:59 -08:00
Brad Fitzpatrick 57648c6b83 all: update copyright holder from Google Inc to The Perkeep Authors
The AUTHORS file is the list of copyright holders.
2018-01-03 16:52:49 -08:00
Brad Fitzpatrick c3d05cdce9 Move more packages out of pkg/ and into internal/
Moved hashutil, httputil, osutil, netutil,
images, media, magic, video, and rollsum.
2018-01-02 21:03:30 -08:00