Due to a change in the Android NDK (starting from r16), building the
docker container fails with an error during the installation of
gomobile:
fatal error: 'stdlib.h' file not found
This issue was addressed in more recent versions of gomobile, which
are compatible with the new NDK.
See https://github.com/golang/go/issues/21802
This CL simply updates gomobile to the most recent commit.
Change-Id: I87c468c34de441bc6acd40b717d1d950014e5a99
The ~/.gradle and ~/.android dirs are mounted as volumes for the docker
container when building the app, because we want the gradle and android
deps to be cached on the host after they've been downloaded.
The build process was assuming that these dirs always already existed,
and this assumption makes the building process fail if they actually
don't.
Therefore this change creates the directories on the host if they don't
already exist.
Change-Id: I90b5f73db0ffcbe76adc12157e142091808bde2b
It seems that on other (more modern?) configurations, the cgroup for
processes in docker is /system.slice/docker.service instead of /docker.
I have not been able to reproduce such a configuration. But until we have
a better way to detect whether a process is in docker, it's probably ok
to just add the new path to validate the detection, which this change
does.
Fixes#973
Change-Id: I9d52bcd79a906fdc1f8310b2c8063930cf9807fb
Android Studio requires newer versions of the Android SDK Build-Tools
and Gradle to build the uploader application.
In this commit, Gradle is updated to version 3.3 (as suggested by
Android Studio) and the Android SDK Build-Tools to the most recent
release.
Change-Id: Ief04ec56a6fffb0b46bd28820134c8e7a1ebbede
When reinstalling the app, using shell commands to set executable
permissions on the camput binary sometimes fails for unknown reasons.
The camput binary keeps 0660 permissions even though no error is
reported. The frequency of failed deployments seems to increase when
more recent build tools are used in the build process. On a Nexus 5X,
observed failure rates are in the order of one in twenty up to one in
six.
This commit removes all use of shell commands for deploying camput and
utilizes native java methods instead. While the resulting permissions of
camput change from 0700 to 0760, this is acceptable as the group is
app-specific and not shared.
A call to fsync is added to ensure that all file data (not just
metadata) is committed to disk before the file is renamed. This should
be safer in the event of a power loss as we're most likely writing to an
ext4 file system (the noauto_da_alloc mount option is used on modern
devices, see [1]).
With these changes, no failures to set executable permission bits could
be observed, regardless of build tool version used (v19.1 and v26.0,
n=30 each).
Fixes#932
[1] https://www.kernel.org/doc/Documentation/filesystems/ext4.txt
Change-Id: I290b4ce896aa449afef89ac87cdd0431752ceb93
When building the uploader application with a newer version of the build
tools, the build fails in stage app:lintVitalRelease with a lint error of
type WifiMangerLeak. The wifi manager instance should always be obtained
from an application context in order to avoid a memory leak on Android
versions before N. See:
https://developer.android.com/reference/android/net/wifi/WifiManager.html
This commit implements the recommendation to obtain the wifi manager
instance through the application context.
Change-Id: I59ff0dfb381b82d9b4f201b646f11b34b3de3cff
While the log message claims that the permissions of the camput binary
were set to 0700, they were actually set to 0777.
Change-Id: Ic5adbc05af161431823a3fb1685af5fa9a4b6647
Android applications nowadays are supposed to be developped with Android
Studio, which uses gradle as the build system, with the android plugin.
This change modifies the app setup and file tree layout so it can be
built with gradle (in docker by default) instead of with ant.
The initial motivation for this change is to make changes to the app in
Go, using 'gomobile bind' to call the Go code from java. As the canonical
example at golang.org/x/mobile/example/bind/hello uses gradle, the
first step was to migrate the app to gradle.
Even if we don't end up using gomobile, this change is interesting as it
makes it easier for android apps developpers to contribute to the app if
it uses the recommended "modern" way.
Change-Id: I8386012db640324b62e18ffc128b68ba971fa953
On some devices, updating notifications and status text at a high rate
causes whole-system UI lag and even complete system freezes. On a
Nexus 5, the uploader is completely unusable and requires a hard phone
restart almost every time "upload all" is triggered from the UI. The
device freezes happen across multiple stock Android releases.
This commit reduces the update rate of the UI significantly by updating
the notification only when the integer percent value of the upload
progress changes. It also reduces the update rate of the status text to
around 30 fps, which should still be plenty. With both of the changes,
the uploader behaves as expected. Either change alone is not enough to
get rid of the device freezes.
Change-Id: I2c170772d29c4670c8c10d09cdaea96207fc9e61
- Added a null check I missed in my last commit.
- Fixed duplicated Permission ACCESS_NETWORK_STATE in manifest.
Change-Id: I0da93b3e83ac584cb8fe36b2c3b9f1c711b08a8a
This is a first shot at
https://code.google.com/p/camlistore/issues/detail?id=496.
A user can enter a SSID and the upload will only run over Wifis with
this SSID. If the SSID option is left empty, everything works as before.
Change-Id: Ief3642c5b9c14d059f42696531fa33d1d780ab1c
I scratched my own itch and addressed
https://code.google.com/p/camlistore/issues/detail?id=494
for my HTC One M8 which stores pictures taken with its camera
to /sdcard/DCIM/100MEDIA.
Hardcoding these paths is far from being a good solution. I hope I can
find the time to get deeper into Android coding and come up with some
for https://code.google.com/p/camlistore/issues/detail?id=37 over the
next weeks.
Change-Id: I4e351c1915c5c7f66948d434d72763c826a25a16
Import src/com/google/zxing from
https://github.com/zxing/zxing/android-integration/src/ at revision:
commit 7d35bd0bddbe84185b9f79c5cb07749a8767c952
Author: Sean Owen <srowen@gmail.com>
Date: Wed Aug 6 09:05:22 2014 +0100
Uses zxing dervied barcode scanner apps to do the heavy lifting. If the
user does not already have the app installed a dialog will open that
directs them to install it from the Google Play store.
Addresses https://camlistore.org/issue/372
Change-Id: Ic398b77cd9795aca533be101b2ebcd5631cc7f20
Fixed duplicates in upload list with proper synchronization
Added a filename when vivifying
Reset cache on storageGeneration change
Change-Id: Ibb3551d565c4acdbdfd17055118263144ee4a135
Fixed crash on vivify error.
Cleanup for names and properties.
Reformatted to webkit style.
Better treatment of logging network failures, actual done text when done.
Don't double add uploads
Moved the settings panel showing to viewdidappear, where it should be.
Added images to the upload cells.
Reset progress bar for reusable cells.
Updated podfile with keychain tools.
Updated for better keychain management.
Mitigated a leak.
Change-Id: Iad428aae56ac26e71743bd3e86b0f7736eff9767
Requires cocoapods to manage dependencies now, just `pod install` to use. Fixed issues where blobroot wasn't properly set and added some more logging to the main view.
Change-Id: I59119de2c057196133648acfb641b21683488bc6
Tilman Dilo
