perkeep

Commit Graph

Author	SHA1	Message	Date
Brad Fitzpatrick	bafc53703d	context: don't allow mutating an existing context's HTTP client Instead, require specifying it when constructing a new context. Prevents misuse and bugs / data races. Change-Id: I775e998bf69b9e238ec726c469494c1a65f8f9de	2014-07-02 14:34:24 -07:00
mpl	731a362e27	importers: provide authenticated transport for picasa And revert context-related changes to importer.go so the other importers work again. The problem is picago calls take an *http.Client, so we need to provide one which already has a transport set up correctly wrt to authentication. In particular, it needs to have the access token that was obtained during oauth. Change-Id: I7b83cd80910111a9abf1c192cc59841f6d818fb7	2014-05-22 15:25:34 +02:00
Tamás Gulácsi	cbb777ffb0	Rewrite Picasa importer for the new Importer API Reorganizes common OAuth2 things into importer/oa2_importers.go Rewrites CallbackURLParameters to return url.Values. A controversial workaround for nil context has been left out, and this may cause panic and will need a proper fix. Change-Id: I0789f4732412aa559078ec2c6b6797925ab8cd05	2014-05-21 22:37:50 +02:00

Author

SHA1

Message

Date

Brad Fitzpatrick

bafc53703d

context: don't allow mutating an existing context's HTTP client

Instead, require specifying it when constructing a new context.

Prevents misuse and bugs / data races.

Change-Id: I775e998bf69b9e238ec726c469494c1a65f8f9de

2014-07-02 14:34:24 -07:00

mpl

731a362e27

importers: provide authenticated transport for picasa

And revert context-related changes to importer.go so the other
importers work again.

The problem is picago calls take an *http.Client, so we need to provide
one which already has a transport set up correctly wrt to authentication.
In particular, it needs to have the access token that was obtained
during oauth.

Change-Id: I7b83cd80910111a9abf1c192cc59841f6d818fb7

2014-05-22 15:25:34 +02:00

Tamás Gulácsi

cbb777ffb0

Rewrite Picasa importer for the new Importer API

Reorganizes common OAuth2 things into importer/oa2_importers.go
Rewrites CallbackURLParameters to return url.Values.

A controversial workaround for nil context has been left out,
and this may cause panic and will need a proper fix.

Change-Id: I0789f4732412aa559078ec2c6b6797925ab8cd05

2014-05-21 22:37:50 +02:00

3 Commits