The "files" field of a file search response was always non-null (empty JSON array in case of error or no result).
This behaviour was broken by df7cc0b453, so this CL is restoring it.
Fixes#619
Change-Id: I8e4762d1f5a2dba4f7cf06d8ca164392c4bf6d6a
Fix some UI queries, since UI always queries with "-created".
Also add Unsorted, to override the CreatedDesc default, for when we
really do not want to sort, e.g. when we don't have a corpus and
trying to sort would make us error out.
Issue #579
Change-Id: Ife0aa816c5e8cac8dc6612d0ffd104238abc6838
Otherwise it can't send Describe Rules.
Also in this commit: a bunch of new tests from when I thought I was going crazy
and trying to debug the search system, before I realized the problem was that the
client was doing a GET request and dropping most of my DescribeRequest.
Change-Id: I4ea9bed80f0d7d6b86814527b63acc3586ac1d06
There are several places where we're using a *search.Handler, when we
only want to be able to do query and describe requests. When these
places need to be moved also out of the context of camlistored, (like
when making a server app such as the publisher), the QueryDescriber can
be used, and the adequate implementation (*search.Handler,
*client.Client, or any other) is used depending on the context.
Change-Id: Ie1c5bb6f1bbba32c24a8eb2d1175af95ffcc8335
Instead, require specifying it when constructing a new context.
Prevents misuse and bugs / data races.
Change-Id: I775e998bf69b9e238ec726c469494c1a65f8f9de
Should no longer be necessary, and actually harmful often.
But this might break something. I can't find anything, though. We'll see.
Change-Id: I2b798a893100031b26251b0de7fa31ea5c4774d8
Index "MusicBrainz Album ID" ID3v2 frames as
"musicbrainzalbumid" media tags to facilitate downloading
cover art from coverartarchive.org.
Change-Id: Ie81017dd6f76ec355ee0d1daedfb7180cb70ad59
Step towards getting rid of the the integer describe depth API.
Now, after the integer describe depth, all the DescribeRules will also
run to expand things.
Change-Id: I5cfe7e6058be51328e529a2299e13a6a2ba5f869
I am a first time committer and I am using the fix to issue number 402 as a bug to learn to learn how to commit to this process. I am not sure if this is the correct way to fix this bug -- the submitter of the bug believes it is -- so please review my code with scrutiny. Thank you.
Change-Id: I6c56b7866d530e1b1c66c563f201e6d1e13d3fa9
'and' has precendence over 'or'.
both operators are left associative
parenthesized expressions are evaluated first
Parser refactored, parseAtom split up.
Change-Id: I1f194cc75df49bad9d30d041d689d8ba833076f1
Use generic queries instead of specialized index queries. This is a step
towards the publisher app, because its client will have to use generic
queries.
Context: http://camlistore.org/issue/365
Change-Id: I2781a345e024174e3bea8511b6cdc6f342d5a7c1