diff --git a/website/camweb.go b/website/camweb.go index 3d6e9cd02..8cd1713fd 100644 --- a/website/camweb.go +++ b/website/camweb.go @@ -82,6 +82,8 @@ var ( gceLogName = flag.String("gce_log_name", "", "GCE Cloud Logging log name; if non-empty, logs go to Cloud Logging instead of Apache-style local disk log files") gceJWTFile = flag.String("gce_jwt_file", "", "If non-empty, a filename to the GCE Service Account's JWT (JSON) config file.") gitContainer = flag.Bool("git_container", false, "Use git from the `camlistore/git` Docker container; if false, the system `git` is used.") + + flagChromeBugRepro = flag.Bool("chrome_bug", false, "Run the chrome bug repro demo for issue #660. True in production.") ) var ( @@ -466,6 +468,7 @@ func setProdFlags() { log.Fatal("can't use dev mode in production") } log.Printf("Running in production; configuring prod flags & containers") + *flagChromeBugRepro = true *httpAddr = ":80" *httpsAddr = ":443" *buildbotBackend = "https://travis-ci.org/camlistore/camlistore" @@ -755,6 +758,12 @@ func main() { }() } + if *flagChromeBugRepro { + go func() { + log.Printf("Repro handler failed: %v", repro(":8001", "foo:bar")) + }() + } + select { case err := <-emailErr: log.Fatalf("Error sending emails: %v", err) diff --git a/website/chrome_bug-repro.go b/website/chrome_bug-repro.go new file mode 100644 index 000000000..fd0df1e37 --- /dev/null +++ b/website/chrome_bug-repro.go @@ -0,0 +1,232 @@ +package main + +import ( + "bytes" + "encoding/base64" + "fmt" + "io" + "log" + "mime" + "net/http" + "regexp" + "strings" + "time" +) + +var basicAuthPattern = regexp.MustCompile(`^Basic ([a-zA-Z0-9\+/=]+)`) + +// basicAuth returns the username and password provided in the Authorization +// header of the request, or an error if anything went wrong. +func basicAuth(req *http.Request) (user string, password string, err error) { + auth := req.Header.Get("Authorization") + if auth == "" { + return "", "", fmt.Errorf("Missing \"Authorization\" in header") + } + matches := basicAuthPattern.FindStringSubmatch(auth) + if len(matches) != 2 { + return "", "", fmt.Errorf("Bogus Authorization header") + } + encoded := matches[1] + enc := base64.StdEncoding + decBuf := make([]byte, enc.DecodedLen(len(encoded))) + n, err := enc.Decode(decBuf, []byte(encoded)) + if err != nil { + return "", "", err + } + pieces := strings.SplitN(string(decBuf[0:n]), ":", 2) + if len(pieces) != 2 { + return "", "", fmt.Errorf("didn't get two pieces") + } + return pieces[0], pieces[1], nil +} + +type userPass struct { + username string + password string +} + +func (up userPass) isAllowed(req *http.Request) bool { + user, pass, err := basicAuth(req) + if err != nil { + log.Printf("Authorization failed: %v", err) + return false + } + return user == up.username && pass == up.password +} + +func sendUnauthorized(rw http.ResponseWriter, req *http.Request) { + realm := "" + rw.Header().Set("WWW-Authenticate", fmt.Sprintf("Basic realm=%q", realm)) + rw.WriteHeader(http.StatusUnauthorized) + fmt.Fprintf(rw, "

Unauthorized

") +} + +func newUserPass(userpass string) userPass { + pieces := strings.Split(userpass, ":") + if len(pieces) < 2 { + log.Fatalf("Wrong userpass auth string: %q; needs to be \"username:password\"", userpass) + } + return userPass{ + username: pieces[0], + password: pieces[1], + } +} + +func receivePost(w http.ResponseWriter, r *http.Request) { + multipart, err := r.MultipartReader() + if err != nil || multipart == nil { + http.Error(w, fmt.Sprintf("multipart reader error: %v", err), http.StatusBadRequest) + return + } + + for { + mimePart, err := multipart.NextPart() + if err == io.EOF { + break + } + if err != nil { + log.Printf("Error reading multipart section: %v", err) + http.Error(w, fmt.Sprintf("Error reading multipart section: %v", err), http.StatusInternalServerError) + return + } + + contentDisposition, params, err := mime.ParseMediaType(mimePart.Header.Get("Content-Disposition")) + if err != nil { + http.Error(w, "invalid Content-Disposition", http.StatusBadRequest) + return + } + + if contentDisposition != "form-data" { + http.Error(w, fmt.Sprintf("Expected Content-Disposition of \"form-data\"; got %q", contentDisposition), http.StatusBadRequest) + return + } + + formName := params["name"] + if formName != "someKey" { + http.Error(w, fmt.Sprintf("invalid form name parameter name; got %q, wanted \"someKey\"", formName), http.StatusBadRequest) + return + } + + var buf bytes.Buffer + if _, err := io.Copy(&buf, mimePart); err != nil { + log.Printf("error reading form value: %v", err) + http.Error(w, fmt.Sprintf("error reading form value: %v", err), http.StatusInternalServerError) + return + } + formValue := buf.String() + if formValue != "someValue" { + http.Error(w, fmt.Sprintf("invalid form value; got %q, wanted \"someValue\"", formValue), http.StatusBadRequest) + return + } + fmt.Fprintf(w, "%v: Correctly received post value %q in %v to %v", time.Now(), formValue, r.Method, r.URL.Path) + return + } +} + +// host: ":8001", "listening port and hostname" +// userpass: "foo:bar", "basic auth username and password" +func repro(host, userpass string) error { + up := newUserPass(userpass) + + mux := http.NewServeMux() + mux.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { + if r.Method != "GET" { + http.Error(w, "NOT A GET", http.StatusBadRequest) + return + } + fmt.Fprint(w, clientCode()) + }) + mux.HandleFunc("/apiget", func(w http.ResponseWriter, r *http.Request) { + if r.Method != "GET" { + http.Error(w, "NOT A GET", http.StatusBadRequest) + return + } + fmt.Fprintf(w, "Hello World, it is %v, and I received a %v for %v.", time.Now(), r.Method, r.URL.Path) + }) + mux.HandleFunc("/apipost", func(w http.ResponseWriter, r *http.Request) { + if up.isAllowed(r) { + if r.Method != "POST" { + http.Error(w, "NOT A POST", http.StatusBadRequest) + return + } + receivePost(w, r) + return + } + sendUnauthorized(w, r) + }) + t := &http.Server{ + Addr: host, + Handler: mux, + } + return t.ListenAndServe() +} + +func clientCode() string { + return ` + + + + + + +

+ Open this page in a new incognito window, otherwise some caching messes up the repro. And apparently you also need to close all the other incognito windows where you tried this, when you want to retry it in a new one.
+ Open the debug console.
+

+ +

+ Start with:
+
+ (username: foo, password: bar)
+ which should send a FormData with a Blob in it,
+ and notice that it fails (whereas it doesn't on firefox), because the Blob in the authenticated retry was not resent with the original contents. +

+ +

+ Now do it again:
+
+ and notice that it works this time, because the request is authenticated right from the start now, so there's no retry needed, therefore the bug can't happen. +

+ +

+ Alternatively, load the page in a new incognito window, and start with a
+ or a (FormData without a Blob)
+ and notice that not only there's no problem with any of those, but also that a subsequent
+
+ works fine too, for the same reasons explained above (no retry needed). +

+ +

+ Note: the same kind of bug/behaviour can be observed when automatically following a 307 (which also does not fail on firefox). +

+ + +` +}