From cd79828912d4ee0d1b624dc01e058b836ed3df2f Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Sat, 21 Apr 2012 07:07:07 -0700 Subject: [PATCH] camput: move nodeworker into its own file Change-Id: Ic61d35955fe4dd59ada65a314f0c94cc3f7b0f87 --- cmd/camput/camput.go | 71 ------------------------------ cmd/camput/chanworker.go | 94 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 94 insertions(+), 71 deletions(-) create mode 100644 cmd/camput/chanworker.go diff --git a/cmd/camput/camput.go b/cmd/camput/camput.go index 54fd88d58..d9a817388 100644 --- a/cmd/camput/camput.go +++ b/cmd/camput/camput.go @@ -17,7 +17,6 @@ limitations under the License. package main import ( - "container/list" "errors" "flag" "fmt" @@ -403,76 +402,6 @@ func (t *TreeUpload) statPath(fullPath string, fi os.FileInfo) (nod *node, err e return n, nil } -type nodeWorker struct { - c chan *node - - donec chan bool - workc chan *node - fn func(n *node, ok bool) - buf *list.List -} - -// NewNodeWorker starts nWorkers goroutines running fn on incoming -// nodes sent on the returned channel. fn may block; writes to the -// channel will buffer. -func NewNodeWorker(nWorkers int, fn func(n *node, ok bool)) chan<- *node { - w := &nodeWorker{ - c: make(chan *node, buffered), - workc: make(chan *node, buffered), - donec: make(chan bool), // when workers finish - fn: fn, - buf: list.New(), - } - go w.pump() - for i := 0; i < nWorkers; i++ { - go w.work() - } - go func() { - for i := 0; i < nWorkers; i++ { - <-w.donec - } - fn(nil, false) // final sentinel - }() - return w.c -} - -func (w *nodeWorker) pump() { - inc := w.c - for inc != nil || w.buf.Len() > 0 { - outc := w.workc - var frontNode *node - if e := w.buf.Front(); e != nil { - frontNode = e.Value.(*node) - } else { - outc = nil - } - select { - case outc <- frontNode: - w.buf.Remove(w.buf.Front()) - case n, ok := <-inc: - if !ok { - inc = nil - continue - } - w.buf.PushBack(n) - } - } - close(w.workc) -} - -func (w *nodeWorker) work() { - for { - select { - case n, ok := <-w.workc: - if !ok { - w.donec <- true - return - } - w.fn(n, true) - } - } -} - const uploadWorkers = 5 func (t *TreeUpload) run() { diff --git a/cmd/camput/chanworker.go b/cmd/camput/chanworker.go new file mode 100644 index 000000000..ac5d7961a --- /dev/null +++ b/cmd/camput/chanworker.go @@ -0,0 +1,94 @@ +/* +Copyright 2012 Google Inc. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +// Worker pools of functions processing channel input. +// TODO(brafitz): move this to a common library, making it operate on interface{} instead? + +package main + +import ( + "container/list" +) + +type nodeWorker struct { + c chan *node + + donec chan bool + workc chan *node + fn func(n *node, ok bool) + buf *list.List +} + +// NewNodeWorker starts nWorkers goroutines running fn on incoming +// nodes sent on the returned channel. fn may block; writes to the +// channel will buffer. +func NewNodeWorker(nWorkers int, fn func(n *node, ok bool)) chan<- *node { + w := &nodeWorker{ + c: make(chan *node, buffered), + workc: make(chan *node, buffered), + donec: make(chan bool), // when workers finish + fn: fn, + buf: list.New(), + } + go w.pump() + for i := 0; i < nWorkers; i++ { + go w.work() + } + go func() { + for i := 0; i < nWorkers; i++ { + <-w.donec + } + fn(nil, false) // final sentinel + }() + return w.c +} + +func (w *nodeWorker) pump() { + inc := w.c + for inc != nil || w.buf.Len() > 0 { + outc := w.workc + var frontNode *node + if e := w.buf.Front(); e != nil { + frontNode = e.Value.(*node) + } else { + outc = nil + } + select { + case outc <- frontNode: + w.buf.Remove(w.buf.Front()) + case n, ok := <-inc: + if !ok { + inc = nil + continue + } + w.buf.PushBack(n) + } + } + close(w.workc) +} + +func (w *nodeWorker) work() { + for { + select { + case n, ok := <-w.workc: + if !ok { + w.donec <- true + return + } + w.fn(n, true) + } + } +}