Makefile: fmt target

Made it a prerequisite of presubmit

Change-Id: Ia0d8f5f5bf1131d4004c950af98ad5e078b3423b
This commit is contained in:
Steven L. Speek 2014-03-20 19:57:29 +01:00
parent bf041c8955
commit a40d5d467b
2 changed files with 4 additions and 3 deletions

View File

@ -16,7 +16,7 @@ full:
forcefull:
go install -a --tags=with_sqlite ./pkg/... ./server/... ./cmd/... ./third_party/... ./dev/...
presubmit:
presubmit: fmt
SKIP_DEP_TESTS=1 go test `pkg-config --libs sqlite3 1>/dev/null 2>/dev/null && echo "--tags=with_sqlite"` -short ./pkg/... ./server/camlistored/... ./server/appengine ./cmd/... ./dev/... && echo PASS
embeds:
@ -29,6 +29,9 @@ NEWUIDIR = server/camlistored/newui
clean:
rm -f $(NEWUIDIR)/all.js $(NEWUIDIR)/all.js.map
fmt:
go fmt camlistore.org/cmd... camlistore.org/dev... camlistore.org/misc... camlistore.org/pkg... camlistore.org/server...
genclosuredeps: $(UIDIR)/deps.js
$(UIDIR)/deps.js: $(UIDIR)/blobinfo.js $(UIDIR)/blob_item.js $(UIDIR)/blob_item_container.js $(UIDIR)/create_item.js $(UIDIR)/filetree.js $(UIDIR)/index.js $(UIDIR)/permanode.js $(UIDIR)/pics.js $(UIDIR)/server_connection.js $(UIDIR)/server_connection.js $(UIDIR)/search.js $(UIDIR)/server_type.js $(UIDIR)/sigdebug.js $(UIDIR)/toolbar.js $(UIDIR)/base64.js $(UIDIR)/Crypto.js $(UIDIR)/SHA1.js

2
TODO
View File

@ -195,8 +195,6 @@ Offline list:
be able to reload itself, and also watch for binaries changing and restart
when binaries change. (or symlinks to binaries)
-- add gofmt check to "make presubmit". also add "make fmt" target.
-- BUG: osutil paths.go on OS X: should use Library everywhere instead of mix of
Library and ~/.camlistore?