From 9ff0a95eb6b9488a1e35f49c0eb96dc5ddff880c Mon Sep 17 00:00:00 2001 From: Bill Thiede Date: Wed, 3 Jul 2013 19:44:57 -0700 Subject: [PATCH] Enable logging when full build fails. Change-Id: If8fba29e2e83bc954832c644ccc8e2a1695a46d6 --- make.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/make.go b/make.go index a43e10156..0f954f913 100644 --- a/make.go +++ b/make.go @@ -195,10 +195,12 @@ func main() { cmd.Stderr = os.Stderr } if *verbose { + // TODO(reviewer) should this be cmd.Args too? Providing the contents + // of baseArgs doesn't hurt when you're trying to debug. log.Printf("Running go install of main binaries with args %s", targs) } if err := cmd.Run(); err != nil { - log.Fatalf("Error building: %v\n%s", err, output.String()) + log.Fatalf("Error building main binaries: %v\n%s", err, output.String()) } if buildAll { @@ -212,11 +214,18 @@ func main() { "camlistore.org/third_party/...", )...) cmd.Env = append(cleanGoEnv(), "GOPATH="+buildGoPath) + if *quiet { + cmd.Stdout = &output + cmd.Stderr = &output + } else { + cmd.Stdout = os.Stdout + cmd.Stderr = os.Stderr + } if *verbose { - log.Printf("Running full go install with args %s", args) + log.Printf("Running full go install with args %s", cmd.Args) } if err := cmd.Run(); err != nil { - log.Fatalf("Error building: %v", err) + log.Fatalf("Error building full install: %v\n%s", err, output.String()) } }