Rooba
/
perkeep
mirror of https://github.com/perkeep/perkeep.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

serverconfig: remove TODOs about FindHandlerByType since its behaviour now complies with the docs 

Change-Id: I7ca754c0a27aa0ffc1bc1b4fe034a1c17f1876ef
This commit is contained in:
mpl 2013-01-17 16:54:07 +01:00
parent 306c6f9c19
commit 7e448fe05e
2 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/blobserver/handlers/upload.go
View File

@ -96,7 +96,6 @@ func vivify(blobReceiver blobserver.BlobReceiveConfiger, fileblob blobref.SizedB
return errors.New("blobReceiver config has no HandlerFinder") return errors.New("blobReceiver config has no HandlerFinder")
} }
JSONSignRoot, sh, err := hf.FindHandlerByType("jsonsign") JSONSignRoot, sh, err := hf.FindHandlerByType("jsonsign")
// TODO(mpl): second check should not be necessary, and yet it happens. Figure it out.
if err != nil || sh == nil { if err != nil || sh == nil {
return errors.New("jsonsign handler not found") return errors.New("jsonsign handler not found")
} }

2
pkg/serverconfig/serverconfig.go
View File

@ -170,8 +170,6 @@ func (hl *handlerLoader) GetRequestContext() (req *http.Request, ok bool) {
return hl.context, hl.context != nil return hl.context, hl.context != nil
} }
// TODO(mpl): investigate bug: when I used it to find /sighelper/ within
// makeCamliHandler, it returned "/sighelper", nil, nil.
func (hl *handlerLoader) FindHandlerByType(htype string) (prefix string, handler interface{}, err error) { func (hl *handlerLoader) FindHandlerByType(htype string) (prefix string, handler interface{}, err error) {
for prefix, config := range hl.config { for prefix, config := range hl.config {
if config.htype == htype { if config.htype == htype {