From 6baedb3dc712d1c1c094c5d7465fe86347e1c25e Mon Sep 17 00:00:00 2001
From: mpl <mathieu.lonjaret@gmail.com>
Date: Mon, 8 Oct 2012 16:16:00 +0200
Subject: [PATCH] delete permanode: defined the keyDeleted index key, and added
 check in index searches to exclude deleted permanodes from the results

Change-Id: I7097e4a5dc893a212c91dff987ad7e505793fda9
---
 pkg/index/index.go | 39 ++++++++++++++++++++++++++++++++++++++-
 pkg/index/keys.go  | 10 ++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/pkg/index/index.go b/pkg/index/index.go
index 34bf10504..5b08fbd59 100644
--- a/pkg/index/index.go
+++ b/pkg/index/index.go
@@ -18,6 +18,7 @@ package index
 
 import (
 	"errors"
+	"fmt"
 	"log"
 	"os"
 	"strconv"
@@ -184,6 +185,33 @@ func closeIterator(it Iterator, perr *error) {
 	}
 }
 
+// isDeleted returns whether br (a blobref or a claim) should be considered deleted.
+func (x *Index) isDeleted(br *blobref.BlobRef) bool {
+	var err error
+	it := x.queryPrefix(keyDeleted, br)
+	defer closeIterator(it, &err)
+	for it.Next() {
+		// parts are ["deleted", br.String(), blobref-of-delete-claim].
+		// see keyDeleted in keys.go
+		parts := strings.SplitN(it.Key(), "|", 3)
+		if len(parts) != 3 {
+			continue
+		}
+		delClaimRef := blobref.Parse(parts[2])
+		if delClaimRef == nil {
+			panic(fmt.Errorf("invalid deleted claim for %v", parts[1]))
+		}
+		// The recursive call on the blobref of the delete claim
+		// checks that the claim itself was not deleted, in which case
+		// br is not considered deleted anymore.
+		// TODO(mpl): Each delete and undo delete adds a level of
+		// recursion so this could recurse far. is there a way to
+		// go faster in a worst case scenario?
+		return !x.isDeleted(delClaimRef)
+	}
+	return false
+}
+
 func (x *Index) GetRecentPermanodes(dest chan *search.Result, owner *blobref.BlobRef, limit int) (err error) {
 	defer close(dest)
 	// TODO(bradfitz): this will need to be a context wrapper too, like storage
@@ -215,6 +243,9 @@ func (x *Index) GetRecentPermanodes(dest chan *search.Result, owner *blobref.Blo
 		if permaRef == nil {
 			continue
 		}
+		if x.isDeleted(permaRef) {
+			continue
+		}
 		if seenPermanode.Dup(permaStr) {
 			continue
 		}
@@ -297,7 +328,10 @@ func (x *Index) PermanodeOfSignerAttrValue(signer *blobref.BlobRef, attr, val st
 	it := x.queryPrefix(keySignerAttrValue, keyId, attr, val)
 	defer closeIterator(it, &err)
 	if it.Next() {
-		return blobref.Parse(it.Value()), nil
+		permaRef := blobref.Parse(it.Value())
+		if permaRef != nil && !x.isDeleted(permaRef) {
+			return permaRef, nil
+		}
 	}
 	return nil, os.ErrNotExist
 }
@@ -328,6 +362,9 @@ func (x *Index) SearchPermanodesWithAttr(dest chan<- *blobref.BlobRef, request *
 		if pn == nil {
 			continue
 		}
+		if x.isDeleted(pn) {
+			continue
+		}
 		pnstr := pn.String()
 		if seen[pnstr] {
 			continue
diff --git a/pkg/index/keys.go b/pkg/index/keys.go
index 3c558eb04..c13dde105 100644
--- a/pkg/index/keys.go
+++ b/pkg/index/keys.go
@@ -186,4 +186,14 @@ var (
 			{"permanode", typeBlobRef},
 		},
 	}
+
+	// TODO(mpl): we might want to add signer/owner
+	keyDeleted = &keyType{
+		"deleted",
+		[]part{
+			{"blobref", typeBlobRef},  // the thing being deleted (a permanode or another claim)
+			{"claimref", typeBlobRef}, // the blobref with the delete claim
+		},
+		nil,
+	}
 )