From 6b4b726c69b752789510f3cec673e636497ddb1d Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 24 Feb 2011 10:28:00 -0800 Subject: [PATCH] Revert "Update for Go's new http.Request.Header type." This reverts commit b021345ed651005b38a5e75aa46e6e6976dc854f. --- lib/go/httprange/range.go | 4 ++-- server/go/auth/auth.go | 4 ++-- website/cgi.go | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/go/httprange/range.go b/lib/go/httprange/range.go index 6531b9409..ed7ad67e0 100644 --- a/lib/go/httprange/range.go +++ b/lib/go/httprange/range.go @@ -46,8 +46,8 @@ var WholeRange = &Range{0, -1} var rangePattern = regexp.MustCompile(`bytes=([0-9]+)-([0-9]*)`) func FromRequest(req *http.Request) *Range { - rrange := req.Header.Get("Range") - if rrange == "" { + rrange, ok := req.Header["Range"] + if !ok { return WholeRange } return FromString(rrange) diff --git a/server/go/auth/auth.go b/server/go/auth/auth.go index 8bf7b5302..a8b7ce610 100644 --- a/server/go/auth/auth.go +++ b/server/go/auth/auth.go @@ -29,8 +29,8 @@ var kBasicAuthPattern *regexp.Regexp = regexp.MustCompile(`^Basic ([a-zA-Z0-9\+/ var AccessPassword string func IsAuthorized(req *http.Request) bool { - auth := req.Header.Get("Authorization") - if auth == "" { + auth, present := req.Header["Authorization"] + if !present { return false } matches := kBasicAuthPattern.FindStringSubmatch(auth) diff --git a/website/cgi.go b/website/cgi.go index 0852bce6e..f72e36c92 100644 --- a/website/cgi.go +++ b/website/cgi.go @@ -69,15 +69,15 @@ func (h *CgiHandler) ServeHTTP(rw http.ResponseWriter, req *http.Request) { "SERVER_PORT=" + port, } - for k, _ := range req.Header { + for k, v := range req.Header { k = strings.Map(upperCaseAndUnderscore, k) - env = append(env, "HTTP_"+k+"="+req.Header.Get(k)) + env = append(env, "HTTP_"+k+"="+v) } if req.ContentLength > 0 { env = append(env, fmt.Sprintf("CONTENT_LENGTH=%d", req.ContentLength)) } - if ctype := req.Header.Get("Content-Type"); ctype != "" { + if ctype, ok := req.Header["Content-Type"]; ok { env = append(env, "CONTENT_TYPE="+ctype) }