From 630ba8c68f1d38ad11b0d599bd85c8a40540a7d2 Mon Sep 17 00:00:00 2001 From: Brian Gitonga Marete Date: Tue, 13 May 2014 14:23:04 +0300 Subject: [PATCH] pkg/misc/amazon/s3: Fix test broken by commit bf8d6bdb. Commit bf8d6bdb (s3: auto-select correct region, handle buckets with dots in hostname) changed the definition of s3.Client replacing the second field, which was of type *http.Client, with a field of type http.RoundTripper. But the test utility function getTestClient() was not modified accordingly. Fix this to make `go test' in pkg/misc/amazon/s3 succeed again (without this fix the test fails to build). Change-Id: Ida383e2050e215cc2446303c0ce59aa7ab6e7981 --- pkg/misc/amazon/s3/client_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/misc/amazon/s3/client_test.go b/pkg/misc/amazon/s3/client_test.go index 4e517650f..d8cbd4e5a 100644 --- a/pkg/misc/amazon/s3/client_test.go +++ b/pkg/misc/amazon/s3/client_test.go @@ -33,7 +33,7 @@ func getTestClient(t *testing.T) bool { t.Logf("Skipping test; no AWS_ACCESS_KEY_ID or AWS_ACCESS_KEY_SECRET set in environment") return false } - tc = &Client{&Auth{AccessKey: accessKey, SecretAccessKey: secret}, http.DefaultClient} + tc = &Client{&Auth{AccessKey: accessKey, SecretAccessKey: secret}, http.DefaultTransport} return true }