From 5dad68ae494e7fba529c90a4cb22bdb05687410c Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 19 Sep 2013 10:28:12 +0100 Subject: [PATCH] Add TODOs on pkg/server/share.go Change-Id: Ibc01fc6f9c266669bd556348075fdfae66cfc408 --- pkg/server/share.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/server/share.go b/pkg/server/share.go index 44fe9eac6..2867b9e65 100644 --- a/pkg/server/share.go +++ b/pkg/server/share.go @@ -75,6 +75,8 @@ func newShareFromConfig(ld blobserver.Loader, conf jsonconfig.Obj) (h http.Handl } // Unauthenticated user. Be paranoid. +// +// TODO: check IsTransitive on the share blob? http://camlistore.org/issue/226 func handleGetViaSharing(conn http.ResponseWriter, req *http.Request, blobRef blob.Ref, fetcher blob.StreamingFetcher) { if !httputil.IsGet(req) { @@ -176,12 +178,14 @@ func handleGetViaSharing(conn http.ResponseWriter, req *http.Request, viaPathOkay = true if assemble, _ := strconv.ParseBool(req.FormValue("assemble")); assemble { + // TODO: check IsTransitive on the share blob? http://camlistore.org/issue/226 dh := &DownloadHandler{ Fetcher: fetcher, // TODO(aa): It would be nice to specify a local cache here, as the UI handler does. } dh.ServeHTTP(conn, req, blobRef) } else { + // TODO: check IsTransitive on the share blob? http://camlistore.org/issue/226 gethandler.ServeBlobRef(conn, req, blobRef, fetcher) } }