From bfe0f1357782157fbaee3990f77057078460f105 Mon Sep 17 00:00:00 2001 From: mpl Date: Mon, 3 Nov 2014 19:49:50 +0100 Subject: [PATCH] dockertest: automatically clean up volumes on removal Without -v, vfs/dir/ and volumes/ are never cleaned up. Change-Id: Idbd91f19b317e0e5ca160f32f4762dcecfe10685 --- pkg/test/dockertest/docker.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/test/dockertest/docker.go b/pkg/test/dockertest/docker.go index 66324b125..deb85a4c5 100644 --- a/pkg/test/dockertest/docker.go +++ b/pkg/test/dockertest/docker.go @@ -34,6 +34,9 @@ import ( "camlistore.org/pkg/netutil" ) +// Debug, if set, prevents any container from being removed. +var Debug bool + /// runLongTest checks all the conditions for running a docker container // based on image. func runLongTest(t *testing.T, image string) { @@ -133,7 +136,10 @@ func (c ContainerID) Kill() error { // Remove runs "docker rm" on the container func (c ContainerID) Remove() error { - return exec.Command("docker", "rm", string(c)).Run() + if Debug { + return nil + } + return exec.Command("docker", "rm", "-v", string(c)).Run() } // KillRemove calls Kill on the container, and then Remove if there was