* icu: set LDFLAGS to fix fuzz-introspector
Fuzz-introspector uses LDFLAGS to force linking by way of the gold
linker. We need to use it when linking fuzzers.
* nit
These projects were tested and it was found that their use
of MSAN does not work on Ubuntu 20.04. Therefore their use of
MSAN is being disabled.
Related: #6180
* [presubmit] Enforce language attribute in projectt.yaml to be always set.
* Update documentation, better presubmit check, new project template.
* add docstring to templates.py
* Add example values in the project.yaml template and remove python value for now
* Add "project: c++" to 256 projects
* format
* Add labels and selective_unpack sections to the presubmit check
* fix incorrect auto_ccs format in three projects
* fix nss emails after rebase
* Updates the ICU fuzzer project directory:
- Delete the ICU fuzzer tests. The code was transfered to unicode-org/icu
in PR 321 (https://github.com/unicode-org/icu/pull/321).
- Adjust the Dockerfile and the build.sh to work with the new ICU repositroy
(now GitHub, migrated from svn recently) and the new code arrangement.
* Removes logging statements used for debugging statements from the Dockerfile.
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/
I ran into this because I was getting errors locally, like:
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/d/dpkg/libdpkg-perl_1.18.4ubuntu1.1_all.deb 404 Not Found [IP: 91.189.88.149 80]
It turns out you get these if you don't update, and the official best practices are to `run apt-get update && apt-get install`. In fact, running _any_ apt-get install command without the apt-get update && before it can result in unfortunate caching artifacts -- see "cache busting". (P.S. thanks to Peng on Freenode for helping me, I'm bad at Ubuntu.)
So:
sed -re \
's/RUN apt-get ((-y )?(install|build-dep))/RUN apt-get update \&\& apt-get \1/' -i \
projects/**/Dockerfile
I also manually fixed the cases that already ran apt-get update in their Dockerfile:
dlplibs/Dockerfile
grpc/Dockerfile
libreoffice/Dockerfile
Got broken after http://bugs.icu-project.org/trac/changeset/39684/trunk/icu4c/source/common/unicode/locid.h
With error like the one below:
<...>
In file included from /src/break_iterator_fuzzer.cc:8:
/src/fuzzer_utils.h:37:20: error: incomplete result type 'icu::UnicodeString' in function definition
icu::UnicodeString UnicodeStringFromUtf8(const uint8_t* data, size_t size) {
^
/src/icu/source/common/unicode/locid.h:50:7: note: forward declaration of 'icu_59::UnicodeString'
class UnicodeString;
^
<...>
DavidKorczynski