Rooba
/
oss-fuzz
mirror of https://github.com/google/oss-fuzz.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skia] Build SwiftShader without UBSAN. (#3977) 

By default a cmake based build puts user provided flags at the beginning
of a compiler invocation, giving them lowest priority. This makes it
quite difficult to add the required -fno-sanitize=vptr flag since it
will be placed before -fsanitize=undefined in a SWIFTSHADER_UBSAN build.
To make this work will require upstream changes to SwiftShader's build.

However, it is not necessary to build SwiftShader with the undefined
behavior sanitizer in order to fuzz Skia for issues. (This is only
required for the memory sanitizer which fortunately works.) As a result,
build SwiftShader without the sanitizer in the Skia undefined sanitizer
fuzzer build.
This commit is contained in:
bungeman 2020-06-12 12:35:33 -04:00 committed by GitHub
parent 16a9023078
commit b6c0816160
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
projects/skia/build.sh
View File

@ -31,7 +31,11 @@ else
elif [ $SANITIZER == "memory" ]; then
CMAKE_SANITIZER="SWIFTSHADER_MSAN"
elif [ $SANITIZER == "undefined" ]; then
CMAKE_SANITIZER="SWIFTSHADER_UBSAN"
# The current SwiftShader build needs -fno-sanitize=vptr, but it cannot be
# specified here since -fsanitize=undefined will always come after any
# user specified flags passed to cmake. SwiftShader does not need to be
# built with the undefined sanitizer in order to fuzz Skia, so don't.
CMAKE_SANITIZER="SWIFTSHADER_UBSAN_DISABLED"
else
exit 1
fi