From b16fcfc903ffe522e89996faea9388baed6c5d7e Mon Sep 17 00:00:00 2001 From: Oliver Chang Date: Wed, 6 May 2020 12:09:51 +1000 Subject: [PATCH] bisector: Properly detect MSan issues as well. (#3762) Adopt a similar start/end marker approach to CF. --- infra/bisector.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/infra/bisector.py b/infra/bisector.py index f8c416e4c..e59b8e631 100644 --- a/infra/bisector.py +++ b/infra/bisector.py @@ -47,8 +47,12 @@ import utils Result = collections.namedtuple('Result', ['repo_url', 'commit']) -CRASH_MARKERS = [ +START_MARKERS = [ '==ERROR', + '==WARNING', +] + +END_MARKERS = [ 'SUMMARY:', ] @@ -157,8 +161,12 @@ def _check_for_crash(project_name, fuzz_target, test_case_path): logging.info('stdout =\n%s', out) logging.info('stderr =\n%s', err) + # pylint: disable=unsupported-membership-test - return all(marker in out or marker in err for marker in CRASH_MARKERS) + has_start_marker = any( + marker in out or marker in err for marker in START_MARKERS) + has_end_marker = any(marker in out or marker in err for marker in END_MARKERS) + return has_start_marker and has_end_marker # pylint: disable=too-many-locals