From 7942bb4491a59cf1c1aece279bcd7687e05f7513 Mon Sep 17 00:00:00 2001 From: jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com> Date: Wed, 11 Aug 2021 11:09:24 -0700 Subject: [PATCH] [helper] Change logging from error to info (#6200) --- infra/build_specified_commit.py | 5 ++--- infra/build_specified_commit_test.py | 1 - infra/helper.py | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/infra/build_specified_commit.py b/infra/build_specified_commit.py index 4768275e1..d7b667004 100644 --- a/infra/build_specified_commit.py +++ b/infra/build_specified_commit.py @@ -11,7 +11,7 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -"""Module to build a image from a specific commit, branch or pull request +"""Module to build a image from a specific commit, branch or pull request. This module is allows each of the OSS Fuzz projects fuzzers to be built from a specific point in time. This feature can be used for implementations @@ -298,10 +298,9 @@ def detect_main_repo(project_name, repo_name=None, commit=None): project_name: The name of the oss-fuzz project. repo_name: The name of the main repo in an OSS-Fuzz project. commit: A commit SHA that is associated with the main repo. - src_dir: The location of the projects source on the docker image. Returns: - The repo's origin, the repo's path. + A tuple containing (the repo's origin, the repo's path). """ if not repo_name and not commit: diff --git a/infra/build_specified_commit_test.py b/infra/build_specified_commit_test.py index 42adae5d0..00f50947f 100644 --- a/infra/build_specified_commit_test.py +++ b/infra/build_specified_commit_test.py @@ -16,7 +16,6 @@ The will consist of the following functional tests: 1. The inference of the main repo for a specific project. 2. The building of a projects fuzzers from a specific commit. -IMPORTANT: This test needs to be run with root privileges. """ import os import tempfile diff --git a/infra/helper.py b/infra/helper.py index db97698fa..5d49765a1 100755 --- a/infra/helper.py +++ b/infra/helper.py @@ -569,9 +569,9 @@ def build_image(args): pull = y_or_n.lower() == 'y' if pull: - logging.error('Pulling latest base images...') + logging.info('Pulling latest base images...') else: - logging.error('Using cached base images...') + logging.info('Using cached base images...') # If build_image is called explicitly, don't use cache. if build_image_impl(args.project, cache=args.cache, pull=pull):