From 7797279c274d10197d62841dc43834238fd483a1 Mon Sep 17 00:00:00 2001 From: DavidKorczynski Date: Tue, 8 Nov 2022 23:24:41 +0100 Subject: [PATCH] infra: base-builder: compile: wrap find names in quotes (#8943) Wrap wildcards in quotes as otherwise the script will autocomplete if there is a e.g. .json file in the current directory. This causes the wrong files to be moved, which means `all_cov.json` will not be moved to the introspector folder and thus wrong (no) coverage data will be used. This error happens in e.g. g-api-auth-library-python --- infra/base-images/base-builder/compile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/infra/base-images/base-builder/compile b/infra/base-images/base-builder/compile index 61dea7ff3..770703e47 100755 --- a/infra/base-images/base-builder/compile +++ b/infra/base-images/base-builder/compile @@ -220,8 +220,8 @@ if [ "$SANITIZER" = "introspector" ]; then # Move coverage report. if [ -d "$OUT/textcov_reports" ] then - find $OUT/textcov_reports/ -name *.covreport -exec cp {} $SRC/inspector/ \; - find $OUT/textcov_reports/ -name *.json -exec cp {} $SRC/inspector/ \; + find $OUT/textcov_reports/ -name "*.covreport" -exec cp {} $SRC/inspector/ \; + find $OUT/textcov_reports/ -name "*.json" -exec cp {} $SRC/inspector/ \; fi cd $SRC/inspector