From 6922c8c1ac27c9a459ce41201991e296a6bace54 Mon Sep 17 00:00:00 2001 From: jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com> Date: Thu, 29 Jun 2023 16:11:47 -0400 Subject: [PATCH] Use sarif by default (#10621) --- .../getting-started/continuous_integration.md | 37 ++++++++----------- 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/docs/getting-started/continuous_integration.md b/docs/getting-started/continuous_integration.md index 93e399008..d2adc7f66 100644 --- a/docs/getting-started/continuous_integration.md +++ b/docs/getting-started/continuous_integration.md @@ -88,22 +88,20 @@ jobs: oss-fuzz-project-name: 'example' language: c++ fuzz-seconds: 600 - # Uncomment this to get results in the GitHub security dashboard. - # output-sarif: true + output-sarif: true - name: Upload Crash uses: actions/upload-artifact@v3 if: failure() && steps.build.outcome == 'success' with: name: artifacts path: ./out/artifacts - # Uncomment this to get results in the GitHub security dashboard. - # - name: Upload Sarif - # if: always() && steps.build.outcome == 'success' - # uses: github/codeql-action/upload-sarif@v2 - # with: - # # Path to SARIF file relative to the root of the repository - # sarif_file: cifuzz-sarif/results.sarif - # checkout_path: cifuzz-sarif + - name: Upload Sarif + if: always() && steps.build.outcome == 'success' + uses: github/codeql-action/upload-sarif@v2 + with: + # Path to SARIF file relative to the root of the repository + sarif_file: cifuzz-sarif/results.sarif + checkout_path: cifuzz-sarif ``` @@ -145,7 +143,6 @@ permissions: {} jobs: Fuzzing: runs-on: ubuntu-latest - # Uncomment this to get results in the GitHub security dashboard. permissions: security-events: write strategy: @@ -167,22 +164,20 @@ jobs: language: c++ fuzz-seconds: 600 sanitizer: ${{ matrix.sanitizer }} - # Uncomment this to get results in the GitHub security dashboard. - # output-sarif: true + output-sarif: true - name: Upload Crash uses: actions/upload-artifact@v3 if: steps.build.outcome == 'success' with: name: ${{ matrix.sanitizer }}-artifacts path: ./out/artifacts - # Uncomment this to get results in the GitHub security dashboard. - # - name: Upload Sarif - # if: always() && steps.build.outcome == 'success' - # uses: github/codeql-action/upload-sarif@v2 - # with: - # # Path to SARIF file relative to the root of the repository - # sarif_file: cifuzz-sarif/results.sarif - # checkout_path: cifuzz-sarif + - name: Upload Sarif + if: always() && steps.build.outcome == 'success' + uses: github/codeql-action/upload-sarif@v2 + with: + # Path to SARIF file relative to the root of the repository + sarif_file: cifuzz-sarif/results.sarif + checkout_path: cifuzz-sarif {% endraw %} ```