Rooba
/
oss-fuzz
mirror of https://github.com/google/oss-fuzz.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[infra] Update bad_build_check to work with some edge cases.

This commit is contained in:
Max Moroz 2017-08-09 08:49:41 -07:00
parent 4e23946573
commit 4b73c4b308
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
infra/base-images/base-runner/bad_build_check
View File

@ -28,10 +28,15 @@ function check_instrumentation {
fi fi
if (( $CHECK_FAILED == 0 )); then if (( $CHECK_FAILED == 0 )); then
# Should be 90 at least. The "example" target has 93. Real targets have the # The "example" target has 93 when built with ASan and 67 with UBSan. Real
# following values: arduinojson: 413, libteken: 519, zlib: 586. # targets have greater values (arduinojson: 413, libteken: 519, zlib: 586).
local THRESHOLD_FOR_NUMBER_OF_EDGES=90
if [[ $SANITIZER = undefined ]]; then
THRESHOLD_FOR_NUMBER_OF_EDGES=65
fi
local NUMBER_OF_EDGES=$(sancov -print-coverage-pcs $FUZZER | wc -l) local NUMBER_OF_EDGES=$(sancov -print-coverage-pcs $FUZZER | wc -l)
if (( $NUMBER_OF_EDGES < 90 )); then if (( $NUMBER_OF_EDGES < $THRESHOLD_FOR_NUMBER_OF_EDGES )); then
echo "BAD BUILD: the code does not seem to have coverage instrumentation." echo "BAD BUILD: the code does not seem to have coverage instrumentation."
CHECK_FAILED=1 CHECK_FAILED=1
fi fi
@ -127,6 +132,13 @@ function check_ubsan_build {
local MSAN_CALLS=$3 local MSAN_CALLS=$3
local UBSAN_CALLS=$4 local UBSAN_CALLS=$4
if [[ "$FUZZING_ENGINE" != libfuzzer ]]; then
# Ignore UBSan checks for fuzzing engines other than libFuzzer because:
# A) we (probably) are not going to use those with UBSan
# B) such builds show indistinguishable number of calls to UBSan
return 0
fi
# Perform all the checks for more verbose error message. # Perform all the checks for more verbose error message.
local CHECK_FAILED=0 local CHECK_FAILED=0