From 3cee68fa11da64856e59de22a59cf84ce90dfa72 Mon Sep 17 00:00:00 2001 From: Max Moroz Date: Mon, 12 Jun 2017 10:46:53 -0700 Subject: [PATCH] [infra] Remove "null" check from UBSan options. (#674) There is not much value for us from this particular check: - UBSan's "null" reports leading to real crashes are reported with ASan as well. - Potential null references are not real crashes and might be considered as false positives, though it seems to be UB as per the standard. --- infra/base-images/base-builder/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/infra/base-images/base-builder/Dockerfile b/infra/base-images/base-builder/Dockerfile index 01e8925e1..919f9ae4c 100644 --- a/infra/base-images/base-builder/Dockerfile +++ b/infra/base-images/base-builder/Dockerfile @@ -20,7 +20,7 @@ RUN apt-get install -y git subversion jq python3 zip make libunwind8-dev binutil # Default build flags for various sanitizers. ENV SANITIZER_FLAGS_address "-fsanitize=address -fsanitize-address-use-after-scope" -ENV SANITIZER_FLAGS_undefined "-fsanitize=bool,array-bounds,float-divide-by-zero,function,integer-divide-by-zero,null,return,shift,signed-integer-overflow,vla-bound,vptr -fno-sanitize-recover=undefined" +ENV SANITIZER_FLAGS_undefined "-fsanitize=bool,array-bounds,float-divide-by-zero,function,integer-divide-by-zero,return,shift,signed-integer-overflow,vla-bound,vptr -fno-sanitize-recover=undefined" ENV SANITIZER_FLAGS_memory "-fsanitize=memory -fsanitize-memory-track-origins" # Default build flags for coverage.