2019-12-17 00:48:49 +00:00
|
|
|
# Copyright 2019 Google LLC
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
"""Uses bisection to determine which commit a bug was introduced and fixed.
|
|
|
|
This module takes a high and a low commit SHA, a repo name, and a bug.
|
|
|
|
The module bisects the high and low commit SHA searching for the location
|
|
|
|
where the bug was introduced. It also looks for where the bug was fixed.
|
|
|
|
This is done with the following steps:
|
|
|
|
|
|
|
|
|
2020-01-15 21:30:57 +00:00
|
|
|
NOTE: Needs to be run from root of the OSS-Fuzz source checkout.
|
2019-12-17 00:48:49 +00:00
|
|
|
|
|
|
|
Typical usage example:
|
|
|
|
python3 infra/bisector.py
|
|
|
|
--commit_old 1e403e9259a1abedf108ab86f711ba52c907226d
|
|
|
|
--commit_new f79be4f2330f4b89ea2f42e1c44ca998c59a0c0f
|
|
|
|
--fuzz_target rules_fuzzer
|
|
|
|
--project_name yara
|
|
|
|
--testcase infra/yara_testcase
|
|
|
|
--sanitizer address
|
|
|
|
"""
|
|
|
|
|
|
|
|
import argparse
|
2020-01-29 22:10:04 +00:00
|
|
|
import logging
|
2019-12-17 00:48:49 +00:00
|
|
|
import tempfile
|
|
|
|
|
|
|
|
import build_specified_commit
|
|
|
|
import helper
|
|
|
|
import repo_manager
|
2020-01-29 19:03:43 +00:00
|
|
|
import utils
|
2019-12-17 00:48:49 +00:00
|
|
|
|
|
|
|
|
|
|
|
def main():
|
|
|
|
"""Finds the commit SHA where an error was initally introduced."""
|
2020-01-29 19:03:43 +00:00
|
|
|
utils.chdir_to_root()
|
2019-12-17 00:48:49 +00:00
|
|
|
parser = argparse.ArgumentParser(
|
|
|
|
description='git bisection for finding introduction of bugs')
|
|
|
|
|
2020-01-15 21:30:57 +00:00
|
|
|
parser.add_argument('--project_name',
|
|
|
|
help='The name of the project where the bug occurred.',
|
|
|
|
required=True)
|
2020-01-30 18:27:56 +00:00
|
|
|
parser.add_argument('--new_commit',
|
2020-01-15 21:30:57 +00:00
|
|
|
help='The newest commit SHA to be bisected.',
|
|
|
|
required=True)
|
2020-01-30 18:27:56 +00:00
|
|
|
parser.add_argument('--old_commit',
|
2020-01-15 21:30:57 +00:00
|
|
|
help='The oldest commit SHA to be bisected.',
|
|
|
|
required=True)
|
|
|
|
parser.add_argument('--fuzz_target',
|
|
|
|
help='The name of the fuzzer to be built.',
|
|
|
|
required=True)
|
2020-01-30 18:27:56 +00:00
|
|
|
parser.add_argument('--test_case_path',
|
2020-01-15 21:30:57 +00:00
|
|
|
help='The path to test case.',
|
|
|
|
required=True)
|
|
|
|
parser.add_argument('--engine',
|
|
|
|
help='The default is "libfuzzer".',
|
|
|
|
default='libfuzzer')
|
|
|
|
parser.add_argument('--sanitizer',
|
|
|
|
default='address',
|
|
|
|
help='The default is "address".')
|
2019-12-17 00:48:49 +00:00
|
|
|
parser.add_argument('--architecture', default='x86_64')
|
|
|
|
args = parser.parse_args()
|
2020-01-23 17:48:09 +00:00
|
|
|
|
|
|
|
build_data = build_specified_commit.BuildData(project_name=args.project_name,
|
|
|
|
engine=args.engine,
|
|
|
|
sanitizer=args.sanitizer,
|
|
|
|
architecture=args.architecture)
|
|
|
|
|
2020-01-30 18:27:56 +00:00
|
|
|
error_sha = bisect(args.old_commit, args.new_commit, args.test_case_path,
|
2019-12-17 00:48:49 +00:00
|
|
|
args.fuzz_target, build_data)
|
|
|
|
if not error_sha:
|
2020-01-29 22:10:04 +00:00
|
|
|
logging.error('No error was found in commit range %s:%s', args.commit_old,
|
|
|
|
args.commit_new)
|
2019-12-17 00:48:49 +00:00
|
|
|
return 1
|
2020-01-06 20:17:26 +00:00
|
|
|
if error_sha == args.commit_old:
|
2020-01-29 22:10:04 +00:00
|
|
|
logging.error(
|
|
|
|
'Bisection Error: Both the first and the last commits in'
|
|
|
|
'the given range have the same behavior, bisection is not possible. ')
|
2020-01-06 20:17:26 +00:00
|
|
|
return 1
|
2019-12-17 00:48:49 +00:00
|
|
|
print('Error was introduced at commit %s' % error_sha)
|
|
|
|
return 0
|
|
|
|
|
|
|
|
|
2020-01-30 18:27:56 +00:00
|
|
|
def bisect(old_commit, new_commit, test_case_path, fuzz_target, build_data):
|
2019-12-17 00:48:49 +00:00
|
|
|
"""From a commit range, this function caluclates which introduced a
|
2020-01-30 18:27:56 +00:00
|
|
|
specific error from a fuzz test_case_path.
|
2019-12-17 00:48:49 +00:00
|
|
|
|
|
|
|
Args:
|
2020-01-30 18:27:56 +00:00
|
|
|
old_commit: The oldest commit in the error regression range.
|
|
|
|
new_commit: The newest commit in the error regression range.
|
|
|
|
test_case_path: The file path of the test case that triggers the error
|
2020-01-15 21:30:57 +00:00
|
|
|
fuzz_target: The name of the fuzzer to be tested.
|
|
|
|
build_data: a class holding all of the input parameters for bisection.
|
2019-12-17 00:48:49 +00:00
|
|
|
|
|
|
|
Returns:
|
2020-01-15 21:30:57 +00:00
|
|
|
The commit SHA that introduced the error or None.
|
2020-01-06 20:17:26 +00:00
|
|
|
|
|
|
|
Raises:
|
2020-01-15 21:30:57 +00:00
|
|
|
ValueError: when a repo url can't be determine from the project.
|
2019-12-17 00:48:49 +00:00
|
|
|
"""
|
2020-01-06 20:17:26 +00:00
|
|
|
with tempfile.TemporaryDirectory() as tmp_dir:
|
2020-01-15 21:30:57 +00:00
|
|
|
repo_url, repo_name = build_specified_commit.detect_main_repo(
|
2020-01-30 18:27:56 +00:00
|
|
|
build_data.project_name, commit=old_commit)
|
2020-01-06 20:17:26 +00:00
|
|
|
if not repo_url or not repo_name:
|
|
|
|
raise ValueError('Main git repo can not be determined.')
|
2020-01-15 21:30:57 +00:00
|
|
|
bisect_repo_manager = repo_manager.RepoManager(repo_url,
|
|
|
|
tmp_dir,
|
|
|
|
repo_name=repo_name)
|
2020-01-30 18:27:56 +00:00
|
|
|
commit_list = bisect_repo_manager.get_commit_list(old_commit, new_commit)
|
2020-01-06 20:17:26 +00:00
|
|
|
old_idx = len(commit_list) - 1
|
|
|
|
new_idx = 0
|
2020-01-30 18:27:56 +00:00
|
|
|
build_specified_commit.build_fuzzers_from_commit(commit_list[new_idx],
|
|
|
|
bisect_repo_manager,
|
|
|
|
build_data)
|
2020-01-06 20:17:26 +00:00
|
|
|
expected_error_code = helper.reproduce_impl(build_data.project_name,
|
|
|
|
fuzz_target, False, [], [],
|
2020-01-30 18:27:56 +00:00
|
|
|
test_case_path)
|
2020-01-06 20:17:26 +00:00
|
|
|
|
|
|
|
# Check if the error is persistent through the commit range
|
2020-01-30 18:27:56 +00:00
|
|
|
build_specified_commit.build_fuzzers_from_commit(
|
|
|
|
commit_list[old_idx],
|
|
|
|
bisect_repo_manager,
|
|
|
|
build_data,
|
|
|
|
)
|
2020-01-15 21:30:57 +00:00
|
|
|
|
|
|
|
if expected_error_code == helper.reproduce_impl(build_data.project_name,
|
|
|
|
fuzz_target, False, [], [],
|
2020-01-30 18:27:56 +00:00
|
|
|
test_case_path):
|
2020-01-06 20:17:26 +00:00
|
|
|
return commit_list[old_idx]
|
|
|
|
|
|
|
|
while old_idx - new_idx > 1:
|
|
|
|
curr_idx = (old_idx + new_idx) // 2
|
2020-01-30 18:27:56 +00:00
|
|
|
build_specified_commit.build_fuzzers_from_commit(commit_list[curr_idx],
|
|
|
|
bisect_repo_manager,
|
|
|
|
build_data)
|
2020-01-06 20:17:26 +00:00
|
|
|
error_code = helper.reproduce_impl(build_data.project_name, fuzz_target,
|
2020-01-30 18:27:56 +00:00
|
|
|
False, [], [], test_case_path)
|
2020-01-06 20:17:26 +00:00
|
|
|
if expected_error_code == error_code:
|
|
|
|
new_idx = curr_idx
|
|
|
|
else:
|
|
|
|
old_idx = curr_idx
|
|
|
|
return commit_list[new_idx]
|
2019-12-17 00:48:49 +00:00
|
|
|
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
main()
|