Commit Graph

143 Commits

Author SHA1 Message Date
David Wilson d6945443b7 tests: add exact test for issue 251; closes #251. 2019-01-22 02:52:42 +00:00
David Wilson 2ad05f1238 issue #251, #412, #434: fix connection configuration brainwrong
This refactors connection.py to pull the two huge dict-building
functions out into new transport_transport_config.PlayContextSpec and
MitogenViaSpec classes, leaving a lot more room to breath in both files
to figure out exactly how connection configuration should work.

The changes made in 1f21a30 / 3d58832 are updated or completely removed,
the original change was misguided, in a bid to fix connection delegation
taking variables from the wrong place when delegate_to was active.

The Python path no longer defaults to '/usr/bin/python', this does not
appear to be Ansible's normal behaviour. This has changed several times,
so it may have to change again, and it may cause breakage after release.

Connection delegation respects the c.DEFAULT_REMOTE_USER whereas the
previous version simply tried to fetch whatever was in the
'ansible_user' hostvar. Many more connection delegation variables closer
match vanilla's handling, but this still requires more work. Some of the
variables need access to the command line, and upstream are in the
process of changing all that stuff around.
2019-01-22 00:40:32 +00:00
David Wilson 1b8748a8d9 tests: use assert_equal in more places. 2019-01-21 20:35:08 +00:00
David Wilson 8891b48080 tests: convert stack_construction.yml to assert_equal. 2019-01-21 20:29:25 +00:00
David Wilson 17eff064b0 tests: use assert_equal in delegate_to_template.yml. 2019-01-21 20:19:30 +00:00
David Wilson 630c058a89 tests: rename 'delegation/' to 'connection_delegation/' 2019-01-21 19:40:39 +00:00
David Wilson 9d9add3339 issue #414: reenable test. 2019-01-21 00:21:04 +00:00
David Wilson b0e7c1a315 tests: fix /etc/environment test on vanilla
Use "meta: reset_connection" to ensure /etc/environment is reloaded.
Looks like this entire feature can be ripped out!
2019-01-20 07:10:28 +00:00
David Wilson 5a96d13fd8 issue #426: fix all.yml sorting, one more delegate_to 2019-01-18 23:30:12 +00:00
David Wilson bd82fa1986 issue #426: fix low_level_execute_command.yml breakage. 2019-01-18 23:30:12 +00:00
David Wilson a6e6fd14be issue #426: more 2->3 test fixes. 2019-01-18 23:30:12 +00:00
David Wilson 67f710fd9b issue #426: use delegate_to in fixup_perms2 and copy.yml 2019-01-18 23:30:12 +00:00
David Wilson 3179951f5c issue #454: fix AttributeError and atexit.yml test. 2018-12-15 15:16:32 +00:00
David Wilson bef4b0c962 tests: fix copy.yml title 2018-11-06 22:31:50 +00:00
David Wilson a717c5406c tests: split etc_environment test in two
Turns out nobody supports ~/.pam_environment any more. Keep the
behaviour around for the time being.
2018-11-06 16:57:51 +00:00
David Wilson 374fd72dbb tests: disable mtime test on vanilla 2018-11-06 01:50:11 +00:00
David Wilson 79ca67aadd tests: disable connection tests for non-Mitogen 2018-11-05 19:51:00 +00:00
David Wilson 8972dbb7b9 tests: more Ansible fixes. 2018-11-05 19:51:00 +00:00
David Wilson acf0b04876 tests: run some playbooks against only one target. 2018-11-05 19:51:00 +00:00
David Wilson ee2d10375d tests: don't run reset_connection tests on <2.5.6. 2018-11-05 19:51:00 +00:00
David Wilson fcdfd5f107 tests: fix disconnect_cleanup.yml target count assumption 2018-11-05 19:51:00 +00:00
David Wilson 1bb239189b tests: another attempt at working paths. 2018-11-05 17:25:59 +00:00
David Wilson 5f815ec6c4 tests: try to fix PATH problem on Travis. 2018-11-05 17:25:59 +00:00
David Wilson f5f72b958f tests: avoid -u command line parameter conflict 2018-11-05 17:25:59 +00:00
David Wilson 0c3e48468b tests: run disconnect_during_module.yml in subprocess
Avoid entire run failing with unreachable
2018-11-05 13:33:33 +00:00
David Wilson 35092c5d35 tests: Unicode/bytes fixes for integration/connection/exec_command.yml 2018-11-05 13:15:40 +00:00
David Wilson 9ad022107e issue #414: disable test until rest of CI is healthy 2018-11-05 13:00:47 +00:00
David Wilson f87553b165 tests: must set ansible_become_pass in synchronize.yml. 2018-11-05 13:00:47 +00:00
David Wilson 574fc27a9c issue #414: import test / reproduction. 2018-11-05 13:00:47 +00:00
David Wilson 5eff8ea4fb tests: make result_shell_echo_hi compare less of the timedelta; closes #361
Assuming less than one second is too much to ask from Travis.
2018-11-02 15:14:00 +00:00
David Wilson c148c869e6 issue #76, #370: add disconnect cleanup test 2018-11-01 20:04:18 +00:00
David Wilson fd326f5ad7 tests: stub tests for doas/mitogen_doas 2018-11-01 00:49:26 +00:00
David Wilson cbd4129cb9 tests: fix paramiko_unblemished.yml 2018-10-31 19:15:23 +00:00
David Wilson e8fc9e490f tests: update osa_delegate_to_self to match connection parameters 2018-10-31 19:14:58 +00:00
David Wilson 6c71c5bfef issue #369: disable reset_connection on Ansible<2.5.6
https://github.com/ansible/ansible/issues/27520
2018-10-31 18:30:03 +00:00
David Wilson 8ed72e7e7b issue #369: avoid Ansible 2.5 bug (cond_reset_warn missing method) 2018-10-31 18:18:49 +00:00
David Wilson ab4ccc6b92 issue #369: don't mass-kill all SSH clients in reconnection.yml
It breaks my new development environment :)
2018-10-31 16:43:27 +00:00
David Wilson a6dd8bb2d0 issue #409: stub test for mitogen_sudo method. 2018-10-31 16:43:27 +00:00
David Wilson 144685a327 issue #409: more lxc/lxd stub tests, let tests run on vanilla. 2018-10-31 12:41:32 +00:00
David Wilson 0e8f451190 issue #409: add stub LXC test, refactor playbooks. 2018-10-31 12:12:17 +00:00
David Wilson e832ddec13 issue #409: mark sudo test noninteractive 2018-10-31 11:54:51 +00:00
David Wilson a77f07659e issue #409: make setns test to work anywhere sudo works. 2018-10-31 01:10:41 +00:00
David Wilson f2294c1678 issue #409: add new stub_connections/ test type. 2018-10-31 00:47:47 +00:00
David Wilson 96f000c5ea ansible: tilde-expand SSH key before passing to SSH; closes #334. 2018-10-30 14:58:35 +00:00
David Wilson 519faa3b3b issue #369: add Connection.reset() test. 2018-10-29 18:54:26 +00:00
David Wilson 89852db163 issue #370: add 'disconnect resets connection' test 2018-10-29 16:32:34 +00:00
David Wilson c510e58f9b issue #352: add test for disconnect message. 2018-10-29 15:59:36 +00:00
David Wilson fd5066d671 tests: teach various tests to cleanup /tmp when they're done. 2018-10-23 15:34:18 +01:00
David Wilson 7fd9fb0014 issue #397: fix another case where stray tmpdirs can be left behind.
Newer Ansibles use atexit.register() to invoke cleanup, so we need to
run those registrations after each run.
2018-10-23 15:29:03 +01:00
David Wilson 1b17aa1d1a ansible: fix temp cleanup regression and add test; closes #397. 2018-10-23 14:42:44 +01:00