Commit Graph

96 Commits

Author SHA1 Message Date
David Wilson 4bdf60326c issue #424: ansible: make put_file() raise AnsibleFileNotFound 2019-01-20 19:01:14 +00:00
David Wilson 1e9f3446c8 issue #426: big hack so reset_connection has task_var access 2019-01-19 05:17:39 +00:00
David Wilson 22de7f0e72 issue #436: fix string parsing of mitogen_ssh_debug_level
It can be a string when specified on the command line.
2018-12-08 16:07:41 +00:00
David Wilson 50241a922f ansible: call on_fork() on broker shutdown; closes #420. 2018-11-05 14:28:19 +00:00
David Wilson 35092c5d35 tests: Unicode/bytes fixes for integration/connection/exec_command.yml 2018-11-05 13:15:40 +00:00
David Wilson 6c71c5bfef issue #369: disable reset_connection on Ansible<2.5.6
https://github.com/ansible/ansible/issues/27520
2018-10-31 18:30:03 +00:00
David Wilson c4aec22a33 issue #369: fix one more _reset() reference. 2018-10-31 16:43:27 +00:00
David Wilson 6107ebdc0d issue #396: fix compatibility with Connection._reset(). 2018-10-31 16:43:27 +00:00
David Wilson 54445470e2 issue #409: add missing path config variables to severa plugins
So every method can be redirected to a stub implementation.
2018-10-31 12:40:08 +00:00
David Wilson 18af1dfb51 ansible: kubectl_path argument appears in wrong connection method
Closes #409.
2018-10-31 00:48:11 +00:00
David Wilson 96f000c5ea ansible: tilde-expand SSH key before passing to SSH; closes #334. 2018-10-30 14:58:35 +00:00
David Wilson 536690760d issue #369: teach CallChain to reset the connection. 2018-10-29 19:41:03 +00:00
David Wilson 33412927f5 issue #369: refactor Connection to support reset()
Now the tests pass.
2018-10-29 19:34:50 +00:00
David Wilson 4c81eba599 Merge commit 'refs/pull/377/head' of github.com:dw/mitogen into dmw
(Pull #377)

Changes:
- additional_parameters -> extra_args
- Merge with kubectl changes from dmw branch
- Update docs
- Remove unused username class member
- Avoid mutable kubectl_args class member
- Use six.iteritems
2018-10-02 20:00:00 +01:00
David Wilson 5521945bd2 ansible: temporary files take 5. 2018-10-02 19:19:30 +01:00
Yannig Perré 17548d1e49 [Enhancement] handle kubectl vars from Ansible connector.
This change allows the kubectl connector to support the same options as
Ansible's original connector.

The playbook sample comes with an example of a pod containing two containers
and checking that moving from one container to another, the version of Python
changes as expected.
2018-10-02 11:54:15 +02:00
Yannig Perré 6828926a36 Kubernetes connection support for mitogen. 2018-09-19 16:52:20 +02:00
David Wilson 638b196a45 ansible: fix put_file() for large temporary files.
Reverts 49736b3a, large file copies can't avoid the RTT.

The parent stack must be blocked while FileService progresses, as unlike
the small file path, it does not make a snapshot of the (possibly
temporary) file passed by the action plug-in. So we need to keep that
file alive while the service runs.

Add a new integration test and a new soak test to cover both.
2018-09-10 19:09:37 +01:00
David Wilson 90f89f95fb ansible: fix exec_command() regression. 2018-09-10 01:31:15 +01:00
David Wilson 49736b3ae8 ansible: fix FileService call, and remove another roundtrip. 2018-09-10 00:31:16 +01:00
David Wilson e241081cae ansible: stop sharing target temp_dir in runner.
This cannot work with delegate_to, since delegate_to permits multiple
concurrent tasks to be executing on the same target.
2018-09-09 23:41:53 +01:00
David Wilson 43d9815f6d ansible: use CallChain everywhere.
This replaces the 'dump to logger' behaviour of pipelined calls from
before with a call chain that returns any exception on next synchronized
call.
2018-09-09 20:29:02 +01:00
David Wilson b254eb3399 ansible: fix non-action connection instantiation.
e.g. by synchronize module.
2018-09-08 22:35:42 +01:00
David Wilson 705d77a9be ansible: remove a bunch more aliasing from connection.py. 2018-09-08 22:31:19 +01:00
David Wilson 66142e7d75 ansible: fork isolated tasks from correct parent.
Closes #355.
2018-09-08 22:17:39 +01:00
David Wilson da8c6b45b0 ansible: remove task_vars aliasing from connection.py.
Crazy spam creep.
2018-09-08 21:59:17 +01:00
David Wilson 86942b6bf9 ansible: add explanatory exception
If disconnection occurs during a Connection.call(), return
AnsibleConnectionFailure.
2018-09-08 20:53:11 +01:00
David Wilson 9792b8b54f ansible: use template-expanded delegate_to hostname in one more location. 2018-09-08 20:53:11 +01:00
David Wilson 90c2ed03d0 ansible: fix synchronize module
Broken by recent connection delegation fixes.
2018-08-20 15:43:56 +01:00
David Wilson 7458dfae85 ansible: avoid roundtrip for small file transfers.
Calls to connect.put_file() where the file is sufficiently small enough
to fit in a single RPC proceed without waiting for an RPC response. If
the write fails the target context will log an exception, and any
subsequent step depending on the written file will fail.

I verified every built-in action plugin for file transfer calls, and
they all depend on the transferred file in the following step, so this
should be safe.

Reduces template/copy actions to 2-RTT, loop-20-templates.yml runtime
reduced from 30 seconds to 10 seconds over a 250ms link compared to
v0.2.2, and from 123 seconds compared to vanilla with pipelining
enabled.
2018-08-20 15:18:03 +01:00
David Wilson bce4f59138 issue #345: disable IdentitiesOnly by default. 2018-08-19 22:13:30 +01:00
David Wilson a2686b1a2c issue #321: simplify temp directory handling. 2018-08-19 16:00:35 +01:00
David Wilson 3d588323ff issue #340: use expanded delegate_to hostname, not template.
PlayContext.delegate_to is the unexpanded template, Ansible doesn't keep
a copy of it around anywhere convenient. We either need to re-expand it
or take the expanded version that was stored on the Task, which is what
is done here.
2018-08-18 16:43:59 +01:00
David Wilson 916e46621b issue #340: add connection delegation tests. 2018-08-18 16:43:59 +01:00
David Wilson 6dcd5f8998 issue #340: split up Connection._connect()
The logic was getting too busy.
2018-08-18 16:43:59 +01:00
David Wilson a1e653978b issue #340: connection delegation used wrong variable name.
When inventory name did not match remote_addr, it would attempt to SSH
to the inventory name.
2018-08-18 16:43:59 +01:00
David Wilson 370b98f960 ansible: tidy up connection.py.
- more docstrings.
- _wrap_or_none -> optional_secret()
2018-08-18 16:43:59 +01:00
David Wilson 1f21a30e7f issue #251: ansible: watch for delegate_to during connection delegation.
This needs more work -- pretty certain that python_path and suchlike are
coming from the wrong place. Possibly we need another config_from_..()
specialized for delegate_to.
2018-08-18 16:43:59 +01:00
David Wilson 34a9f67115 issue #339: whoops, actually wire up new connection method. 2018-08-18 16:43:59 +01:00
David Wilson bfe9f81d0b ansible: fix RPC time logging.
Rendering call arguemtns was broken for non-positional arguments.
2018-07-25 16:37:49 -07:00
David Wilson 71b4294888 issue #291: 2.6 compat fix. 2018-07-25 13:25:17 -07:00
David Wilson a8e4dcc98d issue #301: correct remote_tmp evaluation context.
Vanilla Ansible expands remote_tmp variables in the context of the login
account, not any become_user account.
2018-07-23 21:43:06 -07:00
David Wilson c5ea7c45a1 comments/docs: correct mitogen.master.Context -> mitogen.parent.Context. 2018-07-23 19:11:23 -07:00
David Wilson 2c74eac19a issue #291: more Ansible-compatible script invocation
When running any kind of script, rewrite the hashbang like Ansible does,
but subsequently ignore it and explicitly use a fragment of shell from
the ansible_*_interpreter variable to call the interpreter, just like
Ansible does.

This fixes hashbangs containing '/usr/bin/env A=1 bash' on Linux, where
putting that into a hashbang line results in an infinite loop.
2018-07-23 17:40:17 -07:00
David Wilson e39c602fd3 issue #291: support UNIX hashbang syntax for ansible_*_interpreter.
Closes #291.
2018-07-22 16:24:42 -07:00
napkindrawing 745d72bb1d core: support for "doas" become_method 2018-07-12 14:54:41 -04:00
David Wilson d8e0c9e12c issue #297: local commands must execute with WorkerProcess environment. 2018-07-10 18:42:09 +01:00
David Wilson 012745efea issue #297: local actions must execute with fixed directory.
Local actions must execute in the the parent directory of the playbook
that defines the action.
2018-07-10 17:56:05 +01:00
David Wilson 410016ff47 Initial Python 3.x port work.
* ansible: use unicode_literals everywhere since it only needs to be
  compatible back to 2.6.
* compat/collections.py: delete this entirely and rip out the parts of
  functools that require it.
* Introduce serializable Kwargs dict subclass that translates keys to
  Unicode on instantiation.
* enable_debug_logging() must set _v/_vv globals.
* cStringIO does not exist in 3.x.
* Treat IOLogger and LogForwarder input as latin-1.
* Avoid ResourceWarnings in first stage by explicitly closing fps.
* Fix preamble_size.py syntax errors.
2018-07-07 14:55:47 +01:00
David Wilson 04b65020ac issue #278: ansible: support mitogen_ssh_debug_level variable. 2018-06-22 16:32:24 +01:00