From e119058d9b9f487db582e0a715b9e6e6052ed535 Mon Sep 17 00:00:00 2001
From: David Wilson <dw@botanicus.net>
Date: Thu, 12 Apr 2018 12:15:02 +0100
Subject: [PATCH] issue #182: ensure connection is reset during with_items.

Elements of a with_items loop reuse one WorkerProcess to execute every
iteration, requiring us to reset Connection's idea of the connection on
each iteration, otherwise the tasks will erroneously execute in the
wrong context.
---
 ansible_mitogen/connection.py | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/ansible_mitogen/connection.py b/ansible_mitogen/connection.py
index a2f99b1f..ace5a100 100644
--- a/ansible_mitogen/connection.py
+++ b/ansible_mitogen/connection.py
@@ -128,6 +128,8 @@ class Connection(ansible.plugins.connection.ConnectionBase):
             'sudo'
         )
 
+        self.close(new_task=True)
+
     @property
     def homedir(self):
         self._connect()
@@ -135,7 +137,7 @@ class Connection(ansible.plugins.connection.ConnectionBase):
 
     @property
     def connected(self):
-        return self.broker is not None
+        return self.context is not None
 
     def _on_connection_error(self, msg):
         raise ansible.errors.AnsibleConnectionFailure(msg)
@@ -256,11 +258,12 @@ class Connection(ansible.plugins.connection.ConnectionBase):
         if self.connected:
             return
 
-        self.broker = mitogen.master.Broker()
-        self.router, self.parent = mitogen.unix.connect(
-            path=ansible_mitogen.process.MuxProcess.unix_listener_path,
-            broker=self.broker,
-        )
+        if not self.broker:
+            self.broker = mitogen.master.Broker()
+            self.router, self.parent = mitogen.unix.connect(
+                path=ansible_mitogen.process.MuxProcess.unix_listener_path,
+                broker=self.broker,
+            )
 
         if self.original_transport == 'local':
             if self._play_context.become:
@@ -289,13 +292,15 @@ class Connection(ansible.plugins.connection.ConnectionBase):
         """
         return self.context.name
 
-    def close(self):
+    def close(self, new_task=False):
         """
         Arrange for the mitogen.master.Router running in the worker to
         gracefully shut down, and wait for shutdown to complete. Safe to call
         multiple times.
         """
-        if self.broker:
+        self.host = None
+        self.context = None
+        if self.broker and not new_task:
             self.broker.shutdown()
             self.broker.join()
             self.broker = None