core: bootstrap FD management improvements

- open fd 0/1/2 with correct file mode
- trap reserve_tty_fd in a file object, since all other FD manual FD
  management is going away.

mitogen/core.py

@@ -3381,16 +3381,13 @@ class ExternalContext(object):
 
     def _nullify_stdio(self):
         """
-        Open /dev/null to replace stdin, and stdout/stderr temporarily. In case
+        Open /dev/null to replace stdio temporarily. In case of odd startup,
-        of odd startup, assume we may be allocated a standard handle.
+        assume we may be allocated a standard handle.
         """
-        fd = os.open('/dev/null', os.O_RDWR)
+        for stdfd, mode in ((0, os.O_RDONLY), (1, os.O_RDWR), (2, os.O_RDWR)):
-        try:
+            fd = os.open('/dev/null', mode)
-            for stdfd in (0, 1, 2):
             if fd != stdfd:
                 os.dup2(fd, stdfd)
-        finally:
-            if fd not in (0, 1, 2):
                 os.close(fd)
 
     def _setup_stdio(self):
@@ -3402,10 +3399,11 @@ class ExternalContext(object):
         # around a permanent dup() to avoid receiving SIGHUP.
         try:
             if os.isatty(2):
-                self.reserve_tty_fd = os.dup(2)
+                self.reserve_tty_fp = os.fdopen(os.dup(2), 'r+b', 0)
-                set_cloexec(self.reserve_tty_fd)
+                set_cloexec(self.reserve_tty_fp)
         except OSError:
             pass
+
         # When sys.stdout was opened by the runtime, overwriting it will not
         # close FD 1. However when forking from a child that previously used
         # fdopen(), overwriting it /will/ close FD 1. So we must swallow the