Rooba
/
mitogen
mirror of https://github.com/mitogen-hq/mitogen.git
1
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

issue #360: ansible: missing lock around ContextService.put().

This commit is contained in:
David Wilson 2018-09-12 00:34:53 +01:00
parent f8bf780e21
commit 498db57ec8
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ansible_mitogen/services.py
View File

@ -139,11 +139,15 @@ class ContextService(mitogen.service.Service):
count reaches zero. count reaches zero.
""" """
LOG.debug('%r.put(%r)', self, context) LOG.debug('%r.put(%r)', self, context)
if self._refs_by_context.get(context, 0) == 0: self._lock.acquire()
LOG.warning('%r.put(%r): refcount was 0. shutdown_all called?', try:
self, context) if self._refs_by_context.get(context, 0) == 0:
return LOG.warning('%r.put(%r): refcount was 0. shutdown_all called?',
self._refs_by_context[context] -= 1 self, context)
return
self._refs_by_context[context] -= 1
finally:
self._lock.release()
def key_from_kwargs(self, **kwargs): def key_from_kwargs(self, **kwargs):
""" """