From 3bdd3e237a95ae8a88681a46bfe97ccc4ed1204b Mon Sep 17 00:00:00 2001
From: Alex Willmer <alex@moreati.org.uk>
Date: Wed, 4 Sep 2024 10:53:18 +0100
Subject: [PATCH] tests: Coverage of support for ansible_ssh_password variable

---
 docs/contributors.rst                      |  1 +
 tests/ansible/integration/ssh/password.yml | 21 ++++++++++++++++++---
 2 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/docs/contributors.rst b/docs/contributors.rst
index e40607a0..4e9e58bd 100644
--- a/docs/contributors.rst
+++ b/docs/contributors.rst
@@ -132,6 +132,7 @@ sponsorship and outstanding future-thinking of its early adopters.
     <li>Lewis Bellwood &mdash; <em>Happy to be apart of a great project.</em></li>
     <li>luto</li>
     <li><a href="https://mayeu.me/">Mayeu a.k.a Matthieu Maury</a></li>
+    <li><a href="https://github.com/madsi1m">Michael D'Silva</a></li>
     <li><a href="https://twitter.com/nathanhruby">@nathanhruby</a></li>
     <li><a href="https://github.com/opoplawski">Orion Poplawski</a></li>
     <li><a href="https://github.com/philfry">Philippe Kueck</a></li>
diff --git a/tests/ansible/integration/ssh/password.yml b/tests/ansible/integration/ssh/password.yml
index cf9396e0..9b7dcf8a 100644
--- a/tests/ansible/integration/ssh/password.yml
+++ b/tests/ansible/integration/ssh/password.yml
@@ -16,6 +16,12 @@
         ansible_ssh_pass: user1_password
       ping:
 
+    - meta: reset_connection
+    - name: ansible_ssh_password
+      vars:
+        ansible_ssh_password: user1_password
+      ping:
+
     - meta: reset_connection
     - name: absent password should fail
       ping:
@@ -34,13 +40,22 @@
         ansible_password: wrong
         ansible_ssh_pass: user1_password
 
-    # Tests that ansible_ssh_pass has priority over ansible_password
+    - meta: reset_connection
+    - name: Highest priority password variable should override all others
+      vars:
+        ansible_password: wrong
+        ansible_ssh_pass: wrong
+        ansible_ssh_password: user1_password
+      ping:
+
+    # Tests that ansible_ssh_password has priority over others
     # and that a wrong password causes a target to be marked unreachable.
     - meta: reset_connection
-    - name: ansible_password should not override
+    - name: Lower priority password variables should not override
       vars:
         ansible_password: user1_password
-        ansible_ssh_pass: wrong
+        ansible_ssh_pass: user1_password
+        ansible_ssh_password: wrong
       ping:
       ignore_errors: true
       ignore_unreachable: true