From 2eb3ea78d642f0c165e876fdd4a532283b35ff07 Mon Sep 17 00:00:00 2001
From: David Wilson <dw@botanicus.net>
Date: Tue, 11 Sep 2018 06:59:12 +0100
Subject: [PATCH] tests: remove a bunch of stray debug

---
 .../integration/action/low_level_execute_command.yml        | 1 -
 tests/ansible/integration/action/make_tmp_path.yml          | 2 --
 tests/ansible/integration/action/transfer_data.yml          | 2 --
 .../integration/async/result_binary_producing_json.yml      | 6 +++---
 .../integration/async/result_binary_producing_junk.yml      | 6 +++---
 tests/ansible/integration/async/result_shell_echo_hi.yml    | 6 +++---
 tests/ansible/integration/become/sudo_flags_failure.yml     | 3 +--
 .../integration/delegation/osa_container_standalone.yml     | 1 -
 tests/ansible/integration/glibc_caches/resolv_conf.yml      | 1 -
 .../integration/module_utils/adjacent_to_playbook.yml       | 1 -
 .../integration/module_utils/roles/modrole/tasks/main.yml   | 1 -
 .../module_utils/roles/overrides_modrole/tasks/main.yml     | 1 -
 .../ansible/integration/playbook_semantics/environment.yml  | 2 --
 .../integration/runner/custom_binary_producing_json.yml     | 1 -
 .../integration/runner/custom_binary_producing_junk.yml     | 1 -
 15 files changed, 10 insertions(+), 25 deletions(-)

diff --git a/tests/ansible/integration/action/low_level_execute_command.yml b/tests/ansible/integration/action/low_level_execute_command.yml
index 842d99d2..a42fa877 100644
--- a/tests/ansible/integration/action/low_level_execute_command.yml
+++ b/tests/ansible/integration/action/low_level_execute_command.yml
@@ -23,7 +23,6 @@
       register: raw
 
     # Can't test stdout because TTY inserts \r in Ansible version.
-    - debug: msg={{raw}}
     - name: Verify raw module output.
       assert:
         that:
diff --git a/tests/ansible/integration/action/make_tmp_path.yml b/tests/ansible/integration/action/make_tmp_path.yml
index dc713c31..0631727d 100644
--- a/tests/ansible/integration/action/make_tmp_path.yml
+++ b/tests/ansible/integration/action/make_tmp_path.yml
@@ -60,8 +60,6 @@
         path: "{{tmp_path2.result}}"
       register: stat2
 
-    - debug: msg={{stat1}}
-
     - name: "Verify neither subdir exists any more"
       assert:
         that:
diff --git a/tests/ansible/integration/action/transfer_data.yml b/tests/ansible/integration/action/transfer_data.yml
index c6845cff..bbd39309 100644
--- a/tests/ansible/integration/action/transfer_data.yml
+++ b/tests/ansible/integration/action/transfer_data.yml
@@ -37,8 +37,6 @@
         src: /tmp/transfer-data
       register: out
 
-    - debug: msg={{out}}
-
     - assert:
         that:
           out.content|b64decode == 'I am text.'
diff --git a/tests/ansible/integration/async/result_binary_producing_json.yml b/tests/ansible/integration/async/result_binary_producing_json.yml
index a53923d6..f81d0bb2 100644
--- a/tests/ansible/integration/async/result_binary_producing_json.yml
+++ b/tests/ansible/integration/async/result_binary_producing_json.yml
@@ -41,9 +41,9 @@
       src: "{{ansible_user_dir}}/.ansible_async/{{job.ansible_job_id}}"
     register: result
 
-  - debug: msg={{async_out}}
-    vars:
-      async_out: "{{result.content|b64decode|from_json}}"
+  #- debug: msg={{async_out}}
+    #vars:
+      #async_out: "{{result.content|b64decode|from_json}}"
 
   - assert:
       that:
diff --git a/tests/ansible/integration/async/result_binary_producing_junk.yml b/tests/ansible/integration/async/result_binary_producing_junk.yml
index e1628501..87877db7 100644
--- a/tests/ansible/integration/async/result_binary_producing_junk.yml
+++ b/tests/ansible/integration/async/result_binary_producing_junk.yml
@@ -27,9 +27,9 @@
       src: "{{ansible_user_dir}}/.ansible_async/{{job.ansible_job_id}}"
     register: result
 
-  - debug: msg={{async_out}}
-    vars:
-      async_out: "{{result.content|b64decode|from_json}}"
+  #- debug: msg={{async_out}}
+    #vars:
+      #async_out: "{{result.content|b64decode|from_json}}"
 
   - assert:
       that:
diff --git a/tests/ansible/integration/async/result_shell_echo_hi.yml b/tests/ansible/integration/async/result_shell_echo_hi.yml
index 77678318..8858037a 100644
--- a/tests/ansible/integration/async/result_shell_echo_hi.yml
+++ b/tests/ansible/integration/async/result_shell_echo_hi.yml
@@ -16,9 +16,9 @@
       src: "{{ansible_user_dir}}/.ansible_async/{{job.ansible_job_id}}"
     register: result
 
-  - debug: msg={{async_out}}
-    vars:
-      async_out: "{{result.content|b64decode|from_json}}"
+  #- debug: msg={{async_out}}
+    #vars:
+      #async_out: "{{result.content|b64decode|from_json}}"
 
   - assert:
       that:
diff --git a/tests/ansible/integration/become/sudo_flags_failure.yml b/tests/ansible/integration/become/sudo_flags_failure.yml
index 484134c5..52404019 100644
--- a/tests/ansible/integration/become/sudo_flags_failure.yml
+++ b/tests/ansible/integration/become/sudo_flags_failure.yml
@@ -11,12 +11,11 @@
       vars:
         ansible_become_flags: --derps
 
-    - debug: msg={{out}}
     - name: Verify raw module output.
       assert:
         that:
           - out.failed
           - |
             ('sudo: no such option: --derps' in out.msg) or
-            ("sudo: unrecognized option `--derps'" in out.module_stderr) or 
+            ("sudo: unrecognized option `--derps'" in out.module_stderr) or
             ("sudo: unrecognized option '--derps'" in out.module_stderr)
diff --git a/tests/ansible/integration/delegation/osa_container_standalone.yml b/tests/ansible/integration/delegation/osa_container_standalone.yml
index 97830d28..b942ef63 100644
--- a/tests/ansible/integration/delegation/osa_container_standalone.yml
+++ b/tests/ansible/integration/delegation/osa_container_standalone.yml
@@ -10,7 +10,6 @@
   - mitogen_get_stack:
     register: out
 
-  - debug: msg={{out}}
   - assert:
       that: |
         out.result == [
diff --git a/tests/ansible/integration/glibc_caches/resolv_conf.yml b/tests/ansible/integration/glibc_caches/resolv_conf.yml
index d1a466e9..643b83ec 100644
--- a/tests/ansible/integration/glibc_caches/resolv_conf.yml
+++ b/tests/ansible/integration/glibc_caches/resolv_conf.yml
@@ -9,7 +9,6 @@
     ansible_become_pass: has_sudo_pubkey_password
   tasks:
 
-    - debug: msg={{hostvars}}
     - mitogen_test_gethostbyname:
         name: www.google.com
       register: out
diff --git a/tests/ansible/integration/module_utils/adjacent_to_playbook.yml b/tests/ansible/integration/module_utils/adjacent_to_playbook.yml
index 34cf1c5d..63bd90b2 100644
--- a/tests/ansible/integration/module_utils/adjacent_to_playbook.yml
+++ b/tests/ansible/integration/module_utils/adjacent_to_playbook.yml
@@ -9,7 +9,6 @@
   - custom_python_external_module:
     register: out
 
-  - debug: msg={{out}}
   - assert:
       that:
       - out.external1_path == "ansible/integration/module_utils/module_utils/external1.py"
diff --git a/tests/ansible/integration/module_utils/roles/modrole/tasks/main.yml b/tests/ansible/integration/module_utils/roles/modrole/tasks/main.yml
index 857abae5..2c7c3372 100644
--- a/tests/ansible/integration/module_utils/roles/modrole/tasks/main.yml
+++ b/tests/ansible/integration/module_utils/roles/modrole/tasks/main.yml
@@ -3,7 +3,6 @@
 - uses_external3:
   register: out
 
-- debug: msg={{out}}
 - assert:
     that:
     - out.external3_path == "integration/module_utils/roles/modrole/module_utils/external3.py"
diff --git a/tests/ansible/integration/module_utils/roles/overrides_modrole/tasks/main.yml b/tests/ansible/integration/module_utils/roles/overrides_modrole/tasks/main.yml
index 24717693..6ef4703a 100644
--- a/tests/ansible/integration/module_utils/roles/overrides_modrole/tasks/main.yml
+++ b/tests/ansible/integration/module_utils/roles/overrides_modrole/tasks/main.yml
@@ -3,7 +3,6 @@
 - uses_custom_known_hosts:
   register: out
 
-- debug: msg={{out}}
 - assert:
     that:
     - out.path == "ansible/integration/module_utils/roles/override_modrole/module_utils/known_hosts.py"
diff --git a/tests/ansible/integration/playbook_semantics/environment.yml b/tests/ansible/integration/playbook_semantics/environment.yml
index 1c183a5a..1ac7f71d 100644
--- a/tests/ansible/integration/playbook_semantics/environment.yml
+++ b/tests/ansible/integration/playbook_semantics/environment.yml
@@ -9,7 +9,5 @@
         SOME_ENV: 123
       register: result
 
-    - debug: msg={{result}}
-
     - assert:
         that: "result.stdout == '123'"
diff --git a/tests/ansible/integration/runner/custom_binary_producing_json.yml b/tests/ansible/integration/runner/custom_binary_producing_json.yml
index 4fe09f0d..a3b8a224 100644
--- a/tests/ansible/integration/runner/custom_binary_producing_json.yml
+++ b/tests/ansible/integration/runner/custom_binary_producing_json.yml
@@ -19,7 +19,6 @@
       - set_fact: out={{out_linux}}
       when: ansible_system == "Linux"
 
-    - debug: msg={{out}}
     - assert:
         that: |
           out.changed and
diff --git a/tests/ansible/integration/runner/custom_binary_producing_junk.yml b/tests/ansible/integration/runner/custom_binary_producing_junk.yml
index b1672ad9..41572aad 100644
--- a/tests/ansible/integration/runner/custom_binary_producing_junk.yml
+++ b/tests/ansible/integration/runner/custom_binary_producing_junk.yml
@@ -24,7 +24,6 @@
 - hosts: test-targets
   any_errors_fatal: true
   tasks:
-    - debug: msg={{out}}
     - assert:
         that: |
           out.failed and