From ec9bc455c0cc09a2d9d3e1728477b1409016c477 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Tue, 5 Jan 2021 21:58:39 +0100 Subject: [PATCH] remove ci credential check it turns out pull requests from trusted contributors do have access to secrets, so we can't do that check. Checking for the repo only doesn't make much sense. --- release/cibuild.py | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/release/cibuild.py b/release/cibuild.py index e9731660a..33730724d 100755 --- a/release/cibuild.py +++ b/release/cibuild.py @@ -86,21 +86,6 @@ class BuildEnviron: is_pull_request = os.environ.get("GITHUB_EVENT_NAME", "pull_request") == "pull_request" - is_untrusted = ( - is_pull_request - or - os.environ.get("GITHUB_REPOSITORY", "other") != "mitmproxy/mitmproxy" - ) - has_creds = any( - x in os.environ for x in - ["AWS_ACCESS_KEY_ID", - "TWINE_USERNAME", "TWINE_PASSWORD", - "DOCKER_USERNAME", "DOCKER_PASSWORD", - "CI_BUILD_KEY"] - ) - if is_untrusted and has_creds: - raise RuntimeError("Found upload credentials even though we aren't running on CI!") - return cls( system=platform.system(), root_dir=Path(__file__).parent.parent,