From 9d1821e920d6225578a0b65881d203a537186298 Mon Sep 17 00:00:00 2001 From: Maximilian Hils Date: Thu, 28 Apr 2022 21:57:58 +0200 Subject: [PATCH] ci: improve job docs --- .github/workflows/main.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 66a7f761a..cbe19b365 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -87,11 +87,12 @@ jobs: - run: pip install tox - run: tox -e py if: matrix.os != 'ubuntu-latest' - # make sure that tests run without network connection - name: Run tox -e py (without internet) run: | - tox -e py --notest - sudo unshare --net -- sh -c "ip link set lo up; $(which tox) -e py" + # install dependencies (requires internet connectivity) + tox -e py --notest + # run tests with loopback only. We need to sudo for unshare, which means we need an absolute path for tox. + sudo unshare --net -- sh -c "ip link set lo up; $(which tox) -e py" if: matrix.os == 'ubuntu-latest' - uses: codecov/codecov-action@a1ed4b322b4b38cb846afb5a0ebfa17086917d27 # mirrored below and at https://github.com/mitmproxy/mitmproxy/settings/actions