From 08b831013357a2af96580a1186d467e5e2937f03 Mon Sep 17 00:00:00 2001
From: Maximilian Hils <git@maximilianhils.com>
Date: Tue, 26 Apr 2022 13:53:04 +0200
Subject: [PATCH] drop support for Python 3.8

---
 .github/workflows/main.yml                | 2 --
 CHANGELOG.md                              | 1 +
 CONTRIBUTING.md                           | 2 +-
 docs/src/content/overview-installation.md | 2 +-
 setup.py                                  | 3 +--
 5 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index cacee53e4..66a7f761a 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -74,8 +74,6 @@ jobs:
             py: "3.10"
           - os: ubuntu-latest
             py: 3.9
-          - os: ubuntu-latest
-            py: 3.8
     runs-on: ${{ matrix.os }}
     steps:
       - run: printenv
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 773ed37a5..d32495ed2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Unreleased: mitmproxy next
 
 * DNS support (@meitinger)
+* Mitmproxy now requires Python 3.9 or above.
 * Replayed flows retain their current position in the flow list.
   ([#5227](https://github.com/mitmproxy/mitmproxy/issues/5227), @mhils)
 * Periodically send HTTP/2 ping frames to keep connections alive.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 27a85695b..9f0496090 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -14,7 +14,7 @@ forward, please consider contributing in the following areas:
 
 ## Development Setup
 
-To get started hacking on mitmproxy, please install a recent version of Python (we require at least Python 3.8).
+To get started hacking on mitmproxy, please install a recent version of Python (we require at least Python 3.9).
 Then, do the following:
 
 ##### Linux / macOS
diff --git a/docs/src/content/overview-installation.md b/docs/src/content/overview-installation.md
index 0f13dd257..3052bb491 100644
--- a/docs/src/content/overview-installation.md
+++ b/docs/src/content/overview-installation.md
@@ -64,7 +64,7 @@ While there are plenty of options around[^1], we recommend the installation usin
     packages. Most of them (pip, virtualenv, pipenv, etc.) should just work, but we don't have the capacity to
     provide support for it.
 
-1. Install a recent version of Python (we require at least 3.8).
+1. Install a recent version of Python (we require at least 3.9).
 2. Install [pipx](https://pipxproject.github.io/pipx/).
 3. `pipx install mitmproxy`
 
diff --git a/setup.py b/setup.py
index df083718f..cb1d8cc16 100644
--- a/setup.py
+++ b/setup.py
@@ -36,7 +36,6 @@ setup(
         "Operating System :: POSIX",
         "Operating System :: Microsoft :: Windows",
         "Programming Language :: Python :: 3 :: Only",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: Implementation :: CPython",
@@ -63,7 +62,7 @@ setup(
             "mitmweb = mitmproxy.tools.main:mitmweb",
         ]
     },
-    python_requires='>=3.8',
+    python_requires='>=3.9',
     # https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/#install-requires
     # It is not considered best practice to use install_requires to pin dependencies to specific versions.
     install_requires=[