Updated Review guidelines (markdown)

Jirka Borovec 2020-10-22 17:53:39 +02:00
parent f8f9553d2a
commit f41261d630
1 changed files with 4 additions and 1 deletions

@ -51,7 +51,10 @@
- _DDP is like the same analogy but instead of copying the car 8 times, we copy it 7 times and the main car then joins those 7 to train like all._
- Make sure this works with 16-bit precision.
### 5. Check if the change is mentioned in **CHANGELOG** (no need for typos, docs, and CI).
### 5. Check if the change is mentioned in CHANGELOG
- Any bugfix, feature, substantial change in code behaviour shall be included
- No need for typos, docs, and CI edits
- [this is testing suggestion] make 2 line spacing between all items in "active" section (unreleased changes), this shall prevent collisions in git, later before release we format the active section at once
## Approving PRs